mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 21:47:59 +00:00
Code Issues Releases Wiki Activity

2292. [bug] Log if the working directory is not writable.

Browse Source 
[RT #17312]

2291.   [bug]           PR_SET_DUMPABLE may be set too late.  Also report
                        failure to set PR_SET_DUMPABLE. [RT #17312]
This commit is contained in:
Mark Andrews 2008-01-09 04:48:33 +00:00
parent 2678fccde3
commit f61a7c87bf
3 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@ -1,3 +1,9 @@
2292. [bug] Log if the working directory is not writable.
[RT #17312]
2291. [bug] PR_SET_DUMPABLE may be set too late. Also report
failure to set PR_SET_DUMPABLE. [RT #17312]
2290. [bug] Let AD in the query signal that the client wants AD 2290. [bug] Let AD in the query signal that the client wants AD
set in the response. [RT #17301] set in the response. [RT #17301]

12
bin/named/server.c
View File

@ -15,13 +15,14 @@
* PERFORMANCE OF THIS SOFTWARE. * PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: server.c,v 1.495 2007/12/14 04:01:20 marka Exp $ */ /* $Id: server.c,v 1.496 2008/01/09 04:48:33 marka Exp $ */
/*! \file */ /*! \file */
#include <config.h> #include <config.h>
#include <stdlib.h> #include <stdlib.h>
#include <unistd.h>
#include <isc/app.h> #include <isc/app.h>
#include <isc/base64.h> #include <isc/base64.h>
@ -2934,6 +2935,15 @@ load_configuration(const char *filename, ns_server_t *server,
} }
CHECK(result); CHECK(result);
/*
* Check that the working directory is writable.
*/
if (access(".", W_OK) != 0) {
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"the working directory is not writable");
}
/* /*
* Check the validity of the configuration. * Check the validity of the configuration.
*/ */

14
bin/named/unix/os.c
View File

@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE. * PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: os.c,v 1.79 2007/06/19 23:46:59 tbox Exp $ */ /* $Id: os.c,v 1.80 2008/01/09 04:48:33 marka Exp $ */
/*! \file */ /*! \file */
@ -496,15 +496,19 @@ ns_os_changeuser(void) {
ns_main_earlyfatal("setuid(): %s", strbuf); ns_main_earlyfatal("setuid(): %s", strbuf);
} }
#if defined(HAVE_LINUX_CAPABILITY_H) && !defined(HAVE_LINUXTHREADS)
linux_minprivs();
#endif
#if defined(HAVE_SYS_PRCTL_H) && defined(PR_SET_DUMPABLE) #if defined(HAVE_SYS_PRCTL_H) && defined(PR_SET_DUMPABLE)
/* /*
* Restore the ability of named to drop core after the setuid() * Restore the ability of named to drop core after the setuid()
* call has disabled it. * call has disabled it.
*/ */
prctl(PR_SET_DUMPABLE,1,0,0,0); if (prctl(PR_SET_DUMPABLE,1,0,0,0) < 0) {
isc__strerror(errno, strbuf, sizeof(strbuf));
ns_main_earlywarning("prctl(PR_SET_DUMPABLE) failed: %s",
strbuf);
}
#endif
#if defined(HAVE_LINUX_CAPABILITY_H) && !defined(HAVE_LINUXTHREADS)
linux_minprivs();
#endif #endif
} }