From fa686fcea5df03a8a9d696fbfe6f2e11d72ee3ed Mon Sep 17 00:00:00 2001 From: Aram Sargsyan Date: Fri, 10 Mar 2023 11:07:13 +0000 Subject: [PATCH] Improve dnstap system test reliability The dnstap system test fails intermittently, and it appears to be a timing issue - adding a short delay after running 'fstrm_capture', and before running 'dnstap -reopen' improves the situation from 50% failures (5 out of 10 times) to 0% failures (0 out of 20 times), tested locally. The reason is that 'fstrm_capture' is executed in the background, and due to OS scheduling and other factors, the listener socket may not be ready when the following command runs and tells 'named' to (re)open it. --- bin/tests/system/dnstap/tests.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/tests/system/dnstap/tests.sh b/bin/tests/system/dnstap/tests.sh index 27fd1ccfeb..5ed1d94c3c 100644 --- a/bin/tests/system/dnstap/tests.sh +++ b/bin/tests/system/dnstap/tests.sh @@ -669,6 +669,7 @@ EOF $FSTRM_CAPTURE -t protobuf:dnstap.Dnstap -u ns4/dnstap.out \ -w dnstap.out > fstrm_capture.out 2>&1 & fstrm_capture_pid=$! + sleep 1 $RNDCCMD -s 10.53.0.4 dnstap -reopen | sed 's/^/ns4 /' | cat_i $DIG $DIGOPTS @10.53.0.4 a.example > dig.out