From fbdd464038d9890c56ebdd848d6473e156bd17a7 Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Wed, 30 Dec 2020 13:23:18 +0100 Subject: [PATCH] Record skipped test as skipped in testsuite summary When system test execution was ported to Automake, SKIPPED and UNTESTED system test result were not made to match Automake expectations, therefore a skipped test is recorded by Automake as "PASS": $ make check TESTS=cpu V=1 I:cpu:cpu test only runs on Linux, skipping test I:cpu:Prerequisites missing, skipping test. R:cpu:SKIPPED E:cpu:2020-12-16T11:36:58+0000 PASS: cpu ==================================================================== Testsuite summary for BIND 9.17.7 ==================================================================== # TOTAL: 1 # PASS: 1 For a test to be recorded by Automake as skipped, the test, or it's test driver, needs to exit with code 77: $ make check TESTS=cpu V=1 I:cpu:cpu test only runs on Linux, skipping test I:cpu:Prerequisites missing, skipping test. R:cpu:SKIPPED E:cpu:2020-12-16T11:39:10+0000 SKIP: cpu ==================================================================== Testsuite summary for BIND 9.17.7 ==================================================================== # TOTAL: 1 # PASS: 0 # SKIP: 1 --- bin/tests/system/run.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/tests/system/run.sh.in b/bin/tests/system/run.sh.in index 7027ab2192..3a71afef08 100644 --- a/bin/tests/system/run.sh.in +++ b/bin/tests/system/run.sh.in @@ -172,7 +172,7 @@ else echowarn "R:$systest:UNTESTED" fi echoend "E:$systest:$(date_with_args)" - exit 0 + exit 77 fi # Check for PKCS#11 support