mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 01:59:26 +00:00
Code Issues Releases Wiki Activity

Remove unused link field from rdatacommon

Browse Source 
The field link in rdatacommon is unused. This change should save 16
bytes for each rdata we create.
This commit is contained in:
Alessio Podda 2025-07-11 09:15:23 +02:00
parent 32499447cb
commit fdbcdcfc06
94 changed files with 0 additions and 109 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bin/delv/delv.c
View File

@ -697,8 +697,6 @@ key_fromconfig(const cfg_obj_t *key, dns_client_t *client, dns_view_t *toview) {
dnskey.common.rdtype = dns_rdatatype_dnskey;
dnskey.mctx = NULL;
ISC_LINK_INIT(&dnskey.common, link);
dnskey.flags = (uint16_t)rdata1;
dnskey.protocol = (uint8_t)rdata2;
dnskey.algorithm = (uint8_t)rdata3;
@ -728,8 +726,6 @@ key_fromconfig(const cfg_obj_t *key, dns_client_t *client, dns_view_t *toview) {
ds.common.rdtype = dns_rdatatype_ds;
ds.mctx = NULL;
ISC_LINK_INIT(&ds.common, link);
ds.key_tag = (uint16_t)rdata1;
ds.algorithm = (uint8_t)rdata2;
ds.digest_type = (uint8_t)rdata3;

1
bin/dnssec/dnssec-signzone.c
View File

@ -1903,7 +1903,6 @@ addnsec3param(const unsigned char *salt, size_t salt_len,
nsec3param.common.rdclass = gclass;
nsec3param.common.rdtype = dns_rdatatype_nsec3param;
ISC_LINK_INIT(&nsec3param.common, link);
nsec3param.mctx = NULL;
nsec3param.flags = 0;
nsec3param.hash = unknownalg ? DNS_NSEC3_UNKNOWNALG : dns_hash_sha1;

4
bin/named/server.c
View File

@ -752,8 +752,6 @@ ta_fromconfig(const cfg_obj_t *key, bool *initialp, const char **namestrp,
*ds = (dns_rdata_ds_t){ .common.rdclass = dns_rdataclass_in,
.common.rdtype = dns_rdatatype_ds };
ISC_LINK_INIT(&ds->common, link);
switch (anchortype) {
case INIT_DNSKEY:
case STATIC_DNSKEY:
@ -770,8 +768,6 @@ ta_fromconfig(const cfg_obj_t *key, bool *initialp, const char **namestrp,
*/
keystruct.mctx = NULL;
ISC_LINK_INIT(&keystruct.common, link);
if (rdata1 > 0xffff) {
CHECKM(ISC_R_RANGE, "key flags");
}

2
lib/dns/dnssec.c
View File

@ -211,7 +211,6 @@ dns_dnssec_sign(const dns_name_t *name, dns_rdataset_t *set, dst_key_t *key,
sig.mctx = mctx;
sig.common.rdclass = set->rdclass;
sig.common.rdtype = dns_rdatatype_rrsig;
ISC_LINK_INIT(&sig.common, link);
/*
* Downcase signer.
@ -759,7 +758,6 @@ dns_dnssec_signmessage(dns_message_t *msg, dst_key_t *key) {
sig.mctx = mctx;
sig.common.rdclass = dns_rdataclass_any;
sig.common.rdtype = dns_rdatatype_sig; /* SIG(0) */
ISC_LINK_INIT(&sig.common, link);
sig.covered = 0;
sig.algorithm = dst_algorithm_tosecalg(dst_key_alg(key));

1
lib/dns/rdata/any_255/tsig_250.c
View File

@ -453,7 +453,6 @@ tostruct_any_tsig(ARGS_TOSTRUCT) {
tsig = (dns_rdata_any_tsig_t *)target;
tsig->common.rdclass = rdata->rdclass;
tsig->common.rdtype = rdata->type;
ISC_LINK_INIT(&tsig->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/ch_3/a_1.c
View File

@ -228,7 +228,6 @@ tostruct_ch_a(ARGS_TOSTRUCT) {
a->common.rdclass = rdata->rdclass;
a->common.rdtype = rdata->type;
ISC_LINK_INIT(&a->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/afsdb_18.c
View File

@ -209,7 +209,6 @@ tostruct_afsdb(ARGS_TOSTRUCT) {
afsdb->common.rdclass = rdata->rdclass;
afsdb->common.rdtype = rdata->type;
ISC_LINK_INIT(&afsdb->common, link);
dns_name_init(&afsdb->server);

1
lib/dns/rdata/generic/amtrelay_260.c
View File

@ -313,7 +313,6 @@ tostruct_amtrelay(ARGS_TOSTRUCT) {
amtrelay->common.rdclass = rdata->rdclass;
amtrelay->common.rdtype = rdata->type;
ISC_LINK_INIT(&amtrelay->common, link);
dns_name_init(&amtrelay->gateway);
amtrelay->data = NULL;

1
lib/dns/rdata/generic/avc_258.c
View File

@ -77,7 +77,6 @@ tostruct_avc(ARGS_TOSTRUCT) {
avc->common.rdclass = rdata->rdclass;
avc->common.rdtype = rdata->type;
ISC_LINK_INIT(&avc->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/caa_257.c
View File

@ -500,7 +500,6 @@ tostruct_caa(ARGS_TOSTRUCT) {
caa->common.rdclass = rdata->rdclass;
caa->common.rdtype = rdata->type;
ISC_LINK_INIT(&caa->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/cdnskey_60.c
View File

@ -90,7 +90,6 @@ tostruct_cdnskey(ARGS_TOSTRUCT) {
dnskey->common.rdclass = rdata->rdclass;
dnskey->common.rdtype = rdata->type;
ISC_LINK_INIT(&dnskey->common, link);
return generic_tostruct_key(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/cds_59.c
View File

@ -91,7 +91,6 @@ tostruct_cds(ARGS_TOSTRUCT) {
*/
cds->common.rdclass = rdata->rdclass;
cds->common.rdtype = rdata->type;
ISC_LINK_INIT(&cds->common, link);
return generic_tostruct_ds(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/cert_37.c
View File

@ -193,7 +193,6 @@ tostruct_cert(ARGS_TOSTRUCT) {
cert->common.rdclass = rdata->rdclass;
cert->common.rdtype = rdata->type;
ISC_LINK_INIT(&cert->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/cname_5.c
View File

@ -146,7 +146,6 @@ tostruct_cname(ARGS_TOSTRUCT) {
cname->common.rdclass = rdata->rdclass;
cname->common.rdtype = rdata->type;
ISC_LINK_INIT(&cname->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/csync_62.c
View File

@ -170,7 +170,6 @@ tostruct_csync(ARGS_TOSTRUCT) {
csync->common.rdclass = rdata->rdclass;
csync->common.rdtype = rdata->type;
ISC_LINK_INIT(&csync->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/dlv_32769.c
View File

@ -87,7 +87,6 @@ tostruct_dlv(ARGS_TOSTRUCT) {
dlv->common.rdclass = rdata->rdclass;
dlv->common.rdtype = rdata->type;
ISC_LINK_INIT(&dlv->common, link);
return generic_tostruct_ds(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/dname_39.c
View File

@ -146,7 +146,6 @@ tostruct_dname(ARGS_TOSTRUCT) {
dname->common.rdclass = rdata->rdclass;
dname->common.rdtype = rdata->type;
ISC_LINK_INIT(&dname->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/dnskey_48.c
View File

@ -91,7 +91,6 @@ tostruct_dnskey(ARGS_TOSTRUCT) {
dnskey->common.rdclass = rdata->rdclass;
dnskey->common.rdtype = rdata->type;
ISC_LINK_INIT(&dnskey->common, link);
return generic_tostruct_key(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/doa_259.c
View File

@ -216,7 +216,6 @@ tostruct_doa(ARGS_TOSTRUCT) {
doa->common.rdclass = rdata->rdclass;
doa->common.rdtype = rdata->type;
ISC_LINK_INIT(&doa->common, link);
dns_rdata_toregion(rdata, &region);

2
lib/dns/rdata/generic/ds_43.c
View File

@ -279,7 +279,6 @@ generic_tostruct_ds(ARGS_TOSTRUCT) {
REQUIRE(rdata->length != 0);
REQUIRE(ds->common.rdtype == rdata->type);
REQUIRE(ds->common.rdclass == rdata->rdclass);
REQUIRE(!ISC_LINK_LINKED(&ds->common, link));
dns_rdata_toregion(rdata, &region);
@ -305,7 +304,6 @@ tostruct_ds(ARGS_TOSTRUCT) {
ds->common.rdclass = rdata->rdclass;
ds->common.rdtype = rdata->type;
ISC_LINK_INIT(&ds->common, link);
return generic_tostruct_ds(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/eui48_108.c
View File

@ -138,7 +138,6 @@ tostruct_eui48(ARGS_TOSTRUCT) {
eui48->common.rdclass = rdata->rdclass;
eui48->common.rdtype = rdata->type;
ISC_LINK_INIT(&eui48->common, link);
memmove(eui48->eui48, rdata->data, rdata->length);
return ISC_R_SUCCESS;

1
lib/dns/rdata/generic/eui64_109.c
View File

@ -141,7 +141,6 @@ tostruct_eui64(ARGS_TOSTRUCT) {
eui64->common.rdclass = rdata->rdclass;
eui64->common.rdtype = rdata->type;
ISC_LINK_INIT(&eui64->common, link);
memmove(eui64->eui64, rdata->data, rdata->length);
return ISC_R_SUCCESS;

1
lib/dns/rdata/generic/gpos_27.c
View File

@ -134,7 +134,6 @@ tostruct_gpos(ARGS_TOSTRUCT) {
gpos->common.rdclass = rdata->rdclass;
gpos->common.rdtype = rdata->type;
ISC_LINK_INIT(&gpos->common, link);
dns_rdata_toregion(rdata, &region);
gpos->long_len = uint8_fromregion(&region);

1
lib/dns/rdata/generic/hinfo_13.c
View File

@ -118,7 +118,6 @@ tostruct_hinfo(ARGS_TOSTRUCT) {
hinfo->common.rdclass = rdata->rdclass;
hinfo->common.rdtype = rdata->type;
ISC_LINK_INIT(&hinfo->common, link);
dns_rdata_toregion(rdata, &region);
hinfo->cpu_len = uint8_fromregion(&region);

1
lib/dns/rdata/generic/hip_55.c
View File

@ -305,7 +305,6 @@ tostruct_hip(ARGS_TOSTRUCT) {
hip->common.rdclass = rdata->rdclass;
hip->common.rdtype = rdata->type;
ISC_LINK_INIT(&hip->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/ipseckey_45.c
View File

@ -352,7 +352,6 @@ tostruct_ipseckey(ARGS_TOSTRUCT) {
ipseckey->common.rdclass = rdata->rdclass;
ipseckey->common.rdtype = rdata->type;
ISC_LINK_INIT(&ipseckey->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/isdn_20.c
View File

@ -139,7 +139,6 @@ tostruct_isdn(ARGS_TOSTRUCT) {
isdn->common.rdclass = rdata->rdclass;
isdn->common.rdtype = rdata->type;
ISC_LINK_INIT(&isdn->common, link);
dns_rdata_toregion(rdata, &r);

2
lib/dns/rdata/generic/key_25.c
View File

@ -361,7 +361,6 @@ generic_tostruct_key(ARGS_TOSTRUCT) {
REQUIRE(key != NULL);
REQUIRE(key->common.rdclass == rdata->rdclass);
REQUIRE(key->common.rdtype == rdata->type);
REQUIRE(!ISC_LINK_LINKED(&key->common, link));
dns_rdata_toregion(rdata, &sr);
@ -417,7 +416,6 @@ tostruct_key(ARGS_TOSTRUCT) {
key->common.rdclass = rdata->rdclass;
key->common.rdtype = rdata->type;
ISC_LINK_INIT(&key->common, link);
return generic_tostruct_key(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/keydata_65533.c
View File

@ -332,7 +332,6 @@ tostruct_keydata(ARGS_TOSTRUCT) {
keydata->common.rdclass = rdata->rdclass;
keydata->common.rdtype = rdata->type;
ISC_LINK_INIT(&keydata->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/l32_105.c
View File

@ -154,7 +154,6 @@ tostruct_l32(ARGS_TOSTRUCT) {
l32->common.rdclass = rdata->rdclass;
l32->common.rdtype = rdata->type;
ISC_LINK_INIT(&l32->common, link);
dns_rdata_toregion(rdata, &region);
l32->pref = uint16_fromregion(&region);

1
lib/dns/rdata/generic/l64_106.c
View File

@ -149,7 +149,6 @@ tostruct_l64(ARGS_TOSTRUCT) {
l64->common.rdclass = rdata->rdclass;
l64->common.rdtype = rdata->type;
ISC_LINK_INIT(&l64->common, link);
dns_rdata_toregion(rdata, &region);
l64->pref = uint16_fromregion(&region);

1
lib/dns/rdata/generic/loc_29.c
View File

@ -754,7 +754,6 @@ tostruct_loc(ARGS_TOSTRUCT) {
loc->common.rdclass = rdata->rdclass;
loc->common.rdtype = rdata->type;
ISC_LINK_INIT(&loc->common, link);
loc->v.v0.version = version;
isc_region_consume(&r, 1);

1
lib/dns/rdata/generic/lp_107.c
View File

@ -157,7 +157,6 @@ tostruct_lp(ARGS_TOSTRUCT) {
lp->common.rdclass = rdata->rdclass;
lp->common.rdtype = rdata->type;
ISC_LINK_INIT(&lp->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/mb_7.c
View File

@ -145,7 +145,6 @@ tostruct_mb(ARGS_TOSTRUCT) {
mb->common.rdclass = rdata->rdclass;
mb->common.rdtype = rdata->type;
ISC_LINK_INIT(&mb->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/md_3.c
View File

@ -145,7 +145,6 @@ tostruct_md(ARGS_TOSTRUCT) {
md->common.rdclass = rdata->rdclass;
md->common.rdtype = rdata->type;
ISC_LINK_INIT(&md->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &r);

1
lib/dns/rdata/generic/mf_4.c
View File

@ -145,7 +145,6 @@ tostruct_mf(ARGS_TOSTRUCT) {
mf->common.rdclass = rdata->rdclass;
mf->common.rdtype = rdata->type;
ISC_LINK_INIT(&mf->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &r);

1
lib/dns/rdata/generic/mg_8.c
View File

@ -145,7 +145,6 @@ tostruct_mg(ARGS_TOSTRUCT) {
mg->common.rdclass = rdata->rdclass;
mg->common.rdtype = rdata->type;
ISC_LINK_INIT(&mg->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/minfo_14.c
View File

@ -209,7 +209,6 @@ tostruct_minfo(ARGS_TOSTRUCT) {
minfo->common.rdclass = rdata->rdclass;
minfo->common.rdtype = rdata->type;
ISC_LINK_INIT(&minfo->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/mr_9.c
View File

@ -145,7 +145,6 @@ tostruct_mr(ARGS_TOSTRUCT) {
mr->common.rdclass = rdata->rdclass;
mr->common.rdtype = rdata->type;
ISC_LINK_INIT(&mr->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/mx_15.c
View File

@ -233,7 +233,6 @@ tostruct_mx(ARGS_TOSTRUCT) {
mx->common.rdclass = rdata->rdclass;
mx->common.rdtype = rdata->type;
ISC_LINK_INIT(&mx->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/naptr_35.c
View File

@ -501,7 +501,6 @@ tostruct_naptr(ARGS_TOSTRUCT) {
naptr->common.rdclass = rdata->rdclass;
naptr->common.rdtype = rdata->type;
ISC_LINK_INIT(&naptr->common, link);
naptr->flags = NULL;
naptr->service = NULL;

1
lib/dns/rdata/generic/nid_104.c
View File

@ -149,7 +149,6 @@ tostruct_nid(ARGS_TOSTRUCT) {
nid->common.rdclass = rdata->rdclass;
nid->common.rdtype = rdata->type;
ISC_LINK_INIT(&nid->common, link);
dns_rdata_toregion(rdata, &region);
nid->pref = uint16_fromregion(&region);

1
lib/dns/rdata/generic/ninfo_56.c
View File

@ -77,7 +77,6 @@ tostruct_ninfo(ARGS_TOSTRUCT) {
ninfo->common.rdclass = rdata->rdclass;
ninfo->common.rdtype = rdata->type;
ISC_LINK_INIT(&ninfo->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/ns_2.c
View File

@ -159,7 +159,6 @@ tostruct_ns(ARGS_TOSTRUCT) {
ns->common.rdclass = rdata->rdclass;
ns->common.rdtype = rdata->type;
ISC_LINK_INIT(&ns->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/nsec3_50.c
View File

@ -294,7 +294,6 @@ tostruct_nsec3(ARGS_TOSTRUCT) {
nsec3->common.rdclass = rdata->rdclass;
nsec3->common.rdtype = rdata->type;
ISC_LINK_INIT(&nsec3->common, link);
region.base = rdata->data;
region.length = rdata->length;

1
lib/dns/rdata/generic/nsec3param_51.c
View File

@ -230,7 +230,6 @@ tostruct_nsec3param(ARGS_TOSTRUCT) {
nsec3param->common.rdclass = rdata->rdclass;
nsec3param->common.rdtype = rdata->type;
ISC_LINK_INIT(&nsec3param->common, link);
region.base = rdata->data;
region.length = rdata->length;

1
lib/dns/rdata/generic/nsec_47.c
View File

@ -164,7 +164,6 @@ tostruct_nsec(ARGS_TOSTRUCT) {
nsec->common.rdclass = rdata->rdclass;
nsec->common.rdtype = rdata->type;
ISC_LINK_INIT(&nsec->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/null_10.c
View File

@ -102,7 +102,6 @@ tostruct_null(ARGS_TOSTRUCT) {
null->common.rdclass = rdata->rdclass;
null->common.rdtype = rdata->type;
ISC_LINK_INIT(&null->common, link);
dns_rdata_toregion(rdata, &r);
null->length = r.length;

1
lib/dns/rdata/generic/nxt_30.c
View File

@ -243,7 +243,6 @@ tostruct_nxt(ARGS_TOSTRUCT) {
nxt->common.rdclass = rdata->rdclass;
nxt->common.rdtype = rdata->type;
ISC_LINK_INIT(&nxt->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/openpgpkey_61.c
View File

@ -146,7 +146,6 @@ tostruct_openpgpkey(ARGS_TOSTRUCT) {
sig->common.rdclass = rdata->rdclass;
sig->common.rdtype = rdata->type;
ISC_LINK_INIT(&sig->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/opt_41.c
View File

@ -366,7 +366,6 @@ tostruct_opt(ARGS_TOSTRUCT) {
opt->common.rdclass = rdata->rdclass;
opt->common.rdtype = rdata->type;
ISC_LINK_INIT(&opt->common, link);
dns_rdata_toregion(rdata, &r);
opt->length = r.length;

1
lib/dns/rdata/generic/ptr_12.c
View File

@ -163,7 +163,6 @@ tostruct_ptr(ARGS_TOSTRUCT) {
ptr->common.rdclass = rdata->rdclass;
ptr->common.rdtype = rdata->type;
ISC_LINK_INIT(&ptr->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/resinfo_261.c
View File

@ -78,7 +78,6 @@ tostruct_resinfo(ARGS_TOSTRUCT) {
resinfo->common.rdclass = rdata->rdclass;
resinfo->common.rdtype = rdata->type;
ISC_LINK_INIT(&resinfo->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/rkey_57.c
View File

@ -87,7 +87,6 @@ tostruct_rkey(ARGS_TOSTRUCT) {
rkey->common.rdclass = rdata->rdclass;
rkey->common.rdtype = rdata->type;
ISC_LINK_INIT(&rkey->common, link);
return generic_tostruct_key(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/rp_17.c
View File

@ -212,7 +212,6 @@ tostruct_rp(ARGS_TOSTRUCT) {
rp->common.rdclass = rdata->rdclass;
rp->common.rdtype = rdata->type;
ISC_LINK_INIT(&rp->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/rrsig_46.c
View File

@ -499,7 +499,6 @@ tostruct_rrsig(ARGS_TOSTRUCT) {
sig->common.rdclass = rdata->rdclass;
sig->common.rdtype = rdata->type;
ISC_LINK_INIT(&sig->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/rt_21.c
View File

@ -208,7 +208,6 @@ tostruct_rt(ARGS_TOSTRUCT) {
rt->common.rdclass = rdata->rdclass;
rt->common.rdtype = rdata->type;
ISC_LINK_INIT(&rt->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/sig_24.c
View File

@ -463,7 +463,6 @@ tostruct_sig(ARGS_TOSTRUCT) {
sig->common.rdclass = rdata->rdclass;
sig->common.rdtype = rdata->type;
ISC_LINK_INIT(&sig->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/sink_40.c
View File

@ -185,7 +185,6 @@ tostruct_sink(ARGS_TOSTRUCT) {
sink->common.rdclass = rdata->rdclass;
sink->common.rdtype = rdata->type;
ISC_LINK_INIT(&sink->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/smimea_53.c
View File

@ -84,7 +84,6 @@ tostruct_smimea(ARGS_TOSTRUCT) {
smimea->common.rdclass = rdata->rdclass;
smimea->common.rdtype = rdata->type;
ISC_LINK_INIT(&smimea->common, link);
return generic_tostruct_tlsa(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/soa_6.c
View File

@ -314,7 +314,6 @@ tostruct_soa(ARGS_TOSTRUCT) {
soa->common.rdclass = rdata->rdclass;
soa->common.rdtype = rdata->type;
ISC_LINK_INIT(&soa->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/spf_99.c
View File

@ -78,7 +78,6 @@ tostruct_spf(ARGS_TOSTRUCT) {
spf->common.rdclass = rdata->rdclass;
spf->common.rdtype = rdata->type;
ISC_LINK_INIT(&spf->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/sshfp_44.c
View File

@ -206,7 +206,6 @@ tostruct_sshfp(ARGS_TOSTRUCT) {
sshfp->common.rdclass = rdata->rdclass;
sshfp->common.rdtype = rdata->type;
ISC_LINK_INIT(&sshfp->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/ta_32768.c
View File

@ -87,7 +87,6 @@ tostruct_ta(ARGS_TOSTRUCT) {
*/
ds->common.rdclass = rdata->rdclass;
ds->common.rdtype = rdata->type;
ISC_LINK_INIT(&ds->common, link);
return generic_tostruct_ds(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/talink_58.c
View File

@ -168,7 +168,6 @@ tostruct_talink(ARGS_TOSTRUCT) {
talink->common.rdclass = rdata->rdclass;
talink->common.rdtype = rdata->type;
ISC_LINK_INIT(&talink->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/generic/tkey_249.c
View File

@ -425,7 +425,6 @@ tostruct_tkey(ARGS_TOSTRUCT) {
tkey->common.rdclass = rdata->rdclass;
tkey->common.rdtype = rdata->type;
ISC_LINK_INIT(&tkey->common, link);
dns_rdata_toregion(rdata, &sr);

2
lib/dns/rdata/generic/tlsa_52.c
View File

@ -217,7 +217,6 @@ generic_tostruct_tlsa(ARGS_TOSTRUCT) {
REQUIRE(tlsa != NULL);
REQUIRE(tlsa->common.rdclass == rdata->rdclass);
REQUIRE(tlsa->common.rdtype == rdata->type);
REQUIRE(!ISC_LINK_LINKED(&tlsa->common, link));
dns_rdata_toregion(rdata, &region);
@ -266,7 +265,6 @@ tostruct_tlsa(ARGS_TOSTRUCT) {
tlsa->common.rdclass = rdata->rdclass;
tlsa->common.rdtype = rdata->type;
ISC_LINK_INIT(&tlsa->common, link);
return generic_tostruct_tlsa(CALL_TOSTRUCT);
}

2
lib/dns/rdata/generic/txt_16.c
View File

@ -167,7 +167,6 @@ generic_tostruct_txt(ARGS_TOSTRUCT) {
REQUIRE(txt != NULL);
REQUIRE(txt->common.rdclass == rdata->rdclass);
REQUIRE(txt->common.rdtype == rdata->type);
REQUIRE(!ISC_LINK_LINKED(&txt->common, link));
dns_rdata_toregion(rdata, &r);
txt->txt_len = r.length;
@ -209,7 +208,6 @@ tostruct_txt(ARGS_TOSTRUCT) {
txt->common.rdclass = rdata->rdclass;
txt->common.rdtype = rdata->type;
ISC_LINK_INIT(&txt->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/uri_256.c
View File

@ -212,7 +212,6 @@ tostruct_uri(ARGS_TOSTRUCT) {
uri->common.rdclass = rdata->rdclass;
uri->common.rdtype = rdata->type;
ISC_LINK_INIT(&uri->common, link);
dns_rdata_toregion(rdata, &sr);

1
lib/dns/rdata/generic/wallet_262.c
View File

@ -77,7 +77,6 @@ tostruct_wallet(ARGS_TOSTRUCT) {
wallet->common.rdclass = rdata->rdclass;
wallet->common.rdtype = rdata->type;
ISC_LINK_INIT(&wallet->common, link);
return generic_tostruct_txt(CALL_TOSTRUCT);
}

1
lib/dns/rdata/generic/x25_19.c
View File

@ -147,7 +147,6 @@ tostruct_x25(ARGS_TOSTRUCT) {
x25->common.rdclass = rdata->rdclass;
x25->common.rdtype = rdata->type;
ISC_LINK_INIT(&x25->common, link);
dns_rdata_toregion(rdata, &r);
x25->x25_len = uint8_fromregion(&r);

1
lib/dns/rdata/generic/zonemd_63.c
View File

@ -258,7 +258,6 @@ tostruct_zonemd(ARGS_TOSTRUCT) {
zonemd->common.rdclass = rdata->rdclass;
zonemd->common.rdtype = rdata->type;
ISC_LINK_INIT(&zonemd->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/hs_4/a_1.c
View File

@ -160,7 +160,6 @@ tostruct_hs_a(ARGS_TOSTRUCT) {
a->common.rdclass = rdata->rdclass;
a->common.rdtype = rdata->type;
ISC_LINK_INIT(&a->common, link);
dns_rdata_toregion(rdata, &region);
n = uint32_fromregion(&region);

1
lib/dns/rdata/in_1/a6_38.c
View File

@ -351,7 +351,6 @@ tostruct_in_a6(ARGS_TOSTRUCT) {
a6->common.rdclass = rdata->rdclass;
a6->common.rdtype = rdata->type;
ISC_LINK_INIT(&a6->common, link);
dns_rdata_toregion(rdata, &r);

1
lib/dns/rdata/in_1/a_1.c
View File

@ -161,7 +161,6 @@ tostruct_in_a(ARGS_TOSTRUCT) {
a->common.rdclass = rdata->rdclass;
a->common.rdtype = rdata->type;
ISC_LINK_INIT(&a->common, link);
dns_rdata_toregion(rdata, &region);
n = uint32_fromregion(&region);

1
lib/dns/rdata/in_1/aaaa_28.c
View File

@ -173,7 +173,6 @@ tostruct_in_aaaa(ARGS_TOSTRUCT) {
aaaa->common.rdclass = rdata->rdclass;
aaaa->common.rdtype = rdata->type;
ISC_LINK_INIT(&aaaa->common, link);
dns_rdata_toregion(rdata, &r);
INSIST(r.length == 16);

1
lib/dns/rdata/in_1/apl_42.c
View File

@ -290,7 +290,6 @@ tostruct_in_apl(ARGS_TOSTRUCT) {
apl->common.rdclass = rdata->rdclass;
apl->common.rdtype = rdata->type;
ISC_LINK_INIT(&apl->common, link);
dns_rdata_toregion(rdata, &r);
apl->apl_len = r.length;

1
lib/dns/rdata/in_1/atma_34.c
View File

@ -226,7 +226,6 @@ tostruct_in_atma(ARGS_TOSTRUCT) {
atma->common.rdclass = rdata->rdclass;
atma->common.rdtype = rdata->type;
ISC_LINK_INIT(&atma->common, link);
dns_rdata_toregion(rdata, &r);
atma->format = r.base[0];

1
lib/dns/rdata/in_1/dhcid_49.c
View File

@ -146,7 +146,6 @@ tostruct_in_dhcid(ARGS_TOSTRUCT) {
dhcid->common.rdclass = rdata->rdclass;
dhcid->common.rdtype = rdata->type;
ISC_LINK_INIT(&dhcid->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/eid_31.c
View File

@ -135,7 +135,6 @@ tostruct_in_eid(ARGS_TOSTRUCT) {
eid->common.rdclass = rdata->rdclass;
eid->common.rdtype = rdata->type;
ISC_LINK_INIT(&eid->common, link);
dns_rdata_toregion(rdata, &r);
eid->eid_len = r.length;

1
lib/dns/rdata/in_1/kx_36.c
View File

@ -188,7 +188,6 @@ tostruct_in_kx(ARGS_TOSTRUCT) {
kx->common.rdclass = rdata->rdclass;
kx->common.rdtype = rdata->type;
ISC_LINK_INIT(&kx->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/nimloc_32.c
View File

@ -135,7 +135,6 @@ tostruct_in_nimloc(ARGS_TOSTRUCT) {
nimloc->common.rdclass = rdata->rdclass;
nimloc->common.rdtype = rdata->type;
ISC_LINK_INIT(&nimloc->common, link);
dns_rdata_toregion(rdata, &r);
nimloc->nimloc_len = r.length;

1
lib/dns/rdata/in_1/nsap-ptr_23.c
View File

@ -153,7 +153,6 @@ tostruct_in_nsap_ptr(ARGS_TOSTRUCT) {
nsap_ptr->common.rdclass = rdata->rdclass;
nsap_ptr->common.rdtype = rdata->type;
ISC_LINK_INIT(&nsap_ptr->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/nsap_22.c
View File

@ -170,7 +170,6 @@ tostruct_in_nsap(ARGS_TOSTRUCT) {
nsap->common.rdclass = rdata->rdclass;
nsap->common.rdtype = rdata->type;
ISC_LINK_INIT(&nsap->common, link);
dns_rdata_toregion(rdata, &r);
nsap->nsap_len = r.length;

1
lib/dns/rdata/in_1/px_26.c
View File

@ -256,7 +256,6 @@ tostruct_in_px(ARGS_TOSTRUCT) {
px->common.rdclass = rdata->rdclass;
px->common.rdtype = rdata->type;
ISC_LINK_INIT(&px->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/srv_33.c
View File

@ -272,7 +272,6 @@ tostruct_in_srv(ARGS_TOSTRUCT) {
srv->common.rdclass = rdata->rdclass;
srv->common.rdtype = rdata->type;
ISC_LINK_INIT(&srv->common, link);
dns_name_init(&name);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/svcb_64.c
View File

@ -1021,7 +1021,6 @@ generic_tostruct_in_svcb(ARGS_TOSTRUCT) {
svcb->common.rdclass = rdata->rdclass;
svcb->common.rdtype = rdata->type;
ISC_LINK_INIT(&svcb->common, link);
dns_rdata_toregion(rdata, &region);

1
lib/dns/rdata/in_1/wks_11.c
View File

@ -307,7 +307,6 @@ tostruct_in_wks(ARGS_TOSTRUCT) {
wks->common.rdclass = rdata->rdclass;
wks->common.rdtype = rdata->type;
ISC_LINK_INIT(&wks->common, link);
dns_rdata_toregion(rdata, &region);
n = uint32_fromregion(&region);

2
lib/dns/rdata/rdatastructpre.h
View File

@ -21,12 +21,10 @@
typedef struct dns_rdatacommon {
dns_rdataclass_t rdclass;
dns_rdatatype_t rdtype;
ISC_LINK(struct dns_rdatacommon) link;
} dns_rdatacommon_t;
#define DNS_RDATACOMMON_INIT(_data, _rdtype, _rdclass) \
do { \
(_data)->common.rdtype = (_rdtype); \
(_data)->common.rdclass = (_rdclass); \
ISC_LINK_INIT(&(_data)->common, link); \
} while (0)

3
lib/dns/tkey.c
View File

@ -419,7 +419,6 @@ dns_tkey_processquery(dns_message_t *msg, dns_tkeyctx_t *tctx,
tkeyout = (dns_rdata_tkey_t){
.common.rdclass = tkeyin.common.rdclass,
.common.rdtype = tkeyin.common.rdtype,
.common.link = ISC_LINK_INITIALIZER,
.mctx = msg->mctx,
.algorithm = DNS_NAME_INITEMPTY,
.mode = tkeyin.mode,
@ -595,7 +594,6 @@ dns_tkey_buildgssquery(dns_message_t *msg, const dns_name_t *name,
tkey = (dns_rdata_tkey_t){
.common.rdclass = dns_rdataclass_any,
.common.rdtype = dns_rdatatype_tkey,
.common.link = ISC_LINK_INITIALIZER,
.inception = now,
.expire = now + lifetime,
.algorithm = DNS_NAME_INITEMPTY,
@ -684,7 +682,6 @@ dns_tkey_gssnegotiate(dns_message_t *qmsg, dns_message_t *rmsg,
tkey = (dns_rdata_tkey_t){
.common.rdclass = dns_rdataclass_any,
.common.rdtype = dns_rdatatype_tkey,
.common.link = ISC_LINK_INITIALIZER,
.inception = qtkey.inception,
.expire = qtkey.expire,
.algorithm = DNS_NAME_INITEMPTY,

1
lib/dns/tsig.c
View File

@ -576,7 +576,6 @@ dns_tsig_sign(dns_message_t *msg) {
.mctx = mctx,
.common.rdclass = dns_rdataclass_any,
.common.rdtype = dns_rdatatype_tsig,
.common.link = ISC_LINK_INITIALIZER,
.timesigned = now + msg->timeadjust,
.fudge = DNS_TSIG_FUDGE,
.originalid = msg->id,

2
lib/dns/zone.c
View File

@ -4500,7 +4500,6 @@ create_keydata(dns_zone_t *zone, dns_db_t *db, dns_dbversion_t *ver,
memset(&kd, 0, sizeof(kd));
kd.common.rdclass = zone->rdclass;
kd.common.rdtype = dns_rdatatype_keydata;
ISC_LINK_INIT(&kd.common, link);
isc_buffer_init(&rrdatabuf, rrdata, sizeof(rrdata));
@ -24232,7 +24231,6 @@ dns_zone_setnsec3param(dns_zone_t *zone, uint8_t hash, uint8_t flags,
} else {
param.common.rdclass = zone->rdclass;
param.common.rdtype = dns_rdatatype_nsec3param;
ISC_LINK_INIT(&param.common, link);
param.mctx = NULL;
/*
* nsec3 specific param set in

1
tests/dns/keytable_test.c
View File

@ -114,7 +114,6 @@ create_keystruct(uint16_t flags, uint8_t proto, uint8_t alg, const char *keystr,
keystruct->common.rdclass = rdclass;
keystruct->common.rdtype = dns_rdatatype_dnskey;
keystruct->mctx = mctx;
ISC_LINK_INIT(&keystruct->common, link);
keystruct->flags = flags;
keystruct->protocol = proto;
keystruct->algorithm = alg;

1
tests/dns/tsig_test.c
View File

@ -94,7 +94,6 @@ add_tsig(dst_context_t *tsigctx, dns_tsigkey_t *key, isc_buffer_t *target,
tsig.common.rdclass = dns_rdataclass_any;
tsig.common.rdtype = dns_rdatatype_tsig;
ISC_LINK_INIT(&tsig.common, link);
dns_name_init(&tsig.algorithm);
dns_name_clone(dns_tsigkey_algorithm(key), &tsig.algorithm);