mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 14:07:59 +00:00
Code Issues Releases Wiki Activity

3942. [bug] Wildcard responses from a optout range should be

Browse Source 
marked as insecure. [RT #37072]
This commit is contained in:
Mark Andrews
2014-09-04 13:57:50 +10:00
parent c3d0221104
commit fec7998314
4 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
3942. [bug] Wildcard responses from a optout range should be
marked as insecure. [RT #37072]
3941. [doc] Include the BIND version number in the ARM. [RT #37067] 3941. [doc] Include the BIND version number in the ARM. [RT #37067]
3940. [func] "rndc nta" now allows negative trust anchors to be 3940. [func] "rndc nta" now allows negative trust anchors to be

2
bin/tests/system/dnssec/tests.sh
View File

@@ -271,7 +271,7 @@ $DIG $DIGOPTS a.wild.optout.example. \
stripns dig.out.ns3.test$n > dig.out.ns3.stripped.test$n stripns dig.out.ns3.test$n > dig.out.ns3.stripped.test$n
stripns dig.out.ns4.test$n > dig.out.ns4.stripped.test$n stripns dig.out.ns4.test$n > dig.out.ns4.stripped.test$n
$PERL ../digcomp.pl dig.out.ns3.stripped.test$n dig.out.ns4.stripped.test$n || ret=1 $PERL ../digcomp.pl dig.out.ns3.stripped.test$n dig.out.ns4.stripped.test$n || ret=1
grep "flags:.*ad.*QUERY" dig.out.ns4.test$n > /dev/null || ret=1 grep "flags:.*ad.*QUERY" dig.out.ns4.test$n > /dev/null && ret=1
grep "status: NOERROR" dig.out.ns4.test$n > /dev/null || ret=1 grep "status: NOERROR" dig.out.ns4.test$n > /dev/null || ret=1
n=`expr $n + 1` n=`expr $n + 1`
if [ $ret != 0 ]; then echo "I:failed"; fi if [ $ret != 0 ]; then echo "I:failed"; fi

3
lib/dns/nsec3.c
View File

@@ -2071,6 +2071,9 @@ dns_nsec3_noexistnodata(dns_rdatatype_t type, dns_name_t* name,
if ((nsec3.flags & DNS_NSEC3FLAG_OPTOUT) != 0) if ((nsec3.flags & DNS_NSEC3FLAG_OPTOUT) != 0)
(*logit)(arg, ISC_LOG_DEBUG(3), (*logit)(arg, ISC_LOG_DEBUG(3),
"NSEC3 indicates optout"); "NSEC3 indicates optout");
else
(*logit)(arg, ISC_LOG_DEBUG(3),
"NSEC3 indicates secure range");
*optout = *optout =
ISC_TF(nsec3.flags & DNS_NSEC3FLAG_OPTOUT); ISC_TF(nsec3.flags & DNS_NSEC3FLAG_OPTOUT);
} }

2
lib/dns/validator.c
View File

@@ -2805,7 +2805,7 @@ nsecvalidate(dns_validator_t *val, isc_boolean_t resume) {
if (!NEEDNODATA(val) && !NEEDNOWILDCARD(val) && NEEDNOQNAME(val)) { if (!NEEDNODATA(val) && !NEEDNOWILDCARD(val) && NEEDNOQNAME(val)) {
if (!FOUNDNOQNAME(val)) if (!FOUNDNOQNAME(val))
findnsec3proofs(val); findnsec3proofs(val);
if (FOUNDNOQNAME(val) && FOUNDCLOSEST(val)) { if (FOUNDNOQNAME(val) && FOUNDCLOSEST(val) && !FOUNDOPTOUT(val)) {
validator_log(val, ISC_LOG_DEBUG(3), validator_log(val, ISC_LOG_DEBUG(3),
"marking as secure, noqname proof found"); "marking as secure, noqname proof found");
marksecure(val->event); marksecure(val->event);