mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 07:35:26 +00:00
Code Issues Releases Wiki Activity

dns/lookup.c: Return void when ISC_R_SUCCESS is only returned value

Browse Source 
With isc_mem_get() and dns_name_dup() no longer being able to fail, some
functions can now only return ISC_R_SUCCESS.  Change the return type to
void for the following function(s):

 * build_event()
This commit is contained in:
Ondřej Surý
2021-10-06 12:46:45 +02:00
parent ee735ba79d
commit ffd09ec5f0
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/dns/lookup.c
View File

@@ -90,7 +90,7 @@ start_fetch(dns_lookup_t *lookup) {
return (result); return (result);
} }
static isc_result_t static void
build_event(dns_lookup_t *lookup) { build_event(dns_lookup_t *lookup) {
dns_name_t *name = NULL; dns_name_t *name = NULL;
dns_rdataset_t *rdataset = NULL; dns_rdataset_t *rdataset = NULL;
@@ -115,8 +115,6 @@ build_event(dns_lookup_t *lookup) {
lookup->event->name = name; lookup->event->name = name;
lookup->event->rdataset = rdataset; lookup->event->rdataset = rdataset;
lookup->event->sigrdataset = sigrdataset; lookup->event->sigrdataset = sigrdataset;
return (ISC_R_SUCCESS);
} }
static isc_result_t static isc_result_t
@@ -216,7 +214,7 @@ lookup_find(dns_lookup_t *lookup, dns_fetchevent_t *event) {
switch (result) { switch (result) {
case ISC_R_SUCCESS: case ISC_R_SUCCESS:
result = build_event(lookup); build_event(lookup);
if (event == NULL) { if (event == NULL) {
break; break;
} }