Ondřej Surý
056e133c4c
Use clang-tidy to add curly braces around one-line statements
...
The command used to reformat the files in this commit was:
./util/run-clang-tidy \
-clang-tidy-binary clang-tidy-11
-clang-apply-replacements-binary clang-apply-replacements-11 \
-checks=-*,readability-braces-around-statements \
-j 9 \
-fix \
-format \
-style=file \
-quiet
clang-format -i --style=format $(git ls-files '*.c' '*.h')
uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h')
clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 22:07:21 +01:00
Ondřej Surý
36c6105e4f
Use coccinelle to add braces to nested single line statement
...
Both clang-tidy and uncrustify chokes on statement like this:
for (...)
if (...)
break;
This commit uses a very simple semantic patch (below) to add braces around such
statements.
Semantic patch used:
@@
statement S;
expression E;
@@
while (...)
- if (E) S
+ { if (E) { S } }
@@
statement S;
expression E;
@@
for (...;...;...)
- if (E) S
+ { if (E) { S } }
@@
statement S;
expression E;
@@
if (...)
- if (E) S
+ { if (E) { S } }
2020-02-13 21:58:55 +01:00
Ondřej Surý
f50b1e0685
Use clang-format to reformat the source files
2020-02-12 15:04:17 +01:00
Ondřej Surý
bc1d4c9cb4
Clear the pointer to destroyed object early using the semantic patch
...
Also disable the semantic patch as the code needs tweaks here and there because
some destroy functions might not destroy the object and return early if the
object is still in use.
2020-02-09 18:00:17 -08:00
Ondřej Surý
c2dad0dcb2
Replace RUNTIME_CHECK(dns_name_copy(..., NULL)) with dns_name_copynf()
...
Use the semantic patch from the previous commit to replace all the calls to
dns_name_copy() with NULL as third argument with dns_name_copynf().
2019-10-01 10:43:26 +10:00
Ondřej Surý
35bd7e4da0
Add RUNTIME_CHECK() around plain dns_name_copy(..., NULL) calls using spatch
...
This commit add RUNTIME_CHECK() around all simple dns_name_copy() calls where
the third argument is NULL using the semantic patch from the previous commit.
2019-10-01 10:43:26 +10:00
Ondřej Surý
ae83801e2b
Remove blocks checking whether isc_mem_get() failed using the coccinelle
2019-07-23 15:32:35 -04:00
Ondřej Surý
78d0cb0a7d
Use coccinelle to remove explicit '#include <config.h>' from the source files
2019-03-08 15:15:05 +01:00
Ondřej Surý
23fff6c569
Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
2018-11-08 12:22:17 +07:00
Ondřej Surý
b2b43fd235
Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
2018-11-08 12:21:53 +07:00
Ondřej Surý
994e656977
Replace custom isc_boolean_t with C standard bool type
2018-08-08 09:37:30 +02:00
Ondřej Surý
cb6a185c69
Replace custom isc_u?intNN_t types with C99 u?intNN_t types
2018-08-08 09:37:28 +02:00
Mark Andrews
329a0e7812
Remove support for silently ignoring 'no-change' deltas from BIND 8 when processing an IXFR stream. 'no-change' deltas will now trigger a fallback to AXFR as the recovery mechanism.
2018-07-10 19:20:09 -07:00
Witold Kręcicki
b1254430df
Fallback to normal procedure if creating of ixfr-from-differences fails
2018-06-27 17:32:17 -07:00
Witold Kręcicki
0db7130f2b
Fix some issues with large journal entries
2018-06-27 16:04:06 +02:00
Ondřej Surý
9fda5253fd
Remove isc_string_printf and isc_string_printf_truncate.
...
Replace with simple snprintf() as appropriate.
2018-04-12 10:37:33 +02:00
Michał Kępień
4df4a8e731
Use dns_fixedname_initname() where possible
...
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.
This patch was mostly prepared using Coccinelle and the following
semantic patch:
@@
expression fixedname, name;
@@
- dns_fixedname_init(&fixedname);
...
- name = dns_fixedname_name(&fixedname);
+ name = dns_fixedname_initname(&fixedname);
The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.
It is likely that more occurrences of this pattern can be refactored in
an identical way. This commit only takes care of the low-hanging fruit.
2018-04-09 12:14:16 +02:00
Ondřej Surý
843d389661
Update license headers to not include years in copyright in all applicable files
2018-02-23 10:12:02 +01:00
Mark Andrews
4bf32aa587
4654. [cleanup] Don't use C++ keywords delete, new and namespace.
...
[RT #45538 ]
2017-07-21 11:52:24 +10:00
Tinderbox User
b168f3f805
update copyright notice / whitespace
2017-05-02 23:45:36 +00:00
Evan Hunt
d39ab7440e
[master] automatically tune max-journal-size
...
4613. [func] By default, the maximum size of a zone journal file
is now twice the size of the zone's contents (there
is little benefit to a journal larger than this).
This can be overridden by setting "max-journal-size"
to "unlimited" or to an explicit value up to 2G.
Thanks to Tony Finch. [RT #38324 ]
2017-05-02 13:23:08 -07:00
Mark Andrews
0c27b3fe77
4401. [misc] Change LICENSE to MPL 2.0.
2016-06-27 14:56:38 +10:00
李昶
65f6e2f909
Cleanup in journal_open() correctly ( #41129 )
2015-11-19 11:20:59 +05:30
Mark Andrews
e53e202ef3
4128. [bug] Address issues raised by Coverity 7.6. [RT #39537 ]
2015-05-28 13:17:07 +10:00
Francis Dupont
3759f10fc5
added print.h includes, updated copyrights
2015-05-23 14:21:51 +02:00
Tinderbox User
5e93bad21b
update copyright notice / whitespace
2015-03-01 23:45:20 +00:00
Mark Andrews
a8da00ef95
4079. [func] Preserve the case of the ownername of records to
...
the RRset level. [RT #37442 ]
2015-02-27 15:08:38 +11:00
Mark Andrews
af669cb4fd
4074. [cleanup] Cleaned up more warnings from gcc -Wshadow. [RT #38708 ]
2015-02-27 10:55:55 +11:00
Mark Andrews
9c0589bc8b
3966. [bug] Missing dns_db_closeversion call in receive_secure_db.
...
[RT #35746 ]
2014-10-03 07:50:09 +10:00
Tinderbox User
431a83fb29
update copyright notice
2014-01-09 23:46:35 +00:00
Evan Hunt
e851ea8260
[master] replace memcpy() with memmove().
...
3698. [cleanup] Replaced all uses of memcpy() with memmove().
[RT #35120 ]
2014-01-08 16:39:05 -08:00
Mark Andrews
53f70575bd
silence compiler warnings
2013-12-06 17:38:25 +11:00
Mark Andrews
c3c8823fed
3681. [port] Update the Windows build system to support feature
...
selection and WIN64 builds. This is a work in
progress. [RT #34160 ]
2013-12-04 12:47:23 +11:00
Evan Hunt
18df9e628e
[master] strdup journal filename
...
3646. [bug] Journal filename string could be set incorrectly,
causing garbage in log messages. [RT #34738 ]
2013-09-09 22:12:47 -07:00
Evan Hunt
79e6f6e519
[master] deprecate dns_journal_rollforward2
...
no longer needed since change #3641
2013-09-04 16:19:52 -07:00
Mark Andrews
b5f4cc132e
3641. [bug] Handle changes to sig-validity-interval settings
...
better. [RT #34625 ]
2013-09-04 13:45:00 +10:00
Evan Hunt
31707708c5
[master] portability fixes for map files
...
3598. [cleanup] Improved portability of map file code. [RT #33820 ]
2013-06-17 09:09:43 -07:00
Tinderbox User
573d78f3d5
update copyright notice
2013-02-21 23:45:56 +00:00
Evan Hunt
df925e6c66
[master] add zone memory context pools
...
3492. [bug] Fixed a regression in zone loading performance
due to lock contention. [RT #30399 ]
2013-02-20 21:39:05 -08:00
Evan Hunt
f30785f506
3252. [bug] When master zones using inline-signing were
...
updated while the server was offline, the source
zone could fall out of sync with the signed
copy. They can now resynchronize. [RT #26676 ]
2011-12-22 07:32:41 +00:00
Automatic Updater
806956b43b
update copyright notice
2011-12-05 23:46:35 +00:00
Mark Andrews
de52784e45
3235. [func] dns_db_diffx, a extended dns_db_diff which returns
...
the generated diff and optionally writes it to a
journal. [RT #26386 ]
2011-12-04 23:48:12 +00:00
Mark Andrews
91ed1cc821
3222. [cleanup] Replace dns_journal_{get,set}_bitws with
...
dns_journal_{get,set}_sourceserial. [RT #26634 ]
2011-11-28 03:14:59 +00:00
Automatic Updater
4e68c7c87c
update copyright notice
2011-08-30 23:46:53 +00:00
Mark Andrews
9198ab377b
3147. [func] Initial inline signing support. [RT #23657 ]
2011-08-30 05:16:15 +00:00
Automatic Updater
c1aef54e14
update copyright notice
2011-03-12 04:59:49 +00:00
Mark Andrews
0874abad14
3069. [cleanup] Silence warnings messages from clang static analysis.
...
[RT #20256 ]
2011-03-11 06:11:27 +00:00
Automatic Updater
33cc94f04c
update copyright notice
2010-11-17 23:47:09 +00:00
Evan Hunt
8eb30f8dd3
2971. [bug] Fixed a bug that caused journal files not to be
...
compacted on Windows systems as a result of
non-POSIX-compliant rename() semantics. [RT #22434 ]
2010-11-17 00:27:54 +00:00
Automatic Updater
2d84cba8f4
update copyright notice
2009-11-04 23:48:18 +00:00