Ondřej Surý
056e133c4c
Use clang-tidy to add curly braces around one-line statements
...
The command used to reformat the files in this commit was:
./util/run-clang-tidy \
-clang-tidy-binary clang-tidy-11
-clang-apply-replacements-binary clang-apply-replacements-11 \
-checks=-*,readability-braces-around-statements \
-j 9 \
-fix \
-format \
-style=file \
-quiet
clang-format -i --style=format $(git ls-files '*.c' '*.h')
uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h')
clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 22:07:21 +01:00
Ondřej Surý
f50b1e0685
Use clang-format to reformat the source files
2020-02-12 15:04:17 +01:00
Ondřej Surý
ae83801e2b
Remove blocks checking whether isc_mem_get() failed using the coccinelle
2019-07-23 15:32:35 -04:00
Ondřej Surý
78d0cb0a7d
Use coccinelle to remove explicit '#include <config.h>' from the source files
2019-03-08 15:15:05 +01:00
Ondřej Surý
b2b43fd235
Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
2018-11-08 12:21:53 +07:00
Ondřej Surý
0f24c55d38
Refactor *_destroy and *_detach functions to unified order of actions.
...
This properly orders clearing the freed pointer and calling isc_refcount_destroy
as early as possible to have ability to put proper memory barrier when cleaning
up reference counting.
2018-08-28 13:15:59 +02:00
Ondřej Surý
bef8ac5bae
Rewrite isc_refcount API to fetch_and_<op>, instead of former <op>_and_<fetch>
2018-08-28 12:15:39 +02:00
Ondřej Surý
cb6a185c69
Replace custom isc_u?intNN_t types with C99 u?intNN_t types
2018-08-08 09:37:28 +02:00
Evan Hunt
3006ccb7f0
improve readability of radix code
...
- use RADIX_V4 and RADIX_V6 instead of 0 and 1 as array indices
- remove some unused macros
2018-05-28 18:45:41 -04:00
Evan Hunt
e324449349
remove the experimental authoritative ECS support from named
...
- mark the 'geoip-use-ecs' option obsolete; warn when it is used
in named.conf
- prohibit 'ecs' ACL tags in named.conf; note that this is a fatal error
since simply ignoring the tags could make ACLs behave unpredictably
- re-simplify the radix and iptable code
- clean up dns_acl_match(), dns_aclelement_match(), dns_acl_allowed()
and dns_geoip_match() so they no longer take ecs options
- remove the ECS-specific unit and system test cases
- remove references to ECS from the ARM
2018-05-25 08:21:25 -07:00
Ondřej Surý
55a10b7acd
Remove $Id markers, Principal Author and Reviewed tags from the full source tree
2018-05-11 13:17:46 +02:00
Ondřej Surý
843d389661
Update license headers to not include years in copyright in all applicable files
2018-02-23 10:12:02 +01:00
Mukund Sivaraman
4116177ac4
Make fixes for GCC 6 ( #42721 )
2016-07-13 13:55:50 +05:30
Mark Andrews
0c27b3fe77
4401. [misc] Change LICENSE to MPL 2.0.
2016-06-27 14:56:38 +10:00
Tinderbox User
4e92a74ec4
update copyright notice / whitespace
2015-05-05 23:45:24 +00:00
Mukund Sivaraman
8f25faf972
Fix a regression in radix tree implementation introduced by ECS code ( #38983 )
2015-05-05 13:11:23 +05:30
Mark Andrews
b976c39c07
3998. [bug] isc_radix_search was returning matches that were
...
to precise. [RT #37680 ]
2014-11-04 12:34:12 +11:00
Tinderbox User
3278ff814d
update copyright notice
2014-08-29 23:45:22 +00:00
Evan Hunt
d46855caed
[master] ECS authoritative support
...
3936. [func] Added authoritative support for the EDNS Client
Subnet (ECS) option.
ACLs can now include "ecs" elements which specify
an address or network prefix; if an ECS option is
included in a DNS query, then the address encoded
in the option will be matched against "ecs" ACL
elements.
Also, if an ECS address is included in a query,
then it will be used instead of the client source
address when matching "geoip" ACL elements. This
behavior can be overridden with "geoip-use-ecs no;".
When "ecs" or "geoip" ACL elements are used to
select a view for a query, the response will include
an ECS option to indicate which client network the
answer is valid for.
(Thanks to Vincent Bernat.) [RT #36781 ]
2014-08-28 22:05:57 -07:00
Evan Hunt
3e5743068c
[master] use-after-free in isc_radix_remove()
...
3826. [bug] Corrected a use-after-free in isc_radix_remove().
(This function is not used in BIND, but could have
caused problems in programs linking to libisc.)
[RT #35870 ]
2014-04-29 15:21:46 -07:00
Tinderbox User
431a83fb29
update copyright notice
2014-01-09 23:46:35 +00:00
Evan Hunt
e851ea8260
[master] replace memcpy() with memmove().
...
3698. [cleanup] Replaced all uses of memcpy() with memmove().
[RT #35120 ]
2014-01-08 16:39:05 -08:00
Tinderbox User
573d78f3d5
update copyright notice
2013-02-21 23:45:56 +00:00
Evan Hunt
df925e6c66
[master] add zone memory context pools
...
3492. [bug] Fixed a regression in zone loading performance
due to lock contention. [RT #30399 ]
2013-02-20 21:39:05 -08:00
Tinderbox User
5fa46bc916
update copyright notice
2012-03-10 23:45:53 +00:00
Mark Andrews
28a8f5b0de
set $Id$
2012-03-08 00:21:15 +11:00
Automatic Updater
c1aef54e14
update copyright notice
2011-03-12 04:59:49 +00:00
Mark Andrews
0874abad14
3069. [cleanup] Silence warnings messages from clang static analysis.
...
[RT #20256 ]
2011-03-11 06:11:27 +00:00
Automatic Updater
9a14f870dd
update copyright notice
2009-01-18 23:48:14 +00:00
Francis Dupont
a05abc1767
spelling
2009-01-18 00:50:21 +00:00
Mark Andrews
175a8bd2b7
2502. [cleanup] isc_radix: Improve compliance with coding style,
...
document function in <isc/radix.h>. [RT #18534 ]
2008-12-01 00:04:21 +00:00
Mark Andrews
0d444dc136
2470. [bug] Elements of the isc_radix_node_t could be incorrectly
...
overwritten. [RE# 18719]
2008-10-23 00:00:58 +00:00
Evan Hunt
b0bf1ad5b0
2456. [bug] In ACLs, ::/0 and 0.0.0.0/0 would both match any
...
address, regardless of family. They now correctly
distinguish IPv4 from IPv6. [RT #18559 ]
2008-09-26 21:12:02 +00:00
Mark Andrews
896f88361e
2442. [bug] A lock could be destroyed twice. [RT# 18626]
2008-09-14 04:54:49 +00:00
Automatic Updater
6011ef0f4d
update copyright notice
2008-09-12 23:47:25 +00:00
Evan Hunt
5ce9206eb9
2441. [bug] isc_radix_insert() could copy radix tree nodes
...
incompletely. [RT #18573 ]
2440. [bug] named-checkconf used an incorrect test to determine
if an ACL was set to none.
2008-09-12 06:02:31 +00:00
Mark Andrews
d923262186
2387. [bug] Silence compiler warnings in lib/isc/radix.c.
...
[RT #18147 ] [RT #18258 ]
2008-07-15 00:21:16 +00:00
Evan Hunt
080a964a3f
"blackhole" ACLs could cause named to segfault due to some
...
uninitialized memory. [rt18095]
2008-05-21 23:21:33 +00:00
Automatic Updater
60d19b2f15
update copyright notice
2008-01-27 23:47:20 +00:00
Mark Andrews
1fa2ce7eae
2324. [bug] Fix IPv6 matching against "any;" [RT #17533 ]
2008-01-27 02:13:34 +00:00
Automatic Updater
140a27777d
update copyright notice
2008-01-21 23:46:56 +00:00
Evan Hunt
262c39b236
IPv6 addresses could match IPv4 ACL entries and vice versa. [RT #17462 ]
2008-01-21 20:38:54 +00:00
Mark Andrews
604419a812
2282. [bug] Acl code fixups. [RT #17346 ]
2007-12-20 01:48:29 +00:00
Evan Hunt
0899d16ebd
Radix tree node_num value could be set incorrectly, causing positive ACL
...
matches to look like negative ones. [rt17311]
2007-11-27 19:14:45 +00:00
Evan Hunt
adcd4ef11a
Clean up build errors on Windows for 9.5.0a7.
...
Also, changed isc_destroy_radix() to isc_radix_destroy() to match
the naming convention for other radix routines.
2007-09-28 00:11:32 +00:00
Evan Hunt
8327cdb88f
Fixes for several errors found by Coverity. [rt17160]
2007-09-24 17:18:25 +00:00
Mark Andrews
69f3cb5abc
Part 3 of:
...
2233. [func] Add support for O(1) ACL processing, based on
radix tree code originally written by kevin
brintnall. [RT #16288 ]
2007-09-19 03:03:29 +00:00
Mark Andrews
12e0477d4e
Part 2 of:
...
2233. [func] Add support for O(1) ACL processing, based on
radix tree code originally written by kevin
brintnall. [RT #16288 ]
2007-09-14 01:46:06 +00:00
Automatic Updater
2c94a0e56d
update copyright notice
2007-09-12 23:46:47 +00:00
Evan Hunt
3181d0e359
Add support for O(1) ACL processing, based on radix tree code originally
...
written by kevin brintnall. [RT #16288 ]
2007-09-12 01:46:28 +00:00