Mark Andrews
848c1c8b8b
remove duplicate #includes
2019-12-23 07:47:36 +11:00
Mark Andrews
7278f2529a
revert d10fbdec for lib/dns/gen.c as it is a build platform executable
2019-12-23 07:37:13 +11:00
Mark Andrews
39780ae54f
Merge branch '1501-summary-threadsanitizer-lock-order-inversion-potential-deadlock-in-pthread_rwlock_wrlock' into 'master'
...
Resolve "SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in pthread_rwlock_wrlock - zone_postload"
See merge request isc-projects/bind9!2776
2019-12-20 10:57:43 +00:00
Mark Andrews
d26e125438
Refactor loop body as copy_non_dnssec_records.
2019-12-20 21:31:23 +11:00
Ondřej Surý
bff83b9480
Add failure handling when iterators don't end with ISC_R_NOMORE
2019-12-20 21:31:23 +11:00
Ondřej Surý
6012479419
Refactor receive_secure_db to make the variables and code flow around the iterator more local
2019-12-20 21:31:23 +11:00
Mark Andrews
9d8f9cc8f2
Call dns_dbiterator_destroy earlier to prevent potential deadlock.
2019-12-20 21:31:23 +11:00
Mark Andrews
dafb1eb8bb
Merge branch '1523-pkcs11-destroy-s-usage-message-is-misleading' into 'master'
...
Resolve "pkcs11-destroy's usage message is misleading"
Closes #1523
See merge request isc-projects/bind9!2785
2019-12-20 08:56:11 +00:00
Mark Andrews
41d827893e
update usage message
2019-12-20 08:28:37 +00:00
Mark Andrews
3352a38da4
Merge branch '1418-threadsanitizer-data-race-dig-c-2542-in-main' into 'master'
...
Resolve "ThreadSanitizer: data race dig.c:2542 in main"
Closes #1418
See merge request isc-projects/bind9!2647
2019-12-20 05:57:50 +00:00
Ondřej Surý
b218bf5227
Fix the concurrent access to batchname in dig.c
2019-12-20 03:43:04 +00:00
Mark Andrews
f8ec2140be
Merge branch 'feature/master/maxminddb-version' into 'master'
...
Include maxminddb and protobuf version in named -V
See merge request isc-projects/bind9!2686
2019-12-17 23:58:31 +00:00
Mark Andrews
2f2bc03b2d
add CHANGES
2019-12-18 10:57:25 +11:00
Petr Menšík
85f3476894
Include protobuf-c version
...
Include used version of protobuf-c in version info, both link time and
runtime version is available.
2019-12-17 23:46:52 +00:00
Petr Menšík
e6d7384c0d
Provide GeoIP2 library version in version
...
Libmaxmind does not provide any version macro for link time version.
Print at least runtime version library used, if linked.
2019-12-17 23:46:52 +00:00
Mark Andrews
0b7339ac6e
Merge branch '1482-autosign-system-test-failed' into 'master'
...
Resolve "autosign system test failed"
Closes #1461 and #1482
See merge request isc-projects/bind9!2773
2019-12-13 08:58:14 +00:00
Mark Andrews
17d25dbf47
Fix autosign system test issues.
...
* report when NSEC3PARAM is not yet present
* allow more time for NSEC3PARAM to become present
* adjust frequency failure message
2019-12-13 08:31:56 +00:00
Ondřej Surý
c2421a1ec3
Merge branch '1414-threadsanitizer-data-race-task-c-367-in-task_shutdown-v9_14+' into 'master'
...
Convert task->flags to C11 atomics
Closes #1414
See merge request isc-projects/bind9!2768
2019-12-13 07:41:53 +00:00
Ondřej Surý
5746172da3
Convert task flags to C11 atomics
2019-12-13 07:10:25 +01:00
Evan Hunt
de42a7aa9f
Merge branch 'prep-release-v9_15_7' into 'master'
...
Prep 9.15.7
See merge request isc-projects/bind9!2771
v9.15.7
2019-12-13 00:00:45 +00:00
Tinderbox User
67bac2bcd9
Merge branch 'prep-release'
2019-12-12 23:59:51 +00:00
Tinderbox User
e088272172
prep 9.15.7
2019-12-12 23:59:39 +00:00
Evan Hunt
a3dc02103a
Merge branch '1392-initial-tcp-highwater-wrong' into 'master'
...
Resolve "Initial TCP high-water value is wrong"
Closes #1392
See merge request isc-projects/bind9!2610
2019-12-12 19:52:36 +00:00
Evan Hunt
8c48c4f738
CHANGES
2019-12-12 11:24:26 -08:00
Diego Fronza
114520425c
Added tcp-highwater test on initial statistics verification
...
The initial tcp statistics test was not testing tcp-highwater counter,
but only initial number of current TCP clients, so this missing test was
added to ensure initial tcp-highwater value is correct.
2019-12-12 11:23:11 -08:00
Diego Fronza
ed9853e739
Fix tcp-highwater stats updating
...
After the network manager rewrite, tcp-higwater stats was only being
updated when a valid DNS query was received over tcp.
It turns out tcp-quota is updated right after a tcp connection is
accepted, before any data is read, so in the event that some client
connect but don't send a valid query, it wouldn't be taken into
account to update tcp-highwater stats, that is wrong.
This commit fix tcp-highwater to update its stats whenever a tcp connection
is established, independent of what happens after (timeout/invalid
request, etc).
2019-12-12 11:23:10 -08:00
Diego Fronza
ead7b3dc53
Fix tcp-highwater initial value
...
During BIND startup it scans for network interfaces available, in this
process it ensures that for every interface it will bind and listen to,
at least one socket will be always available accepting connections on
that interface, this way avoiding some DOS attacks that could exploit
tcp quota on some interface and make others unavailable.
In the previous network implementation this initial "reserved" tcp-quota
used by BIND was already been added to the tcp-highwater stats, but with
the new network code it was necesary to add this workaround to ensure
tcp-highwater stats reflect the tcp-quota used by BIND after startup.
2019-12-12 11:23:10 -08:00
Ondřej Surý
74082abba0
Merge branch '1497-threadsanitizer-data-race-lib-isc-unix-socket-c-1839-2-in-destroy' into 'master'
...
Add missing isc_refcount_destroy and lock the socket ISC_LISTS in destroy()
Closes #1497
See merge request isc-projects/bind9!2767
2019-12-12 14:14:45 +00:00
Ondřej Surý
d5b6db3b09
Additionally lock accessing the ISC_LISTs in free_socket()
2019-12-12 13:08:34 +01:00
Ondřej Surý
d35739d516
Add missing isc_refcount_destroy and lock the socket ISC_LISTS in destroy()
2019-12-12 12:59:39 +01:00
Mark Andrews
6f3fdf36b4
Merge branch '1486-threadsanitizer-lock-order-inversion-potential-deadlock-dns_resolver_createfetch-vs' into 'master'
...
Resolve "ThreadSanitizer: lock-order-inversion (potential deadlock) - dns_resolver_createfetch vs dns_resolver_shutdown"
Closes #1471 and #1486
See merge request isc-projects/bind9!2760
2019-12-12 09:04:32 +00:00
Mark Andrews
62abb6aa82
make resolver->zspill atomic to prevent potential deadlock
2019-12-12 08:26:59 +00:00
Mark Andrews
a6f2d6191e
Merge branch '1494-lock-order-inversion-potential-deadlock-nm_thread-vs-nm_destroy' into 'master'
...
Resolve "lock-order-inversion (potential deadlock) - nm_thread vs nm_destroy"
Closes #1494
See merge request isc-projects/bind9!2763
2019-12-12 08:26:24 +00:00
Mark Andrews
ad12c2f3b0
address lock order inversion
2019-12-12 17:43:03 +11:00
Ondřej Surý
80c476721c
Merge branch '1423-threadsanitizer-data-race-time-c-170-in-isc_time_nowplusinterval' into 'master'
...
Ensure all zone_settimer() calls are done on locked zone
Closes #1423
See merge request isc-projects/bind9!2738
2019-12-12 06:15:20 +00:00
Ondřej Surý
cf48e8eb32
Ensure all zone_settimer() calls are done on locked zone
2019-12-11 22:58:59 +00:00
Evan Hunt
8536d740f1
Merge branch 'michal/prepare-release-notes-for-bind-9.15.7' into 'master'
...
Prepare release notes for BIND 9.15.7
See merge request isc-projects/bind9!2753
2019-12-11 22:15:04 +00:00
Michał Kępień
c428479d6d
Prepare release notes for BIND 9.15.7
...
- Add a GitLab merge request number to the "trust-anchors" release
note and slightly rephrase its second half.
- Replace tabs with spaces in doc/arm/notes-9.15.7.xml to retain
consistency with other XML files containing release notes.
- Move the "Security Fixes" section for BIND 9.15.6 higher up, for
consistency with release notes for other versions.
2019-12-11 22:14:22 +00:00
Ondřej Surý
448ada561d
Merge branch '1119-enable-thread-sanitizer-in-the-gitlab-ci' into 'master'
...
Enable ThreadSanitizer enabled build and unit tests
See merge request isc-projects/bind9!2367
2019-12-11 17:03:58 +00:00
Ondřej Surý
b6960da6c8
Enable ThreadSanitizer enabled build, system and unit tests
2019-12-11 17:24:05 +01:00
Michal Nowak
7ee4ff6182
Merge branch 'mnowak/fedora31' into 'master'
...
Update GitLab CI to Fedora 31
See merge request isc-projects/bind9!2662
2019-12-11 15:25:17 +00:00
Michal Nowak
7aa77038bd
Update GitLab CI to Fedora 31
...
Since Fedora 31 is the current Fedora release, replace Fedora 30 GitLab
CI jobs with their up-to-date counterparts.
2019-12-11 15:25:17 +00:00
Michał Kępień
94bddd2ce3
Merge branch 'michal/update-release-checklist' into 'master'
...
Update release checklist
See merge request isc-projects/bind9!2751
2019-12-11 14:47:55 +00:00
Michał Kępień
e792d01e00
Update release checklist
...
Apply tweaks necessary to make the release checklist consistent with the
security incident handling checklist.
2019-12-11 15:45:22 +01:00
Michał Kępień
53858d4afd
Merge branch 'michal/fix-release-notes-for-bind-9.15.6' into 'master'
...
Fix release notes for BIND 9.15.6
See merge request isc-projects/bind9!2607
2019-12-11 12:12:13 +00:00
Michał Kępień
88497a59cc
Fix release notes for BIND 9.15.6
...
- Add a missing release note for TCP high-water. That feature was not
yet merged when the initial version of !2524 was prepared and its
release note was missed when that merge request was later rebased.
- Rephrase the release note for CVE-2019-6477 so that it uses the same
text as its corresponding notes in all other releases.
- Unify whitespace in doc/arm/notes-9.15.6.xml.
2019-12-11 13:11:22 +01:00
Michał Kępień
b0f7351820
Merge branch 'michal/create-release-tarballs-in-gitlab-ci' into 'master'
...
Create release tarballs in GitLab CI
See merge request isc-projects/bind9!2745
2019-12-11 11:04:45 +00:00
Michał Kępień
922a2ae44a
Drop Jenkins mentions from release issue template
...
Update the release issue template to account for the fact that Jenkins
is no longer needed for creating BIND release tarballs.
2019-12-11 12:04:29 +01:00
Michał Kępień
5a4a6b5e91
Add a job creating a release tarball to GitLab CI
...
Add a GitLab CI job (which is run only if all other jobs in a pipeline
succeed) that builds a BIND release tarball, i.e. fetches the source
tarball from the tarball building job, creates Windows zips, puts
certain parts of BIND documentation into the appropriate places, and
packs it all up into a single tarball whose contents can be subsequently
signed and published.
2019-12-11 12:04:29 +01:00
Michał Kępień
2b1c8c54d1
Add a Windows debug system test job to GitLab CI
...
Add a system test job for binaries created by Visual Studio in the
"Debug" build configuration to GitLab CI so that they can be tested
along their "Release" counterparts when necessary.
2019-12-11 12:04:29 +01:00