Ondřej Surý
91e1981988
Add missing locks to isc_logconfig_get and disable thread sanitizer for isc_log_wouldlog
2020-01-08 11:53:04 +01:00
Ondřej Surý
255134166c
Add conditional ISC_NO_SANITIZE macro to disable TSAN for function
2020-01-08 11:53:04 +01:00
Ondřej Surý
3bce0c2c20
Merge branch '1525-inline-system-test-failed-need-to-wait-for-zone-to-be-loaded' into 'master'
...
Resolve "inline system test failed, need to wait for zone to be loaded."
Closes #1525
See merge request isc-projects/bind9!2796
2020-01-08 07:23:42 +00:00
Mark Andrews
2dc4d72fa9
address some timing issues in inline system test
2020-01-08 08:23:03 +01:00
Ondřej Surý
cd17b773b1
Merge branch '1513-inline-system-test-failed' into 'master'
...
Resolve "inline system test failed"
Closes #1513
See merge request isc-projects/bind9!2777
2020-01-08 07:17:47 +00:00
Mark Andrews
13fa80ede8
Address timing issues in 'inline' system test.
...
"rndc signing -serial <value>" could take longer than a second to
complete. Loop waiting for update to succeed.
For tests where "rndc signing -serial <value>" is supposed to not
succeed, repeatedly test that we don't get the new serial, then
test that we have the old value. This should prevent false negatives.
2020-01-07 16:14:12 +01:00
Ondřej Surý
e3d8732548
Merge branch '1467-xfer-test-suppress-zone-transfer-when-we-are-going-to-retry' into 'master'
...
Resolve "xfer test: suppress zone transfer when we are going to retry."
Closes #1467
See merge request isc-projects/bind9!2735
2020-01-07 13:56:35 +00:00
Mark Andrews
05aa45c602
improve forensic logs
...
improve forensic logs by directing output to per sub-test named
files and reporting the sub-subtest number.
2020-01-07 14:23:48 +01:00
Mark Andrews
9bd6720f58
suppress unnecessary zone transfer
...
suppressed unnecessary zone transfer in "test mapped zone with
out of zone data" sub-test.
2020-01-07 14:23:17 +01:00
Mark Andrews
46982b414b
Improve forensic logging in "testing basic zone transfer functionality"
...
Split the "testing basic zone transfer functionality" into primary and
secondary parts to improve forensic logging.
2020-01-07 14:23:08 +01:00
Matthijs Mekking
2c38dd5474
Merge branch 'copyrights-2020' into 'master'
...
Update copyrights 2020
See merge request isc-projects/bind9!2809
2020-01-06 17:53:09 +00:00
Matthijs Mekking
935a2ae33f
Update copyrights 2020
...
Happy New Year!
2020-01-06 15:05:03 +01:00
Michal Nowak
db9ad43294
Merge branch 'mnowak/get-the-backtraces-out-of-unit-test-coredumps' into 'master'
...
Gather debug info on broken unit tests
See merge request isc-projects/bind9!2699
2020-01-06 11:25:09 +00:00
Michal Nowak
6a94e6ba73
Gather debug info on broken unit tests
2020-01-06 11:25:09 +00:00
Michał Kępień
fc0fe4c5a7
Merge branch 'michal/misc-doc-fixes' into 'master'
...
Miscellaneous documentation fixes
See merge request isc-projects/bind9!2800
2020-01-03 08:24:18 +00:00
Michał Kępień
56f388cae1
Fix minor CHANGES issues
2020-01-03 09:08:09 +01:00
Michał Kępień
b2f3eaf188
Fix whitespace and punctuation in release notes
2020-01-03 09:08:09 +01:00
Michał Kępień
2d00143ab1
Prevent splitting GitLab identifiers across lines
...
GitLab issue and merge request numbers placed in release notes (in the
form of "#1234 " for issues and "!5678 " for merge requests) should not be
split across two lines. Extend the shell pipeline generating
doc/arm/notes.txt with a sed invocation which prevents such splitting.
2020-01-03 09:08:09 +01:00
Evan Hunt
996c1d3727
Merge branch 'each-copyrights' into 'master'
...
update copyright year to 2020
See merge request isc-projects/bind9!2801
2020-01-03 05:53:01 +00:00
Evan Hunt
2df13f79ef
update copyright year to 2020
2020-01-02 21:45:30 -08:00
Mark Andrews
993633ad96
Merge branch '1530-lib-dns-gen-c-29-26-fatal-error-isc-platform-h-no-such-file-or-directory' into 'master'
...
Resolve "lib/dns/gen.c:29:26: fatal error: isc/platform.h: No such file or directory"
Closes #1530
See merge request isc-projects/bind9!2792
2019-12-22 21:18:09 +00:00
Mark Andrews
848c1c8b8b
remove duplicate #includes
2019-12-23 07:47:36 +11:00
Mark Andrews
7278f2529a
revert d10fbdec for lib/dns/gen.c as it is a build platform executable
2019-12-23 07:37:13 +11:00
Mark Andrews
39780ae54f
Merge branch '1501-summary-threadsanitizer-lock-order-inversion-potential-deadlock-in-pthread_rwlock_wrlock' into 'master'
...
Resolve "SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in pthread_rwlock_wrlock - zone_postload"
See merge request isc-projects/bind9!2776
2019-12-20 10:57:43 +00:00
Mark Andrews
d26e125438
Refactor loop body as copy_non_dnssec_records.
2019-12-20 21:31:23 +11:00
Ondřej Surý
bff83b9480
Add failure handling when iterators don't end with ISC_R_NOMORE
2019-12-20 21:31:23 +11:00
Ondřej Surý
6012479419
Refactor receive_secure_db to make the variables and code flow around the iterator more local
2019-12-20 21:31:23 +11:00
Mark Andrews
9d8f9cc8f2
Call dns_dbiterator_destroy earlier to prevent potential deadlock.
2019-12-20 21:31:23 +11:00
Mark Andrews
dafb1eb8bb
Merge branch '1523-pkcs11-destroy-s-usage-message-is-misleading' into 'master'
...
Resolve "pkcs11-destroy's usage message is misleading"
Closes #1523
See merge request isc-projects/bind9!2785
2019-12-20 08:56:11 +00:00
Mark Andrews
41d827893e
update usage message
2019-12-20 08:28:37 +00:00
Mark Andrews
3352a38da4
Merge branch '1418-threadsanitizer-data-race-dig-c-2542-in-main' into 'master'
...
Resolve "ThreadSanitizer: data race dig.c:2542 in main"
Closes #1418
See merge request isc-projects/bind9!2647
2019-12-20 05:57:50 +00:00
Ondřej Surý
b218bf5227
Fix the concurrent access to batchname in dig.c
2019-12-20 03:43:04 +00:00
Mark Andrews
f8ec2140be
Merge branch 'feature/master/maxminddb-version' into 'master'
...
Include maxminddb and protobuf version in named -V
See merge request isc-projects/bind9!2686
2019-12-17 23:58:31 +00:00
Mark Andrews
2f2bc03b2d
add CHANGES
2019-12-18 10:57:25 +11:00
Petr Menšík
85f3476894
Include protobuf-c version
...
Include used version of protobuf-c in version info, both link time and
runtime version is available.
2019-12-17 23:46:52 +00:00
Petr Menšík
e6d7384c0d
Provide GeoIP2 library version in version
...
Libmaxmind does not provide any version macro for link time version.
Print at least runtime version library used, if linked.
2019-12-17 23:46:52 +00:00
Mark Andrews
0b7339ac6e
Merge branch '1482-autosign-system-test-failed' into 'master'
...
Resolve "autosign system test failed"
Closes #1461 and #1482
See merge request isc-projects/bind9!2773
2019-12-13 08:58:14 +00:00
Mark Andrews
17d25dbf47
Fix autosign system test issues.
...
* report when NSEC3PARAM is not yet present
* allow more time for NSEC3PARAM to become present
* adjust frequency failure message
2019-12-13 08:31:56 +00:00
Ondřej Surý
c2421a1ec3
Merge branch '1414-threadsanitizer-data-race-task-c-367-in-task_shutdown-v9_14+' into 'master'
...
Convert task->flags to C11 atomics
Closes #1414
See merge request isc-projects/bind9!2768
2019-12-13 07:41:53 +00:00
Ondřej Surý
5746172da3
Convert task flags to C11 atomics
2019-12-13 07:10:25 +01:00
Evan Hunt
de42a7aa9f
Merge branch 'prep-release-v9_15_7' into 'master'
...
Prep 9.15.7
See merge request isc-projects/bind9!2771
2019-12-13 00:00:45 +00:00
Tinderbox User
67bac2bcd9
Merge branch 'prep-release'
2019-12-12 23:59:51 +00:00
Tinderbox User
e088272172
prep 9.15.7
2019-12-12 23:59:39 +00:00
Evan Hunt
a3dc02103a
Merge branch '1392-initial-tcp-highwater-wrong' into 'master'
...
Resolve "Initial TCP high-water value is wrong"
Closes #1392
See merge request isc-projects/bind9!2610
2019-12-12 19:52:36 +00:00
Evan Hunt
8c48c4f738
CHANGES
2019-12-12 11:24:26 -08:00
Diego Fronza
114520425c
Added tcp-highwater test on initial statistics verification
...
The initial tcp statistics test was not testing tcp-highwater counter,
but only initial number of current TCP clients, so this missing test was
added to ensure initial tcp-highwater value is correct.
2019-12-12 11:23:11 -08:00
Diego Fronza
ed9853e739
Fix tcp-highwater stats updating
...
After the network manager rewrite, tcp-higwater stats was only being
updated when a valid DNS query was received over tcp.
It turns out tcp-quota is updated right after a tcp connection is
accepted, before any data is read, so in the event that some client
connect but don't send a valid query, it wouldn't be taken into
account to update tcp-highwater stats, that is wrong.
This commit fix tcp-highwater to update its stats whenever a tcp connection
is established, independent of what happens after (timeout/invalid
request, etc).
2019-12-12 11:23:10 -08:00
Diego Fronza
ead7b3dc53
Fix tcp-highwater initial value
...
During BIND startup it scans for network interfaces available, in this
process it ensures that for every interface it will bind and listen to,
at least one socket will be always available accepting connections on
that interface, this way avoiding some DOS attacks that could exploit
tcp quota on some interface and make others unavailable.
In the previous network implementation this initial "reserved" tcp-quota
used by BIND was already been added to the tcp-highwater stats, but with
the new network code it was necesary to add this workaround to ensure
tcp-highwater stats reflect the tcp-quota used by BIND after startup.
2019-12-12 11:23:10 -08:00
Ondřej Surý
74082abba0
Merge branch '1497-threadsanitizer-data-race-lib-isc-unix-socket-c-1839-2-in-destroy' into 'master'
...
Add missing isc_refcount_destroy and lock the socket ISC_LISTS in destroy()
Closes #1497
See merge request isc-projects/bind9!2767
2019-12-12 14:14:45 +00:00
Ondřej Surý
d5b6db3b09
Additionally lock accessing the ISC_LISTs in free_socket()
2019-12-12 13:08:34 +01:00
