Michał Kępień
953c810f41
Flag trailing dots in commit subject lines
...
Make the Danger GitLab CI job fail when the subject line for any commit
belonging to a merge request contains a trailing dot.
2021-01-18 14:57:47 +01:00
Michał Kępień
ff58ec8cef
Flag missing pairwise testing markers
...
Make the Danger GitLab CI job fail when a merge request adds a new
./configure switch without also adding a "# [pairwise: ...]" marker that
the relevant GitLab CI job uses for preparing the pairwise testing
model. This helps to ensure that any newly added ./configure switches
are tested by the pairwise testing GitLab CI job.
2021-01-18 14:57:47 +01:00
Michał Kępień
d81ad454cc
Suggest adding release notes for customer issues
...
Make Danger suggest adding a release note to a merge request if the
latter is marked with the "Customer" label but not with the "Release
Notes" label.
2021-01-18 14:57:47 +01:00
Michał Kępień
2f77c7680a
Handle [placeholder] CHANGES entries
...
Make the Danger GitLab CI job fail when a merge request targeting a
branch different than "main" adds any [placeholder] entries to the
CHANGES file. Prevent Danger from flagging missing GitLab identifiers
for [placeholder] CHANGES entries.
2021-01-18 14:57:47 +01:00
Michał Kępień
97364f5518
Flag missing CVE identifiers
...
Make Danger ensure that if a merge request fixes a security issue then
that merge request includes a CHANGES entry and a release note, both of
which contain a CVE identifier.
2021-01-18 14:57:47 +01:00
Matthijs Mekking
f5c3863530
Merge branch '2364-cid314969-coverity-deadcode-zoneconf' into 'main'
...
Fix control flow issue CID 314969 in zoneconf.c
Closes #2364
See merge request isc-projects/bind9!4573
2021-01-18 12:35:30 +00:00
Matthijs Mekking
8df629d0b2
Fix control flow issue CID 314969 in zoneconf.c
...
Coverity Scan identified the following issue in bin/named/zoneconf.c:
*** CID 314969: Control flow issues (DEADCODE)
/bin/named/zoneconf.c: 2212 in named_zone_inlinesigning()
if (!inline_signing && !zone_is_dynamic &&
cfg_map_get(zoptions, "dnssec-policy", &signing) == ISC_R_SUCCESS &&
signing != NULL)
{
if (strcmp(cfg_obj_asstring(signing), "none") != 0) {
inline_signing = true;
>>> CID 314969: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression ""no"" inside this statement: "dns_zone_log(zone, 1, "inli...".
dns_zone_log(
zone, ISC_LOG_DEBUG(1), "inline-signing: %s",
inline_signing
? "implicitly through dnssec-policy"
: "no");
} else {
...
}
}
This is because we first set 'inline_signing = true' and then check
its value in 'dns_zone_log'.
2021-01-18 11:48:09 +01:00
Ondřej Surý
2dd54fa62f
Merge branch '2354-placeholder' into 'main'
...
Add placeholder for GL #2354
Closes #2354
See merge request isc-projects/bind9!4564
2021-01-12 20:19:30 +00:00
Ondřej Surý
4387e4a632
Add placeholder for GL #2354
2021-01-12 21:14:53 +01:00
Matthijs Mekking
739a5ea135
Merge branch '2383-kasp-sig-validity-dnskey-bug' into 'main'
...
Fix signatures-validity config option
Closes #2383
See merge request isc-projects/bind9!4543
2021-01-12 11:22:22 +00:00
Matthijs Mekking
ad63e9e4f8
Fix signatures-validity config option
...
KASP was using 'signatures-validity-dnskey' instead of
'signatures-validity'.
2021-01-12 10:54:48 +00:00
Michal Nowak
031cc284fc
Merge branch 'mnowak/fix-copyright-date-in-man-pages' into 'main'
...
Update copyright date in man pages
See merge request isc-projects/bind9!4548
2021-01-11 11:35:57 +00:00
Michal Nowak
358c133ee2
Update copyright date in man pages
2021-01-11 12:27:17 +01:00
Michał Kępień
34cb46aed0
Make sure ddns-confgen man page stays up to date
2021-01-11 12:27:17 +01:00
Matthijs Mekking
98ad051c16
Merge branch 'matthijs-fix-notes' into 'main'
...
Fix current release notes
See merge request isc-projects/bind9!4549
2021-01-11 11:22:19 +00:00
Matthijs Mekking
aa69753470
Fix current release notes
...
Remove entry that was release in 9.17.8 already.
2021-01-11 12:21:03 +01:00
Matthijs Mekking
a559faeaec
Merge branch '2248-serve-stale-config-defaults' into 'main'
...
Update serve-stale config defaults
Closes #2248
See merge request isc-projects/bind9!4477
2021-01-11 10:55:53 +00:00
Matthijs Mekking
3be65246f8
Update serve-stale system test with new defaults
2021-01-11 11:13:45 +01:00
Matthijs Mekking
e15a433b23
Update serve-stale config defaults
...
Change the serve-stale configuration defaults so that they match the
recommendations from RFC 8767.
2021-01-11 11:13:45 +01:00
Michał Kępień
06e4004bf0
Merge branch '606-add-the-isc-dnssec-guide-as-a-bind-9-arm-appendix' into 'main'
...
Add the ISC DNSSEC Guide as a BIND 9 ARM appendix
Closes #606
See merge request isc-projects/bind9!4471
2021-01-08 12:53:13 +00:00
Michał Kępień
f96e6a1e1d
Add the ISC DNSSEC Guide as a BIND 9 ARM appendix
...
Add the ISC DNSSEC Guide to the BIND 9 ARM in order to include the
former in every BIND release.
2021-01-08 13:12:20 +01:00
Michał Kępień
b65629f7a5
Merge branch '2366-add-CHANGES-entry' into 'main'
...
Add CHANGES entry for GL #2366
Closes #2366
See merge request isc-projects/bind9!4544
2021-01-08 11:51:03 +00:00
Michał Kępień
995b72d2b7
Add CHANGES entry for GL #2366
2021-01-08 12:48:37 +01:00
Michal Nowak
e797d7caff
Merge branch 'marka-explicitly-add-gen.c' into 'main'
...
Explicitly add gen.c and gen-unix.h to dist
See merge request isc-projects/bind9!4538
2021-01-07 15:24:21 +00:00
Mark Andrews
e583fdfed9
Explicitly add gen.c and gen-unix.h to dist
2021-01-07 16:06:12 +01:00
Mark Andrews
35ccdf0583
Merge branch '1978-cross-compilation-doesn-t-work-in-9-17' into 'main'
...
Resolve "Cross-compilation doesn’t work in 9.17"
Closes #1978
See merge request isc-projects/bind9!4505
2021-01-07 02:49:41 +00:00
Mark Andrews
33c907b1c6
don't enable maintainer mode when cross compiling
2021-01-07 13:23:18 +11:00
Mark Andrews
96f91d7a53
lib/dns/gen should be built with CC_FOR_BUILD
2021-01-07 13:23:18 +11:00
Evan Hunt
2faa0f6676
Merge branch 'jinmei-bind9-fix-async-hook-assertion-failure' into 'main'
...
fix async hook assertion failure
Closes #2379
See merge request isc-projects/bind9!4537
2021-01-06 22:02:42 +00:00
Evan Hunt
1079701bd7
CHANGES
2021-01-06 13:26:02 -08:00
JINMEI Tatuya
2ed12d90c9
more s/recurse/async/ for consistency
...
(no behavior change)
2021-01-06 13:14:13 -08:00
JINMEI Tatuya
d520f01c7b
detach fetchhandle before resume query processing
...
otherwise, another hook async event or DNS recursion would
trigger an assertion failure.
2021-01-06 13:14:13 -08:00
Mark Andrews
5a05cbebc4
Merge branch '2366-bind-9-16-10-build-fails-with-libmaxminddb-1-4-3-2' into 'main'
...
Resolve "BIND 9.16.10 build fails with libmaxminddb-1.4.3"
Closes #2366
See merge request isc-projects/bind9!4532
2021-01-06 08:03:38 +00:00
Mark Andrews
fcca836a20
Fix 'configure --with-maxminddb=<path>'
2021-01-06 18:05:58 +11:00
Mark Andrews
c668cf6692
Merge branch '2355-incorrect-increment-of-inactive-in-rbtdb-c-maybe_free_rbtdb' into 'main'
...
Resolve "Incorrect increment of inactive in rbtdb.c:maybe_free_rbtdb()"
Closes #2317 and #2355
See merge request isc-projects/bind9!4504
2021-01-06 05:30:11 +00:00
Mark Andrews
584e589d84
Add release note
2021-01-06 15:28:23 +11:00
Mark Andrews
65702896bd
Add CHANGES
2021-01-06 15:27:50 +11:00
Mark Andrews
859d2fdad6
Inactive incorrectly incremented
...
It is possible to have two threads destroying an rbtdb at the same
time when detachnode() executes and removes the last reference to
a node between exiting being set to true for the node and testing
if the references are zero in maybe_free_rbtdb(). Move NODE_UNLOCK()
to after checking if references is zero to prevent detachnode()
changing the reference count too early.
2021-01-06 15:27:07 +11:00
Matthijs Mekking
d86ad80654
Merge branch '2359-too-many-newlines-dnssec-signzone-verify' into 'main'
...
Fix dnssec-signzone and -verify logging (again)
Closes #2359
See merge request isc-projects/bind9!4523
2021-01-05 12:40:40 +00:00
Matthijs Mekking
18c62a077e
Fix dnssec-signzone and -verify logging (again)
...
While fixing #2359 , 'report()' was changed so that it would print the
newline.
Newlines were missing from the output of 'dnssec-signzone'
and 'dnssec-verify' because change
664b8f04f5
moved the printing from
newlines to the library.
This had to be reverted because this also would print redundant
newlines in logfiles.
While doing the revert, some newlines in 'lib/dns/zoneverify.c'
were left in place, now making 'dnssec-signzone' and 'dnssec-verify'
print too many newlines.
This commit removes those newlines, so that the output looks nice
again.
2021-01-05 12:06:23 +01:00
Mark Andrews
ba4073ef0d
Merge branch 'marka-placeholder' into 'main'
...
placeholder
See merge request isc-projects/bind9!4521
2021-01-05 00:29:26 +00:00
Mark Andrews
27fa7dd73b
placeholder
2021-01-05 11:25:38 +11:00
Mark Andrews
8c6db04f60
Merge branch '2359-missing-newlines-in-log-messages-dnssec-signzone-dnssec-verify-c' into 'main'
...
Resolve "missing newlines in log messages dnssec-signzone/dnssec-verify"
Closes #2359
See merge request isc-projects/bind9!4511
2021-01-04 06:21:13 +00:00
Mark Andrews
244525a303
Add CHANGES
2021-01-04 03:59:10 +00:00
Mark Andrews
c36bd83822
Fix dnssec-signzone and dnssec-verify logging
...
The newlines need to be appended to the messages generated by report
in a atomic manner.
2021-01-04 03:59:10 +00:00
Mark Andrews
fa0171fdeb
Merge branch 'marka-copyrights' into 'main'
...
update for 2021
See merge request isc-projects/bind9!4518
2021-01-04 03:58:45 +00:00
Mark Andrews
faf9d8beba
update for 2021
2021-01-04 11:52:00 +11:00
Matthijs Mekking
6c0e172308
Merge branch 'matthijs-fixup-notes' into 'main'
...
Matthijs fixup notes
See merge request isc-projects/bind9!4512
2020-12-23 11:04:45 +00:00
Matthijs Mekking
2e7ccecefe
Fixup notes
...
I screwed up the notes in !4474
2020-12-23 12:03:26 +01:00
Matthijs Mekking
1c26ab64a4
Merge branch '1750-dnssec-policy-none' into 'main'
...
Resolve 'dnssec-policy' graceful transition to insecure
Closes #2341 and #1750
See merge request isc-projects/bind9!4474
2020-12-23 10:55:20 +00:00