Tinderbox User
e59212e54b
Merge branch 'fix-doc' into security-master
2019-10-09 20:46:01 +00:00
Tinderbox User
59a245077d
regenerate doc
2019-10-09 20:45:13 +00:00
Ondřej Surý
85c0bede78
Synchronize the lifetime of artifact to 1 week
2019-10-09 21:46:48 +02:00
Ondřej Surý
5309987df7
Merge branch '1119-tsan-lib/dns/view.c-attributes' into 'master'
...
Convert struct dns_view->attributes to atomic_uint to prevent some locking
See merge request isc-projects/bind9!2368
2019-10-09 02:51:24 -04:00
Ondřej Surý
8b8826f403
Merge branch 'security-master-issue-numbers' into 'security-master'
...
Fix the GitLab issue numbers in CHANGES and notes.xml
See merge request isc-private/bind9!121
2019-10-09 02:38:48 -04:00
Ondřej Surý
db63c2a700
Convert struct dns_view->attributes to atomic_uint to prevent some locking
2019-10-09 08:09:44 +02:00
Ondřej Surý
4bd5d76beb
Fix the GitLab issue numbers in CHANGES and notes.xml
2019-10-09 08:03:07 +02:00
Tinderbox User
38270b7900
regen master
2019-10-06 03:16:14 +00:00
Ondřej Surý
f2eeff0342
Merge branch 'ondrej/cleanup-copyrights' into 'master'
...
Cleanup the COPYRIGHTS file
See merge request isc-projects/bind9!2377
2019-10-04 02:40:56 -04:00
Ondřej Surý
fc997e571d
Remove The OpenSSL Project from COPYRIGHT, the OpenSSL patches were removed
2019-10-04 08:39:20 +02:00
Ondřej Surý
f761a80842
Cleanup the last bits copyrighted to RSA Security and remove them from COPYRIGHT file
2019-10-04 08:39:20 +02:00
Ondřej Surý
52c10b78f1
Remove Doug Rabson and Jake Burkholder from COPYRIGHT, the code was removed
2019-10-04 08:36:45 +02:00
Ondřej Surý
e179d083d4
Remove Aaron D. Gifford from COPYRIGHT, the code was removed
2019-10-04 08:36:45 +02:00
Ondřej Surý
acf1cfe15d
Remove Rice University from COPYRIGHT, the code was removed
2019-10-04 08:36:45 +02:00
Ondřej Surý
37b677ca59
Remove Japan Network Information Center from COPYRIGHT, the code was removed
2019-10-04 08:36:45 +02:00
Ondřej Surý
86f4191405
Merge branch 'ondrej/remove-rsa-pkcs11-header-remnants' into 'master'
...
Remove unused RSA Security copyrighted cryptoki.h header
See merge request isc-projects/bind9!2445
2019-10-04 02:35:58 -04:00
Ondřej Surý
635e5293b2
Remove unused RSA Security copyrighted cryptoki.h header
2019-10-04 08:35:45 +02:00
Evan Hunt
841d1b6ab5
Merge branch '1226-yaml-empty-edns-options' into 'master'
...
Resolve "dig: EDNS options in requests cause bad YAML output"
Closes #1226
See merge request isc-projects/bind9!2345
2019-10-04 02:16:14 -04:00
Evan Hunt
bba7855e68
CHANGES
2019-10-03 22:52:17 -07:00
Evan Hunt
877b463bcc
fix digdelv KEY-TAG test
...
also incidentally added several missing ret=0 statements,
and removed some duplicates.
2019-10-03 22:52:16 -07:00
Evan Hunt
8e9a58eaa7
TCP KEEPALIVE was missing from yaml output
2019-10-03 22:52:16 -07:00
Evan Hunt
69322c7357
always print a colon after EDNS option names in text output
...
make the same change as in the previous commit to non-YAML text output,
for better readability and consistency between formats.
2019-10-03 22:52:16 -07:00
Evan Hunt
ed1b328186
always print a colon after EDNS option names in YAML output
...
previously, if the option was empty, then it was printed without a
colon, which could not be parsed as YAML. adding a colon in all cases
addresses this problem.
2019-10-03 22:52:16 -07:00
Mark Andrews
b22bb64c31
Merge branch 'marka-silence-clang' into 'master'
...
silence clang warning by using local variable.
See merge request isc-projects/bind9!2419
2019-10-03 21:31:11 -04:00
Mark Andrews
1b27ab8642
silence clang warning by using local variable.
...
'isc_commandline_index' is a global variable so it can theoretically
change result between if expressions. Save 'argv[isc_commandline_index]'
to local variable 'arg1' and use 'arg1 == NULL' in if expressions
instead of 'argc < isc_commandline_index + 1'. This allows clang
to correctly determine what code is reachable.
2019-10-03 15:02:59 -07:00
Ondřej Surý
52f0009be6
Merge branch 'ondrej/cppcheck-suppressions-list' into 'master'
...
Use util/suppressions.txt for Cppcheck suppressions list
See merge request isc-projects/bind9!2437
2019-10-03 10:10:14 -04:00
Ondřej Surý
4926099490
Use util/suppressions.txt for Cppcheck suppressions list
2019-10-03 15:28:38 +02:00
Ondřej Surý
fb14852ede
Merge branch 'ondrej/enable-cppcheck' into 'master'
...
Add Cppcheck job to the CI
See merge request isc-projects/bind9!2403
2019-10-03 03:32:28 -04:00
Ondřej Surý
a0d3614a60
Remove randomly scattered additional style check suppressions that caused unmatchedSuppression
2019-10-03 09:04:27 +02:00
Ondřej Surý
d1f035bbba
lib/ns/query.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
033f3eb580
lib/ns/interfacemgr.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
b4a42a286f
lib/ns/client.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
f855f09a55
lib/isccfg/parser.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
09232213d7
lib/isccfg/aclconf.c: Suppress nullPointerRedundantCheck false positive
2019-10-03 09:04:27 +02:00
Ondřej Surý
026cf2ff4f
lib/isc/unix/socket.c: Suppress preprocessorErrorDirective error from Cppcheck
2019-10-03 09:04:27 +02:00
Ondřej Surý
c662969da1
lib/isc/task.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
e8948fd9b4
lib/isc/pkc11.c: Fix possible NULL pointer dereference in push_attribute()
2019-10-03 09:04:27 +02:00
Ondřej Surý
e9f30fc211
lib/isc/buffer.c: Fix invalid order of DbC checks that could cause dereference before NULL check
2019-10-03 09:04:27 +02:00
Ondřej Surý
8f2ad12d0a
lib/dns/tsig.c: Suppress Cppcheck false positive error uninitStructMember
2019-10-03 09:04:27 +02:00
Ondřej Surý
14c174d921
lib/dns/tests/rbt_serialize_test.c: Fix dereference before DbC check
2019-10-03 09:04:27 +02:00
Ondřej Surý
269d507ccc
Instead of declaring unused va_list, just don't declare it at all
2019-10-03 09:04:27 +02:00
Ondřej Surý
5fc7e98d29
lib/dns/rdatalist.c: Fix dereference before DbC check
2019-10-03 09:04:26 +02:00
Ondřej Surý
66af8713d8
lib/dns/rdata/*/*.c: Silence false positive nullPointerRedundantCheck warning from Cppcheck
...
Cppcheck gets confused by:
void bar(void *arg) {
foo *data = arg;
REQUIRE(source != NULL);
REQUIRE(data->member != NULL);
}
and for consistency the DbC check needs to be changed to
void bar(void *arg) {
foo *data = arg;
REQUIRE(data != NULL);
REQUIRE(data->member != NULL);
}
2019-10-03 09:04:26 +02:00
Ondřej Surý
e68333aa67
lib/dns/rdata.c: Silence false positive nullPointerRedundantCheck warning from Cppcheck
2019-10-03 09:04:26 +02:00
Ondřej Surý
d508ce4036
lib/dns/rbtdb.c: Add DbC check to safely dereference rbtdb in rbt_datafixer()
2019-10-03 09:04:26 +02:00
Ondřej Surý
8be5c3fcfc
lib/dns/rbt.c: Suppress nullPointerRedundantCheck warnings from Cppcheck
2019-10-03 09:04:26 +02:00
Ondřej Surý
0f5860aad3
lib/dns/name.c: Fix dereference before DbC check reported by Cppcheck
2019-10-03 09:04:26 +02:00
Ondřej Surý
cea871464f
lib/dns/gssapi_link.c: Fix %d -> %u formatting when printing unsigned integers
2019-10-03 09:04:26 +02:00
Ondřej Surý
d8879af877
Fix passing NULL after the last typed argument to a variadic function leads to undefined behaviour.
...
From Cppcheck:
Passing NULL after the last typed argument to a variadic function leads to
undefined behaviour. The C99 standard, in section 7.15.1.1, states that if the
type used by va_arg() is not compatible with the type of the actual next
argument (as promoted according to the default argument promotions), the
behavior is undefined. The value of the NULL macro is an implementation-defined
null pointer constant (7.17), which can be any integer constant expression with
the value 0, or such an expression casted to (void*) (6.3.2.3). This includes
values like 0, 0L, or even 0LL.In practice on common architectures, this will
cause real crashes if sizeof(int) != sizeof(void*), and NULL is defined to 0 or
any other null pointer constant that promotes to int. To reproduce you might be
able to use this little code example on 64bit platforms. If the output includes
"ERROR", the sentinel had only 4 out of 8 bytes initialized to zero and was not
detected as the final argument to stop argument processing via
va_arg(). Changing the 0 to (void*)0 or 0L will make the "ERROR" output go away.
void f(char *s, ...) {
va_list ap;
va_start(ap,s);
for (;;) {
char *p = va_arg(ap,char*);
printf("%018p, %s\n", p, (long)p & 255 ? p : "");
if(!p) break;
}
va_end(ap);
}
void g() {
char *s2 = "x";
char *s3 = "ERROR";
// changing 0 to 0L for the 7th argument (which is intended to act as
// sentinel) makes the error go away on x86_64
f("first", s2, s2, s2, s2, s2, 0, s3, (char*)0);
}
void h() {
int i;
volatile unsigned char a[1000];
for (i = 0; i<sizeof(a); i++)
a[i] = -1;
}
int main() {
h();
g();
return 0;
}
2019-10-03 09:04:26 +02:00
Ondřej Surý
91cc6b9eb9
lib/dns/ecdb.c: Fix couple of DbC conditions reported by Cppcheck
2019-10-03 09:04:26 +02:00
