Michał Kępień
ca528766d6
Restore locking in resume_dslookup()
...
Commit 9da902a201b6d0e1bdbac0af067a59bb0a489c9c removed locking around
the fctx_decreference() call inside resume_dslookup(). This allows
fctx_unlink() to be called without the bucket lock being held, which
must never happen. Ensure the bucket lock is held by resume_dslookup()
before it calls fctx_decreference().
2019-07-23 11:43:46 +02:00
Ondřej Surý
dd358e6a21
Merge branch 'u/fanf2/arm-rrset-order-random' into 'master'
...
doc/arm: correct default for rrset-order
See merge request isc-projects/bind9!2146
2019-07-22 18:24:32 -04:00
Tony Finch
bded8af7b8
doc/arm: correct default for rrset-order
2019-07-22 18:12:29 -04:00
Ondřej Surý
07b4859dec
Merge branch '195-add-dnstap-builds-to-ci' into 'master'
...
Add dnstap builds to CI
Closes #195
See merge request isc-projects/bind9!2160
2019-07-22 17:48:27 -04:00
Michał Kępień
2bf44c6cd4
Add dnstap builds to CI
...
Ensure BIND with dnstap support enabled is being continuously tested by
adding --enable-dnstap to the ./configure invocation used for CentOS 7
and Debian sid builds in GitLab CI.
2019-07-22 17:35:46 -04:00
Ondřej Surý
673aa9f626
Merge branch 'each-fix-ld-wrap-test' into 'master'
...
Fix LD_WRAP test in configure
See merge request isc-projects/bind9!1806
2019-07-22 17:18:02 -04:00
Evan Hunt
839ed7894b
Make the symbol wrapping work with dynamic linking
...
When the unit test is linked with dynamic libraries, the wrapping
doesn't occur, probably because it's different translation unit.
To workaround the issue, we provide thin wrappers with *real* symbol
names that just call the mocked functions.
2019-07-22 17:16:51 -04:00
Ondřej Surý
135519e59a
Fix the configure.ac and Makefile.in to correctly test for --wrap
2019-07-22 23:00:37 +02:00
Mark Andrews
c808255682
Merge branch '1136-named-checkconf-should-report-missing-dnstap-output-option-when-dnstap-option-is-set' into 'master'
...
Resolve "named-checkconf should report missing dnstap-output option when dnstap option is set"
Closes #1136
See merge request isc-projects/bind9!2147
2019-07-22 15:28:08 -04:00
Mark Andrews
a4f38bec6a
named-checkconf failed to report dnstap-output missing
...
from named.conf when dnstap was specified
2019-07-23 05:09:01 +10:00
Mark Andrews
b786171423
Merge branch '1106-interaction-between-dns64-and-rpz-can-cause-unexpected-results' into 'master'
...
Resolve "Interaction between dns64 and RPZ can cause unexpected results"
Closes #1106
See merge request isc-projects/bind9!2111
2019-07-22 14:33:52 -04:00
Mark Andrews
b9a1c31df1
add CHANGES
2019-07-23 04:21:13 +10:00
Mark Andrews
1eb640049c
Do not attempt to perform a DNS64 rewrite if RPZ returns NODATA.
2019-07-23 04:19:28 +10:00
Mark Andrews
b9dc9b68cd
Check that RPZ 'CNAME *.' (NODATA) works with DNS64.
2019-07-23 04:14:20 +10:00
Ondřej Surý
59a7f75b7e
Merge branch 'michal/add-debian-buster-to-ci' into 'master'
...
Add Debian buster to CI
See merge request isc-projects/bind9!2162
2019-07-22 11:18:47 -04:00
Michał Kępień
5f71d9c6ac
Add Debian buster to CI
...
Ensure BIND is continuously tested on Debian 10 (buster) as it is the
current stable Debian release.
2019-07-22 11:00:32 -04:00
Ondřej Surý
fb40bc061f
Merge branch '1149-fix-crashes-during-resolver-shutdown' into 'master'
...
Restore locking in dns_resolver_shutdown and dns_resolver_attach
Closes #1149
See merge request isc-projects/bind9!2164
2019-07-22 10:02:57 -04:00
Ondřej Surý
a4141fcf98
Restore more locking in the lib/dns/resolver.c code
...
1. Restore locking in the fctx_decreference() code, because the insides of the
function needs to be protected when fctx->references drops to 0.
2. Restore locking in the dns_resolver_attach() code, because two variables are
accessed at the same time and there's slight chance of data race.
2019-07-22 09:03:27 -04:00
Ondřej Surý
317e36d47e
Restore locking in dns_resolver_shutdown and dns_resolver_attach
...
Although the struct dns_resolver.exiting member is protected by stdatomics, we
actually need to wait for whole dns_resolver_shutdown() to finish before
destroying the resolver object. Otherwise, there would be a data race and some
fctx objects might not be destroyed yet at the time we tear down the
dns_resolver object.
2019-07-22 08:17:36 -04:00
Ondřej Surý
0b8632e662
Merge branch '605-fixes' into 'master'
...
Fix missing siphash_test from Kyuafile and missing endian.h from MSVC build files
Closes #605
See merge request isc-projects/bind9!2173
2019-07-22 08:15:34 -04:00
Ondřej Surý
779aa2c9d9
Add siphash_test to lib/isc/tests/Kyuafile
2019-07-22 08:06:14 -04:00
Ondřej Surý
926f2dedbd
Add endian.h to libisc.vcxproj.* files
2019-07-22 08:06:14 -04:00
Ondřej Surý
03b8e7ccb7
Merge branch '1153-fix-broken-atomics-on-windows' into 'master'
...
Fixup the increment vs decrement typo in lib/isc/win32/socket.c
Closes #1153
See merge request isc-projects/bind9!2172
2019-07-21 22:18:48 -04:00
Ondřej Surý
69e84ab9c1
Fixup the increment vs decrement typo in lib/isc/win32/socket.c
2019-07-21 22:05:24 -04:00
Ondřej Surý
51ec6f6500
Merge branch '605-add-siphash24-wpk' into 'master'
...
Synchronize the Cookie algorithm to SipHash-2-4 with other open-source DNS vendors
Closes #605
See merge request isc-projects/bind9!1788
2019-07-21 15:30:30 -04:00
Ondřej Surý
1711e61549
Add CHANGES note
2019-07-21 15:16:28 -04:00
Ondřej Surý
eee6f51d05
Add release notes
2019-07-21 15:16:28 -04:00
Ondřej Surý
a912f31398
Add new default siphash24 cookie algorithm, but keep AES as legacy
...
This commit changes the BIND cookie algorithms to match
draft-sury-toorop-dnsop-server-cookies-00. Namely, it changes the Client Cookie
algorithm to use SipHash 2-4, adds the new Server Cookie algorithm using SipHash
2-4, and changes the default for the Server Cookie algorithm to be siphash24.
Add siphash24 cookie algorithm, and make it keep legacy aes as
2019-07-21 15:16:28 -04:00
Witold Kręcicki
afa81ee4e4
Remove all cookie algorithms but AES, which was used as a default, for legacy purposes.
2019-07-21 10:08:14 -04:00
Ondřej Surý
4e33942742
Merge branch 'ondrej/fix-leaked-memory-in-geoip_test.c' into 'master'
...
Fix leaked memory in geoip_test.c
See merge request isc-projects/bind9!2154
2019-07-16 12:55:01 -04:00
Ondřej Surý
d1c7b79183
Fix the memory leaks in GeoIP unit test
...
Each individual test opened GeoIP databased but the database handles were never
closed. This commit moves the open/close from the individual unit tests into
the _setup and _teardown methods where they really belong.
2019-07-16 15:35:34 +02:00
Ondřej Surý
4084ba1085
Merge branch 'ondrej/remove-mutexatomics-tests' into 'master'
...
Disable the mutexatomics tests from the regular CI (we could enable them on...
See merge request isc-projects/bind9!2150
2019-07-12 10:07:20 -04:00
Ondřej Surý
257b0456f1
Disable the mutexatomics tests from the regular CI (we could enable them on trigger or schedule in the future)
2019-07-12 16:01:01 +02:00
Ondřej Surý
00f9ed8f8b
Merge branch 'ondrej/add-memcpy.spatch-and-fix-check-cocci-script' into 'master'
...
Add memcpy.spatch and fixup check-cocci script
See merge request isc-projects/bind9!2149
2019-07-12 09:59:25 -04:00
Ondřej Surý
f3bcd1485f
Don't cover the .spatch files with copyright
2019-07-12 15:45:07 +02:00
Ondřej Surý
9f916b000e
Make util/check-cocci modify the files in place and be more verbose
2019-07-12 15:38:48 +02:00
Ondřej Surý
5b5930dca1
Remove #include <config.h> usage from siphash.c and siphash_test.c
2019-07-12 15:28:58 +02:00
Ondřej Surý
dc234e3819
Replace the only memcpy usage with memmove
2019-07-12 15:28:00 +02:00
Ondřej Surý
7615e86fae
Add spatch to replace memcpy usage with memmove
2019-07-12 15:27:06 +02:00
Ondřej Surý
5efc32ebae
Fix the check-cocci script to scan bin lib fuzz dirs individually, as it was using only the last one
2019-07-12 15:26:48 +02:00
Tinderbox User
98eda76eb6
Merge branch 'prep-release'
v9.15.2
2019-07-10 15:00:29 +00:00
Tinderbox User
2e637325ed
prep 9.15.2
2019-07-10 14:59:47 +00:00
Witold Krecicki
4b4f33e676
Merge branch '1139-1952-breaks-windows-build' into 'master'
...
Resolve "!1952 Breaks Windows Build"
Closes #1139
See merge request isc-projects/bind9!2145
2019-07-10 09:18:23 -04:00
Witold Kręcicki
895eabd376
Fix Windows compilation issues with !1952 , contributed by Thomas Jach
2019-07-10 12:31:39 +02:00
Witold Krecicki
3cf11418b5
Merge branch 'wpk-fix-compilation-error-statschannel' into 'master'
...
statschannel.c: declare dnssecsignstat_dump only if it's used (LIBXML2 or LIBJSON is available)
See merge request isc-projects/bind9!2143
2019-07-09 13:19:56 -04:00
Witold Kręcicki
111d08a6ad
statschannel.c: declare dnssecsignstat_dump only if it's used (LIBXML2 or LIBJSON is available)
2019-07-09 18:08:49 +02:00
Witold Krecicki
fcabb55942
Merge branch '1038-proper-atomics-use' into 'master'
...
Resolve "Make proper use of the atomics"
Closes #1038
See merge request isc-projects/bind9!1952
2019-07-09 11:14:49 -04:00
Witold Kręcicki
db8acb4898
CHANGES
2019-07-09 16:11:14 +02:00
Witold Kręcicki
dd7bd1c23f
Add --enable-mutex-atomics build to CI
2019-07-09 16:11:14 +02:00
Witold Kręcicki
e56cc07f50
Fix a few broken atomics initializations
2019-07-09 16:11:14 +02:00