2
0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 14:07:59 +00:00
Commit Graph

38653 Commits

Author SHA1 Message Date
Ondřej Surý
8c48c51f71 Convert doing the TLS IO to to isc_async callback
Simplify the doing the TLS IO by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
3d4d099ac8 Cleanup already defunct tlsconnect netievent
The netievent used for TLS connect was already defunct, just cleanup the
cruft.
2023-03-24 07:58:52 +01:00
Ondřej Surý
35b4ef0a08 Convert sending on the TLS socket to to isc_async callback
Simplify the sending on the TLS socket by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
4f27b14cd1 Convert closing the TLS socket to to isc_async callback
Simplify the closing the TLS socket by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
e185412872 Convert accepting new TCP connection to to isc_async callback
Simplify the acception the new TCP connection by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
1baffb6ff5 Convert canceling UDP socket to to isc_async callback
Simplify the canceling of the UDP socket by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
4419848efd Convert stopping TCP children to to isc_async callback
Simplify the stopping of the TCP children by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
e1524f2b4e Convert starting TCP children to to isc_async callback
Simplify the starting of the TCP children by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
8cb4cfd9db Convert stopping UDP children to to isc_async callback
Simplify the stopping of the UDP children by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
b25dd5eaf5 Convert starting UDP children to to isc_async callback
Simplify the starting of the UDP children by using the isc_async API
from the loopmgr instead of using the asychronous netievent mechanism in
the netmgr.
2023-03-24 07:58:52 +01:00
Ondřej Surý
5a43be0775 Simplify netmgr active handles accounting
The active handles accounting was both using atomic counter and ISC_LIST
to keep track of active handles.  Remove the atomic counter that was in
use before the ISC_LIST was added for better tracking of the handles
attached to the socket.
2023-03-24 07:58:52 +01:00
Ondřej Surý
96cff4fc51 Convert netmgr handle detach to synchronous callback
Instead of calling isc__nmhandle_detach calling
nmhandle_detach_cb() asynchronously when there's closehandle_cb
initialized, convert the closehandle_cb to use isc_job, and make the
isc__nmhandle_detach() to be fully synchronous.
2023-03-24 07:58:52 +01:00
Ondřej Surý
237f4af152 Convert netmgr connect, read and send callbacks to isc_job
The netmgr connect, read and send callbacks can now only be executed on
the same loop, convert it from asynchronous netievent queue event to
more direct isc_job.
2023-03-23 22:33:40 -07:00
Evan Hunt
a61f3156bd Merge branch '3953-remove-delegation-only' into 'main'
remove delegation-only and root-delegation only

Closes #3953

See merge request isc-projects/bind9!7713
2023-03-23 20:21:13 +00:00
Evan Hunt
08c86c4357 revised CHANGES and release note for [GL #3953] 2023-03-23 12:57:01 -07:00
Evan Hunt
833ca463d4 remove {root-}delegation-only
complete the removal of the delegation-only and root-delegation-only
options, and the delegation-only zone type.
2023-03-23 12:57:01 -07:00
Ondřej Surý
9e7b7a5716 Merge branch '3953-deprecate-delegation-only' into 'main'
deprecate delegation-only and root-delegation only

See merge request isc-projects/bind9!7712
2023-03-23 19:06:10 +00:00
Evan Hunt
8d80ee561e CHANGES and release note for [GL #3953] 2023-03-23 19:17:22 +01:00
Evan Hunt
2399556bee deprecate delegation-only and root-delegation only
These options and zone type were created to address the
SiteFinder controversy, in which certain TLD's redirected queries
rather than returning NXDOMAIN. since TLD's are now DNSSEC-signed,
this is no longer likely to be a problem.

The deprecation message for 'type delegation-only' is issued from
the configuration checker rather than the parser. therefore,
isccfg_check_namedconf() has been modified to take a 'nodeprecate'
parameter to suppress the warning when named-checkconf is used with
the command-line option to ignore warnings on deprecated options (-i).
2023-03-23 19:16:24 +01:00
Ondřej Surý
c8c091b7f5 Merge branch '3960-handle-non-ISC_R_SUCCESS-in-rctx_respinit' into 'main'
Properly handle ISC_R_SHUTTINGDOWN in resquery_response()

Closes #3960

See merge request isc-projects/bind9!7715
2023-03-23 11:21:33 +00:00
Ondřej Surý
93259812dd Properly handle ISC_R_SHUTTINGDOWN in resquery_response()
When resquery_response() was called with ISC_R_SHUTTINDOWN, the region
argument would be NULL, but rctx_respinit() would try to pass
region->base and region->len to the isc_buffer_init() leading to
a NULL pointer dereference.  Properly handle non-ISC_R_SUCCESS by
ignoring the provided region.
2023-03-23 11:51:22 +01:00
Michal Nowak
f68deabb31 Merge branch 'mnowak/adapt-release-tarball-comparison-to-tags-with-dots' into 'main'
Adapt release-tarball-comparison.sh to dotted tag notation

See merge request isc-projects/bind9!7698
2023-03-22 15:07:43 +00:00
Michal Nowak
0031af6035 Adapt release-tarball-comparison.sh to dotted tag notation
Recently, the tag notation format changed:

    v9_19_9     -> v9.19.9
    v9_18_13-S1 -> v9.18.13-S1

release-tarball-comparison.sh needs to adapt.
2023-03-22 15:58:15 +01:00
Tom Krizek
95e3861f31 Merge branch '3665-dupsigs-test-stability' into 'main'
Improve dupsigs test stability

Closes #3665

See merge request isc-projects/bind9!7688
2023-03-22 09:55:33 +00:00
Tom Krizek
3291c891f6 Lighten the CI load during the dupsigs test
Previously, an AXFR request would be issued every second while waiting
for the zone to be signed. This might've been the cause of issues in CI
where many tests are running in parallel and any extra load may increase
test instability.

Instead, check for the last NSEC record to have a signature before
commencing the AXFR request to check the zone has been fully signed.

Also increase the time for the zone signing to a total of 60+10 seconds
up from the previous 30.
2023-03-22 10:16:48 +01:00
Tom Krizek
ad647dca13 End dupsigs test early if it fails
There's no point in continuing the dupsigs test if a failure is
detected. End the test early to avoid wasting time and resources.
2023-03-22 10:16:48 +01:00
Tom Krizek
fad2eee631 Store dupsigs axfr to a file for easier debugging 2023-03-22 10:16:48 +01:00
Tom Krizek
cbe2559f37 Redirect dupsigs test output to proper logger
Ensure messages from dupsigs system test end up in its log rather than
stdout. Previously, the output was hard to debug when running the tests
in parallel and messages wouldn't end up in the dupsigs.log.
2023-03-22 10:16:46 +01:00
Arаm Sаrgsyаn
50f7f059eb Merge branch '3955-hold-catz-reference-during-update' into 'main'
Hold a catz reference while the update process is running

Closes #3955

See merge request isc-projects/bind9!7704
2023-03-21 11:39:46 +00:00
Aram Sargsyan
aee14ee5d9 Add a CHANGES note for [GL #3955] 2023-03-21 10:39:52 +00:00
Aram Sargsyan
dc2b8bb1c9 Hold a catz reference while the update process is running
This should delay the catalog zone from being destroyed during
shutdown, if the update process is still running.

Doing this should not introduce significant shutdown delays, as
the update function constantly checks the 'shuttingdown' flag
and cancels the process if it is set.
2023-03-21 10:15:30 +00:00
Michal Nowak
714821bd51 Merge branch 'mnowak/respdiff-drop-allow_failure' into 'main'
respdiff jobs do not need "allow_failure: true"

See merge request isc-projects/bind9!7681
2023-03-17 10:08:40 +00:00
Michal Nowak
dd97ddca6f respdiff jobs do not need "allow_failure: true"
ASAN and TSAN respdiff jobs should be stable and not require
"allow_failure: true" anymore.
2023-03-17 11:05:21 +01:00
Evan Hunt
f62342e74d Merge branch 'each-key-restore-test' into 'main'
add basic test for TSIG key dump/restore functionality

See merge request isc-projects/bind9!7629
2023-03-17 06:09:28 +00:00
Evan Hunt
e914c5e194 add basic test for TSIG key dump/restore functionality
stop and restart the server in the 'tsiggss' test, in order
to confirm that GSS negotiated TSIG keys are saved and restored
when named loads.

added logging to dns_tsigkey_createfromkey() to indicate whether
a key has been statically configured, generated via GSS negotiation,
or restored from a file.
2023-03-16 09:55:50 -07:00
Tom Krizek
7e4414d02d Merge branch 'tkrizek/ci-artifacts-1d' into 'main'
Use the default retention time for CI artifacts

See merge request isc-projects/bind9!7670
2023-03-16 14:04:36 +00:00
Tom Krizek
8fef5676fa Use the default retention time for CI artifacts
The instance-wide GitLab CI artifact retention time was changed to 1 day
up from the previous value of 12 hours. Remove our explicit overrides
for 1 day artifact retention time, as it is the default now.

Previously, most of our jobs had overrides for 1 day retention, while
some of our jobs used the default 12 hours. This discrepancy could be
quite impractical at times.
2023-03-16 15:03:22 +01:00
Tom Krizek
1139907450 Move gitlab-ci.yml comment to its proper place
The comment refers to "interruptible" key, rather than the entire
"default" section.
2023-03-16 15:03:20 +01:00
Tom Krizek
48067d78fa Merge tag 'v9_19_11'
BIND 9.19.11
2023-03-15 18:23:44 +01:00
Artem Boldariev
a319108aeb Merge branch 'artem-remove-tlsdns-and-tcpdns-leftouts' into 'main'
Delete old TLS DNS and TCP DNS dead code

See merge request isc-projects/bind9!7689
2023-03-15 16:55:07 +00:00
Artem Boldariev
719343348e Delete old TLS DNS and TCP DNS dead code
This commit removes old, unused TLS DNS and TCP DNS definitions from
the code. They should have been deleted earlier, but that was missed.
2023-03-15 18:40:58 +02:00
Mark Andrews
95f971b001 Merge branch '3937-zone-sign-kasp' into 'main'
Resolve "NSEC records aren't signed with both configured algorithms during NSEC3->NSEC transition"

Closes #3937

See merge request isc-projects/bind9!7682
2023-03-14 13:16:37 +00:00
Mark Andrews
aafcb8611c Add CHANGES for [GL #3937] 2023-03-14 23:26:39 +11:00
Mark Andrews
4b55201459 When signing with a new algorithm preserve NSEC/NSEC3 chains
If the zone already has existing NSEC/NSEC3 chains then zone_sign
needs to continue to use them.  If there are no chains then use
kasp setting otherwise generate an NSEC chain.
2023-03-14 23:26:39 +11:00
Arаm Sаrgsyаn
bfbaef2f7b Merge branch '3928-placeholder' into 'main'
Add a CHANGES placeholder for [GL #3928]

See merge request isc-projects/bind9!7684
2023-03-14 09:58:24 +00:00
Aram Sargsyan
7211398a77 Add a CHANGES placeholder for [GL #3928] 2023-03-14 09:52:13 +00:00
Mark Andrews
4f670d1916 Merge branch '3939-insufficient-information-to-identify-key' into 'main'
Resolve "Insufficient information to identify key"

Closes #3939

See merge request isc-projects/bind9!7676
2023-03-14 03:09:25 +00:00
Mark Andrews
9f161544fd Report key name when removing it 2023-03-13 23:26:35 +00:00
Mark Andrews
7a0a2fc3e4 Add ISC_FORMAT_PRINTF to report's declaration
dns_dnssec_updatekeys's 'report' could be called with invalid arguments
which the compiler should be be able to detect.
2023-03-13 23:26:35 +00:00
Arаm Sаrgsyаn
251c0bcae3 Merge branch '3924-dnstap-test-timing-issue' into 'main'
Resolve "missing messages in `dnstap` system test after query failure"

Closes #3924

See merge request isc-projects/bind9!7674
2023-03-13 11:48:19 +00:00