Ondřej Surý
9fda5253fd
Remove isc_string_printf and isc_string_printf_truncate.
...
Replace with simple snprintf() as appropriate.
2018-04-12 10:37:33 +02:00
Ondřej Surý
ccdb0287e8
Remove isc_string_copy, isc_string_copy_truncate and isc_string_append.
...
Use strlcpy and strlcat as appropriate instead.
2018-04-12 10:37:33 +02:00
Ondřej Surý
20d145efef
Replace isc_string_touint64 with strtoull (C99)
2018-04-12 10:37:33 +02:00
Ondřej Surý
fd9c3ad389
Merge branch 'socket-options-refactoring' into 'master'
...
Refactoring #defines into typedef enums
See merge request isc-projects/bind9!135
2018-04-12 04:06:51 -04:00
Ondřej Surý
97a88e2248
Add CHANGES entry:
...
4923. [cleanup] Refactor socket and socket event options into
enum types. [GL !135 ]
2018-04-12 09:55:40 +02:00
Ondřej Surý
8bdc23add2
Change ISC_SOCKEVENTATTR_* defines into isc_sockeventattr_t enum
2018-04-12 09:54:24 +02:00
Ondřej Surý
c2f42583c0
Refactor ISC_SOCKET_* defines into an isc_socket_options_t enum
2018-04-12 09:54:21 +02:00
Ondřej Surý
01f8e5dbb8
Merge branch '189-fix-win32-build' into 'master'
...
Fix runtime assertion on Windows due isc_file_template being out-of-sync
Closes #189
See merge request isc-projects/bind9!193
2018-04-12 02:46:21 -04:00
Ondřej Surý
8c99d104e3
Sync isc_file_template functions between unix and win32, so they are same
2018-04-11 23:04:20 +02:00
Ondřej Surý
91683d19a8
Merge branch '189-fix-tsig-dump-keyfile-name-generation-issues' into 'master'
...
Resolve "Fix TSIG dump keyfile name generation issues"
Closes #189
See merge request isc-projects/bind9!164
2018-04-11 08:37:05 -04:00
Mukund Sivaraman
44b84cb5a6
Fix TSIG dump keyfile name buffer size issues
2018-04-11 12:04:39 +02:00
Ondřej Surý
7467735258
Define PATH_MAX on Windows as _MAX_PATH, so we can use it everywhere
2018-04-11 12:04:39 +02:00
Evan Hunt
7749d7945f
Merge branch '193-fix-variable-definitions-in-bin-tests-Makefile.in' into 'master'
...
Fix variable definitions in bin/tests/Makefile.in
Closes #193
See merge request isc-projects/bind9!183
2018-04-10 23:03:36 -04:00
Evan Hunt
93ee6b8a22
Alter distclean rule to prevent recursing into the same directory twice
...
Commit f87e0c03ee removed the "system" directory from the TESTDIRS
variable in bin/tests/Makefile.in in an attempt to fix "make distclean"
which was broken since commit 0d784de16a. However, this change
prevented any system tests from being run when "make test" is invoked.
We now put it back into both SUBDIRS and TESTDIRS, but with a modified
rule to check for the existence of a Makefile in each subdirectory before
trying to run make there. This prevents "make distclean" from trying to
run again in a directory where it's already been run.
2018-04-10 19:56:45 -07:00
Michał Kępień
80ab2c0f22
Fail CI pipeline when "make test" does not run any system tests
...
Apart from ensuring "make test" returns 0, also check whether any system
test output was generated as a result of running it. This prevents the
CI job running system tests from succeeding unless it actually tests
something.
2018-04-10 19:56:45 -07:00
Evan Hunt
06d164306b
Merge branch 'revert-freebsd-runner' into 'master'
...
Revert freebsd CI runner
See merge request isc-projects/bind9!189
2018-04-10 22:54:24 -04:00
Evan Hunt
ecf5556bea
Revert "Merge branch 'gitlab-ci-freebsd11' into 'master'"
...
This reverts commit f595ab93eb6ea98167ac1c60a6d9dddc7c6f1fa7, reversing
changes made to deae7d33f1330c3f60b2c28aab61bf41f164fe5c.
2018-04-10 19:46:12 -07:00
Evan Hunt
2ad82b0083
Merge branch '197-dnstap-sockaddr' into 'master'
...
Resolve "dnstap: log actual local IPv6 address, not :: listening address"
Closes #197
See merge request isc-projects/bind9!188
2018-04-10 20:18:03 -04:00
Evan Hunt
330b26c9df
CHANGES note
2018-04-10 17:13:06 -07:00
Tony Finch
ccff953c25
dnstap: log actual local IPv6 address, not :: listening address
2018-04-09 18:26:51 +01:00
Ondřej Surý
ecd812b4d6
Merge branch '194-libdns-cleanup-cleanup' into 'master'
...
Fixup the one last occurence of dns_dt_create2 (in dnstap enabled build)
Closes #194
See merge request isc-projects/bind9!185
2018-04-09 10:51:54 -04:00
Mathieu Arnold
ebf7641610
Rename the last occurence of dns_dt_create2.
2018-04-09 16:46:07 +02:00
Ondřej Surý
f595ab93eb
Merge branch 'gitlab-ci-freebsd11' into 'master'
...
Add FreeBSD 11 to GitLab CI
See merge request isc-projects/bind9!184
2018-04-09 10:43:22 -04:00
Ondřej Surý
266f491ff8
Add FreeBSD 11 GitLab CI Runner
2018-04-09 16:32:41 +02:00
Ondřej Surý
deae7d33f1
Merge branch '183-add-dns_fixedname_initname' into 'master'
...
Add and use dns_fixedname_initname()
Closes #183
See merge request isc-projects/bind9!161
2018-04-09 10:12:36 -04:00
Mukund Sivaraman
d7faee2566
Add CHANGES entry:
...
4921. [cleanup] Add dns_fixedname_initname() and refactor the caller
code to make usage of the new function, as a part of
refactoring dns_fixedname_*() macros were turned into
functions. [GL #183 ]
2018-04-09 12:14:16 +02:00
Michał Kępień
39ddf9991f
Do not access dns_fixedname_t fields directly
...
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.
2018-04-09 12:14:16 +02:00
Michał Kępień
4df4a8e731
Use dns_fixedname_initname() where possible
...
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.
This patch was mostly prepared using Coccinelle and the following
semantic patch:
@@
expression fixedname, name;
@@
- dns_fixedname_init(&fixedname);
...
- name = dns_fixedname_name(&fixedname);
+ name = dns_fixedname_initname(&fixedname);
The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.
It is likely that more occurrences of this pattern can be refactored in
an identical way. This commit only takes care of the low-hanging fruit.
2018-04-09 12:14:16 +02:00
Mukund Sivaraman
0d2a03c290
Add a dns_fixedname_initname() helper function
...
This also turns the dns_fixedname macros into functions.
2018-04-09 12:14:16 +02:00
Witold Krecicki
76fa1c181c
Merge branch 'libdns-cleanup2' into 'master'
...
libdns cleanup
See merge request isc-projects/bind9!172
2018-04-06 02:10:50 -04:00
Witold Kręcicki
f6a16bbd4a
libdns refactoring: CHANGES entry
2018-04-06 08:04:41 +02:00
Witold Kręcicki
102a397e39
libdns refactoring: get rid of multiple versions of dns_keytable_add, dns_iptable_addprefix and dns_iptable_addprefix
2018-04-06 08:04:41 +02:00
Witold Kręcicki
c8aa1ee9e6
libdns refactoring: get rid of multiple versions of dns_dt_create, dns_view_setcache, dns_zt_apply, dns_message_logfmtpacket, dns_message_logpacket, dns_ssutable_checkrules and dns_ttl_totext
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d54d482af0
libdns refactoring: get rid of multiple versions of dns_view_find, dns_view_findzonecut and dns_view_flushcache
2018-04-06 08:04:41 +02:00
Witold Kręcicki
702c022016
libdns refactoring: get rid of multiple versions of dns_xfrin_create, dst_key_generate, dst_lib_init and dst_context_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
ef0e68bfc3
libdns refactoring: integrate zone->options and zone->options2 into one enum, removing unnecessary flags.
2018-04-06 08:04:41 +02:00
Witold Kręcicki
7dbc6768d6
libdns refactoring: get rid of multiple versions of dns_zone_setfile, dns_zone_notifyreceive, dns_zone_dumptostream, dns_zone_getserial
2018-04-06 08:04:41 +02:00
Witold Kręcicki
42ee8c853a
libdns refactoring: get rid of 3 versions of dns_resolver_createfetch
2018-04-06 08:04:41 +02:00
Witold Kręcicki
25cd3168a7
libdns refactoring: get rid of multiple versions of dns_dnssec_findmatchingkeys and dns_dnssec_findzonekeys
2018-04-06 08:04:41 +02:00
Witold Kręcicki
8c12e488f7
libdns refactoring: get rid of multiple versions of dns_request_createraw and dns_request_createvia
2018-04-06 08:04:41 +02:00
Witold Kręcicki
e2a06db7f3
libdns refactoring: get rid of multiple versions of dns_master_loadfile, dns_master_loadfileinc, dns_master_dump, dns_master_dumpinc, dns_master_dumptostream, dns_master_stylecreate
2018-04-06 08:04:41 +02:00
Witold Kręcicki
e20b702418
libdns refactoring: get rid of multiple versions of dns_dispatch_createtcp and dns_dispatch_addresponse, unify dns_dispatch_gettcp and dns_dispatch_gettcp2
2018-04-06 08:04:41 +02:00
Witold Kręcicki
275a6a3bec
libdns refactoring: get rid of unnecessary dns_db_dump2 and 3 versions of dns_db_load
2018-04-06 08:04:41 +02:00
Witold Kręcicki
76e17b54ea
libdns refactoring: get rid of two versions of dns_client_createx
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d39b3209fb
libdns refactoring: get rid of 3 versions of dns_cache_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d76ed0da1c
libdns refactoring: get rid of two versions of dns_byaddr_createptrname
2018-04-06 08:04:41 +02:00
Witold Kręcicki
f0a07b7546
libdns refactoring: get rid of two versions of dns_adb_createfind and dns_adb_probesize
2018-04-06 08:04:41 +02:00
Witold Kręcicki
3687648384
libdns refactoring: get rid of two versions of dns_acl_match and dns_aclelement_match
2018-04-06 08:04:40 +02:00
Mark Andrews
10814aaf3b
Merge branch '193-make-distclean-fails' into 'master'
...
Resolve "make distclean fails"
Closes #193
See merge request isc-projects/bind9!182
2018-04-05 23:37:07 -04:00
Mark Andrews
f87e0c03ee
system should only be in SUBDIRS
2018-04-06 13:33:53 +10:00