Michał Kępień
4df4a8e731
Use dns_fixedname_initname() where possible
...
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.
This patch was mostly prepared using Coccinelle and the following
semantic patch:
@@
expression fixedname, name;
@@
- dns_fixedname_init(&fixedname);
...
- name = dns_fixedname_name(&fixedname);
+ name = dns_fixedname_initname(&fixedname);
The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.
It is likely that more occurrences of this pattern can be refactored in
an identical way. This commit only takes care of the low-hanging fruit.
2018-04-09 12:14:16 +02:00
Witold Kręcicki
102a397e39
libdns refactoring: get rid of multiple versions of dns_keytable_add, dns_iptable_addprefix and dns_iptable_addprefix
2018-04-06 08:04:41 +02:00
Witold Kręcicki
c8aa1ee9e6
libdns refactoring: get rid of multiple versions of dns_dt_create, dns_view_setcache, dns_zt_apply, dns_message_logfmtpacket, dns_message_logpacket, dns_ssutable_checkrules and dns_ttl_totext
2018-04-06 08:04:41 +02:00
Witold Kręcicki
702c022016
libdns refactoring: get rid of multiple versions of dns_xfrin_create, dst_key_generate, dst_lib_init and dst_context_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
ef0e68bfc3
libdns refactoring: integrate zone->options and zone->options2 into one enum, removing unnecessary flags.
2018-04-06 08:04:41 +02:00
Witold Kręcicki
7dbc6768d6
libdns refactoring: get rid of multiple versions of dns_zone_setfile, dns_zone_notifyreceive, dns_zone_dumptostream, dns_zone_getserial
2018-04-06 08:04:41 +02:00
Witold Kręcicki
42ee8c853a
libdns refactoring: get rid of 3 versions of dns_resolver_createfetch
2018-04-06 08:04:41 +02:00
Witold Kręcicki
25cd3168a7
libdns refactoring: get rid of multiple versions of dns_dnssec_findmatchingkeys and dns_dnssec_findzonekeys
2018-04-06 08:04:41 +02:00
Witold Kręcicki
275a6a3bec
libdns refactoring: get rid of unnecessary dns_db_dump2 and 3 versions of dns_db_load
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d39b3209fb
libdns refactoring: get rid of 3 versions of dns_cache_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
3687648384
libdns refactoring: get rid of two versions of dns_acl_match and dns_aclelement_match
2018-04-06 08:04:40 +02:00
Ondřej Surý
b097be17ef
Remove unused obsolete isc_hash_* function, and just keep the FNV-1a version
2018-04-04 23:12:14 +02:00
Mark Andrews
f1def91625
check insist on every call; make conditional block constistent with rest of code
2018-03-07 15:18:16 -05:00
Michał Kępień
857a40c87b
Fix MX checks for dynamic updates
...
The check_mx() function in lib/ns/update.c incorrectly tests whether the
DNS_RDATA_CHECKMX/DNS_RDATA_CHECKMXFAIL flags are set for each applied
MX record update as these flags are never set in code paths related to
dynamic updates; they can only be set when loading a zone from a master
file (DNS_ZONEOPT_CHECKMX -> DNS_MASTER_CHECKMX -> DNS_RDATA_CHECKMX).
This flaw allows MX records containing IP addresses to be added to a
zone even when "check-mx fail;" is used.
Ensure correct behavior by modifying the relevant tests in check_mx() so
that they use DNS_ZONEOPT_CHECKMX/DNS_ZONEOPT_CHECKMXFAIL instead.
2018-02-26 13:10:45 +01:00
Evan Hunt
3c028ed07d
Merge branch 'kyua-oot' into 'master'
...
chg: dev: Unit tests were broken in out-of-tree builds.
See merge request isc-projects/bind9!57
2018-02-23 18:22:59 -05:00
Ondřej Surý
a11e23b5ed
Replace all usage of inet_aton() with inet_pton()
2018-02-23 13:57:10 +01:00
Ondřej Surý
843d389661
Update license headers to not include years in copyright in all applicable files
2018-02-23 10:12:02 +01:00
Petr Menšík
95cde3608a
unit/unittest.sh is generated by configure. It will always be
...
generated into builddir. If out-of-tree build is used, make unit
will always fail. Kyuafiles and testdata still have to be copied
manually into the builddir.
2018-02-22 15:32:16 +01:00
Mark Andrews
b492700759
use %u instead of %d
2018-02-16 10:20:38 +11:00
Tinderbox User
b3fc795f4d
update copyright notice / whitespace
2018-02-05 23:46:13 +00:00
Michał Kępień
af1937c35a
[master] Prevent crashing due to a race during server shutdown
...
4884. [bug] named could crash on shutdown due to a race between
shutdown_server() and ns__client_request(). [RT #47120 ]
2018-02-05 20:24:14 +01:00
Mark Andrews
d26f90241d
4880. [bug] Named wasn't returning the target of a cross zone
...
CNAME between to served zones when recursion was
desired and available (RD=1, RA=1). Don't return
the CNAME target otherwise to prevent accidental
cache poisoning. [RT #47078 ]
2018-01-30 13:10:06 +11:00
Tinderbox User
3fda67b596
update copyright notice / whitespace
2018-01-22 23:46:02 +00:00
Mukund Sivaraman
8a4ce20172
Don't permit loading meta RR types such as TKEY from master files ( #47009 )
2018-01-22 14:26:04 +05:30
Mark Andrews
af034ef188
silence clang static analyser warning. [RT #46881 ]
2018-01-22 09:47:53 +11:00
Tinderbox User
ed9fea3a6e
update copyright notice / whitespace
2018-01-15 23:46:16 +00:00
Mark Andrews
fa22351a7c
silence coverity false positive. [RT #46841 ]
2018-01-15 12:02:41 +11:00
Tinderbox User
5ce167be2e
update copyright notice / whitespace
2018-01-12 23:45:54 +00:00
Mukund Sivaraman
f96133826e
Fix various bugs reported by valgrind --tool=memcheck ( #46978 )
2018-01-13 00:33:35 +05:30
Mark Andrews
67faaa41c9
test devent->sigrdataset rather than devent->rdataset before calling query_putrdataset
2018-01-05 12:36:21 +11:00
Mark Andrews
9e6b394410
use RESTORE rather than SAVE as is better describes the operation
2018-01-04 13:11:28 +11:00
Mark Andrews
eed2f6cef0
4857. [bug] Maintain attach/detach semantics for event->db,
...
event->node, event->rdataset and event->sigrdataset
in query.c. [RT #46891 ]
2018-01-04 10:48:18 +11:00
Tinderbox User
7bba3a7c44
update copyright notice / whitespace
2018-01-02 23:45:28 +00:00
Mark Andrews
c9ee9718ae
4854. [bug] query_synthcnamewildcard should stop generating the
...
response if query_synthwildcard fails. [RT #46939 ]
2018-01-03 10:07:42 +11:00
Tinderbox User
903662d5c3
regen master
2017-12-29 01:44:18 +00:00
Tinderbox User
015c017dfa
regen master
2017-12-29 01:04:39 +00:00
Evan Hunt
2f855055ed
[master] prep 9.12.0rc1
2017-11-30 14:39:16 -08:00
Mark Andrews
14e9925868
add missing entries to .def files [RT #46215 ]
2017-11-27 13:49:39 +11:00
Mark Andrews
3d905e0533
4817. [cleanup] Use DNS_NAME_INITABSOLUTE and DNS_NAME_INITNONABSOLUTE.
...
[RT #45433 ]
2017-11-13 16:58:12 +11:00
Mark Andrews
c0e3e1fe44
4813. [bug] Address potential read after free errors from
...
query_synthnodata, query_synthwildcard and
query_synthnxdomain. [RT #46547 ]
2017-11-10 13:33:18 +11:00
Mark Andrews
b231ddc65d
fix the IPv6 address length in compute_cookie. [RT #46538 ]
2017-11-09 23:59:20 +11:00
Mukund Sivaraman
7e1df5182c
[master] isc_rng_randombytes()
...
4807. [cleanup] isc_rng_randombytes() returns a specified number of
bytes from the PRNG; this is now used instead of
calling isc_rng_random() multiple times. [RT #46230 ]
2017-11-06 10:44:37 -08:00
Evan Hunt
8d23105547
[master] prep 9.12.0b2
2017-11-02 11:50:07 -07:00
Evan Hunt
65314b0fd8
[master] "enable-filter-aaaa" no longer optional
...
4786. [func] The "filter-aaaa-on-v4" and "filter-aaaa-on-v6"
options are no longer conditionally compiled.
[RT #46340 ]
2017-10-25 00:33:51 -07:00
Evan Hunt
0207f6ff9e
[master] omit NS from authority section if it was in answer
...
4780. [bug] When answering ANY queries, don't include the NS
RRset in the authority section if it was already
in the answer section. [RT #44543 ]
2017-10-23 19:16:27 -07:00
Mark Andrews
a59d687db4
4778. [test] Improve synth-from-dnssec testing. [RT #46352 ]
2017-10-24 09:49:07 +11:00
Michał Kępień
34ee1cdb56
[master] Extend hooks documentation
2017-10-23 14:17:44 +02:00
Michał Kępień
6853af8fc5
[master] Deconstify hook tables as replacing single entries is allowed
2017-10-23 14:17:07 +02:00
Mark Andrews
fe79e2efbf
4774. [bug] <isc/util.h> was incorrectly included in several
...
header files. [RT #46311 ]
2017-10-19 12:26:32 +11:00
Michał Kępień
2361003a88
[master] Doxygen fixes and cleanups
...
4773. [doc] Fixed generating Doxygen documentation for functions
annotated using certain macros. Miscellaneous
Doxygen-related cleanups. [RT #46276 ]
2017-10-17 06:56:46 +02:00