mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-22 10:10:06 +00:00
Locally, clang reported following odr-violation: ================================================================= ==1132009==ERROR: AddressSanitizer: odr-violation (0x555555589280): [1] size=8 'isc__loopmgr' ../lib/isc/loop.c:52:16 in /home/ondrej/Projects/bind9/build/tests/isc/loop [2] size=8 'isc__loopmgr' ../lib/isc/loop.c:52:16 in /home/ondrej/Projects/bind9/build/tests/isc/../../libisc.so These globals were registered at these points: [1]: #0 0x7ffff785306f in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:350 #1 0x55555556abce in _sub_I_00099_1 (/home/ondrej/Projects/bind9/build/tests/isc/loop+0x16bce) (BuildId: e7c586e966e6986532a3da40df41223ae16e55c9) #2 0x7ffff702a303 in call_init ../csu/libc-start.c:145 #3 0x7ffff702a303 in __libc_start_main_impl ../csu/libc-start.c:347 #4 0x5555555622e4 in _start (/home/ondrej/Projects/bind9/build/tests/isc/loop+0xe2e4) (BuildId: e7c586e966e6986532a3da40df41223ae16e55c9) [2]: #0 0x7ffff785306f in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:350 #1 0x7ffff75335b9 in _sub_I_00099_1 (/home/ondrej/Projects/bind9/build/tests/isc/../../libisc.so+0x1335b9) (BuildId: 33ab72bc676e9ef9111b3db1fc4347595069cd29) #2 0x7ffff7fca71e in call_init elf/dl-init.c:74 #3 0x7ffff7fca823 in call_init elf/dl-init.c:120 #4 0x7ffff7fca823 in _dl_init elf/dl-init.c:121 #5 0x7ffff7fe459f (/lib64/ld-linux-x86-64.so.2+0x1f59f) (BuildId: 281ac1521b4102509b1c7ac7004db7c1efb81796) ==1132009==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0 SUMMARY: AddressSanitizer: odr-violation: global 'isc__loopmgr' at ../lib/isc/loop.c:52:16 in /home/ondrej/Projects/bind9/build/tests/isc/loop ==1132009==ABORTING Aborted (core dumped) Rename isc__loopmgr when including the loop.c into loop_test.c to prevent odr-violation over isc__loopmgr.
140 lines
3.1 KiB
C
140 lines
3.1 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
#include <inttypes.h>
|
|
#include <sched.h> /* IWYU pragma: keep */
|
|
#include <setjmp.h>
|
|
#include <stdarg.h>
|
|
#include <stddef.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include "isc/attributes.h"
|
|
|
|
#define UNIT_TESTING
|
|
#include <cmocka.h>
|
|
|
|
#include <isc/atomic.h>
|
|
#include <isc/lib.h>
|
|
#include <isc/loop.h>
|
|
#include <isc/os.h>
|
|
#include <isc/result.h>
|
|
#include <isc/util.h>
|
|
|
|
/*
|
|
* Prevent the odr-violation by renaming isc__loopmgr when including loop.c for
|
|
* the second time.
|
|
*/
|
|
#define isc__loopmgr isc___loopmgr
|
|
#include "loop.c"
|
|
|
|
#include <tests/isc.h>
|
|
|
|
static atomic_uint scheduled = 0;
|
|
|
|
static void
|
|
count(void *arg ISC_ATTR_UNUSED) {
|
|
atomic_fetch_add(&scheduled, 1);
|
|
}
|
|
|
|
static void
|
|
shutdown_loopmgr(void *arg ISC_ATTR_UNUSED) {
|
|
while (atomic_load(&scheduled) != isc_loopmgr_nloops()) {
|
|
isc_thread_yield();
|
|
}
|
|
|
|
isc_loopmgr_shutdown();
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_loopmgr) {
|
|
atomic_store(&scheduled, 0);
|
|
|
|
isc_loopmgr_setup(count, NULL);
|
|
isc_loop_setup(isc_loop_main(), shutdown_loopmgr, NULL);
|
|
|
|
isc_loopmgr_run();
|
|
|
|
assert_int_equal(atomic_load(&scheduled), isc_loopmgr_nloops());
|
|
}
|
|
|
|
static void
|
|
runjob(void *arg ISC_ATTR_UNUSED) {
|
|
isc_async_current(count, NULL);
|
|
if (isc_tid() == 0) {
|
|
isc_async_current(shutdown_loopmgr, NULL);
|
|
}
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_loopmgr_runjob) {
|
|
atomic_store(&scheduled, 0);
|
|
|
|
isc_loopmgr_setup(runjob, NULL);
|
|
isc_loopmgr_run();
|
|
assert_int_equal(atomic_load(&scheduled), isc_loopmgr_nloops());
|
|
}
|
|
|
|
static void
|
|
pause_loopmgr(void *arg ISC_ATTR_UNUSED) {
|
|
isc_loopmgr_pause();
|
|
|
|
assert_true(isc_loopmgr_paused());
|
|
|
|
for (size_t i = 0; i < isc_loopmgr_nloops(); i++) {
|
|
isc_loop_t *loop = isc_loop_get(i);
|
|
|
|
assert_true(loop->paused);
|
|
}
|
|
|
|
atomic_init(&scheduled, isc_loopmgr_nloops());
|
|
|
|
isc_loopmgr_resume();
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_loopmgr_pause) {
|
|
isc_loop_setup(isc_loop_main(), pause_loopmgr, NULL);
|
|
isc_loop_setup(isc_loop_main(), shutdown_loopmgr, NULL);
|
|
isc_loopmgr_run();
|
|
}
|
|
|
|
static void
|
|
send_sigint(void *arg ISC_ATTR_UNUSED) {
|
|
kill(getpid(), SIGINT);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_loopmgr_sigint) {
|
|
isc_loop_setup(isc_loop_main(), send_sigint, NULL);
|
|
isc_loopmgr_run();
|
|
}
|
|
|
|
static void
|
|
send_sigterm(void *arg ISC_ATTR_UNUSED) {
|
|
kill(getpid(), SIGINT);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_loopmgr_sigterm) {
|
|
isc_loop_setup(isc_loop_main(), send_sigterm, NULL);
|
|
isc_loopmgr_run();
|
|
}
|
|
|
|
ISC_TEST_LIST_START
|
|
ISC_TEST_ENTRY_CUSTOM(isc_loopmgr, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_ENTRY_CUSTOM(isc_loopmgr_pause, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_ENTRY_CUSTOM(isc_loopmgr_runjob, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_ENTRY_CUSTOM(isc_loopmgr_sigint, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_ENTRY_CUSTOM(isc_loopmgr_sigterm, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_LIST_END
|
|
|
|
ISC_TEST_MAIN
|