mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-09-05 09:05:40 +00:00
In e185412872
, the TCP accept quota code
became broken in a subtle way - the quota would get initialized on the
first accept for the server socket and then deleted from the server
socket, so it would never get applied again.
Properly fixing this required a bigger refactoring of the isc_quota API
code to make it much simpler. The new code decouples the ownership of
the quota and acquiring/releasing the quota limit.
After (during) the refactoring it became more clear that we need to use
the callback from the child side of the accepted connection, and not the
server side.
312 lines
7.6 KiB
C
312 lines
7.6 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
#include <sched.h> /* IWYU pragma: keep */
|
|
#include <setjmp.h>
|
|
#include <stdarg.h>
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
|
|
#define UNIT_TESTING
|
|
#include <cmocka.h>
|
|
|
|
#include <isc/job.h>
|
|
#include <isc/quota.h>
|
|
#include <isc/result.h>
|
|
#include <isc/thread.h>
|
|
#include <isc/util.h>
|
|
#include <isc/uv.h>
|
|
|
|
#include <tests/isc.h>
|
|
|
|
isc_quota_t quota;
|
|
|
|
ISC_RUN_TEST_IMPL(isc_quota_get_set) {
|
|
UNUSED(state);
|
|
isc_quota_init("a, 100);
|
|
|
|
assert_int_equal(isc_quota_getmax("a), 100);
|
|
assert_int_equal(isc_quota_getsoft("a), 0);
|
|
|
|
isc_quota_max("a, 50);
|
|
isc_quota_soft("a, 30);
|
|
|
|
assert_int_equal(isc_quota_getmax("a), 50);
|
|
assert_int_equal(isc_quota_getsoft("a), 30);
|
|
|
|
assert_int_equal(isc_quota_getused("a), 0);
|
|
isc_quota_acquire("a);
|
|
assert_int_equal(isc_quota_getused("a), 1);
|
|
isc_quota_release("a);
|
|
assert_int_equal(isc_quota_getused("a), 0);
|
|
isc_quota_destroy("a);
|
|
}
|
|
|
|
static void
|
|
add_quota(isc_quota_t *source, isc_result_t expected_result,
|
|
int expected_used) {
|
|
isc_result_t result;
|
|
|
|
result = isc_quota_acquire(source);
|
|
assert_int_equal(result, expected_result);
|
|
|
|
switch (expected_result) {
|
|
case ISC_R_SUCCESS:
|
|
case ISC_R_SOFTQUOTA:
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
assert_int_equal(isc_quota_getused(source), expected_used);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_quota_hard) {
|
|
int i;
|
|
UNUSED(state);
|
|
|
|
isc_quota_init("a, 100);
|
|
|
|
for (i = 0; i < 100; i++) {
|
|
add_quota("a, ISC_R_SUCCESS, i + 1);
|
|
}
|
|
|
|
add_quota("a, ISC_R_QUOTA, 100);
|
|
|
|
assert_int_equal(isc_quota_getused("a), 100);
|
|
|
|
isc_quota_release("a);
|
|
|
|
add_quota("a, ISC_R_SUCCESS, 100);
|
|
add_quota("a, ISC_R_QUOTA, 100);
|
|
|
|
for (i = 100; i > 0; i--) {
|
|
isc_quota_release("a);
|
|
assert_int_equal(isc_quota_getused("a), i - 1);
|
|
}
|
|
assert_int_equal(isc_quota_getused("a), 0);
|
|
isc_quota_destroy("a);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_quota_soft) {
|
|
int i;
|
|
UNUSED(state);
|
|
|
|
isc_quota_init("a, 100);
|
|
isc_quota_soft("a, 50);
|
|
|
|
for (i = 0; i < 50; i++) {
|
|
add_quota("a, ISC_R_SUCCESS, i + 1);
|
|
}
|
|
for (i = 50; i < 100; i++) {
|
|
add_quota("a, ISC_R_SOFTQUOTA, i + 1);
|
|
}
|
|
|
|
add_quota("a, ISC_R_QUOTA, 100);
|
|
|
|
for (i = 99; i >= 0; i--) {
|
|
isc_quota_release("a);
|
|
assert_int_equal(isc_quota_getused("a), i);
|
|
}
|
|
assert_int_equal(isc_quota_getused("a), 0);
|
|
isc_quota_destroy("a);
|
|
}
|
|
|
|
static atomic_uint_fast32_t cb_calls = 0;
|
|
static isc_job_t cbs[30];
|
|
|
|
static void
|
|
callback(void *data) {
|
|
int val = *(int *)data;
|
|
/* Callback is not called if we get the quota directly */
|
|
assert_int_not_equal(val, -1);
|
|
|
|
/* Verify that the callbacks are called in order */
|
|
int v = atomic_fetch_add_relaxed(&cb_calls, 1);
|
|
assert_int_equal(v, val);
|
|
|
|
/*
|
|
* First 5 will be detached by the test function,
|
|
* for the last 5 - do a 'chain detach'.
|
|
*/
|
|
if (v >= 5) {
|
|
isc_quota_release("a);
|
|
}
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_quota_callback) {
|
|
isc_result_t result;
|
|
/*
|
|
* - 10 calls that end with SUCCESS
|
|
* - 10 calls that end with SOFTQUOTA
|
|
* - 10 callbacks
|
|
*/
|
|
int ints[] = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
|
|
-1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
|
|
0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
|
|
int i;
|
|
UNUSED(state);
|
|
|
|
isc_quota_init("a, 20);
|
|
isc_quota_soft("a, 10);
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
cbs[i] = (isc_job_t)ISC_JOB_INITIALIZER;
|
|
result = isc_quota_acquire_cb("a, &cbs[i], callback,
|
|
&ints[i]);
|
|
assert_int_equal(result, ISC_R_SUCCESS);
|
|
assert_int_equal(isc_quota_getused("a), i + 1);
|
|
}
|
|
for (i = 10; i < 20; i++) {
|
|
cbs[i] = (isc_job_t)ISC_JOB_INITIALIZER;
|
|
result = isc_quota_acquire_cb("a, &cbs[i], callback,
|
|
&ints[i]);
|
|
assert_int_equal(result, ISC_R_SOFTQUOTA);
|
|
assert_int_equal(isc_quota_getused("a), i + 1);
|
|
}
|
|
|
|
for (i = 20; i < 30; i++) {
|
|
cbs[i] = (isc_job_t)ISC_JOB_INITIALIZER;
|
|
result = isc_quota_acquire_cb("a, &cbs[i], callback,
|
|
&ints[i]);
|
|
assert_int_equal(result, ISC_R_QUOTA);
|
|
assert_int_equal(isc_quota_getused("a), 20);
|
|
}
|
|
assert_int_equal(atomic_load(&cb_calls), 0);
|
|
|
|
for (i = 0; i < 5; i++) {
|
|
isc_quota_release("a);
|
|
assert_int_equal(isc_quota_getused("a), 20);
|
|
assert_int_equal(atomic_load(&cb_calls), i + 1);
|
|
}
|
|
/* That should cause a chain reaction */
|
|
isc_quota_release("a);
|
|
assert_int_equal(atomic_load(&cb_calls), 10);
|
|
|
|
/* Release the quotas that we did not released in the callback */
|
|
for (i = 0; i < 5; i++) {
|
|
isc_quota_release("a);
|
|
}
|
|
|
|
for (i = 6; i < 20; i++) {
|
|
isc_quota_release("a);
|
|
assert_int_equal(isc_quota_getused("a), 19 - i);
|
|
}
|
|
assert_int_equal(atomic_load(&cb_calls), 10);
|
|
|
|
assert_int_equal(isc_quota_getused("a), 0);
|
|
isc_quota_destroy("a);
|
|
}
|
|
|
|
/*
|
|
* Multithreaded quota callback test:
|
|
* - quota set to 100
|
|
* - 10 threads, each trying to get 100 quotas.
|
|
* - creates a separate thread to release it after 10ms
|
|
*/
|
|
|
|
typedef struct qthreadinfo {
|
|
atomic_uint_fast32_t direct;
|
|
atomic_uint_fast32_t callback;
|
|
isc_job_t callbacks[100];
|
|
} qthreadinfo_t;
|
|
|
|
static atomic_uint_fast32_t g_tnum = 0;
|
|
/* at most 10 * 100 quota_detach threads */
|
|
isc_thread_t g_threads[10 * 100];
|
|
|
|
static void *
|
|
quota_release(void *arg) {
|
|
uv_sleep(10);
|
|
isc_quota_release((isc_quota_t *)arg);
|
|
return ((isc_threadresult_t)0);
|
|
}
|
|
|
|
static void
|
|
quota_callback(void *data) {
|
|
qthreadinfo_t *qti = (qthreadinfo_t *)data;
|
|
atomic_fetch_add_relaxed(&qti->callback, 1);
|
|
int tnum = atomic_fetch_add_relaxed(&g_tnum, 1);
|
|
isc_thread_create(quota_release, "a, &g_threads[tnum]);
|
|
}
|
|
|
|
static isc_threadresult_t
|
|
quota_thread(void *qtip) {
|
|
qthreadinfo_t *qti = (qthreadinfo_t *)qtip;
|
|
for (int i = 0; i < 100; i++) {
|
|
qti->callbacks[i] = (isc_job_t)ISC_JOB_INITIALIZER;
|
|
isc_result_t result = isc_quota_acquire_cb(
|
|
"a, &qti->callbacks[i], quota_callback, qti);
|
|
if (result == ISC_R_SUCCESS) {
|
|
atomic_fetch_add_relaxed(&qti->direct, 1);
|
|
int tnum = atomic_fetch_add_relaxed(&g_tnum, 1);
|
|
isc_thread_create(quota_release, "a,
|
|
&g_threads[tnum]);
|
|
}
|
|
}
|
|
return ((isc_threadresult_t)0);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_quota_callback_mt) {
|
|
UNUSED(state);
|
|
int i;
|
|
|
|
isc_quota_init("a, 100);
|
|
static qthreadinfo_t qtis[10];
|
|
isc_thread_t threads[10];
|
|
for (i = 0; i < 10; i++) {
|
|
atomic_init(&qtis[i].direct, 0);
|
|
atomic_init(&qtis[i].callback, 0);
|
|
isc_thread_create(quota_thread, &qtis[i], &threads[i]);
|
|
}
|
|
for (i = 0; i < 10; i++) {
|
|
isc_thread_join(threads[i], NULL);
|
|
}
|
|
|
|
for (i = 0; i < (int)atomic_load(&g_tnum); i++) {
|
|
isc_thread_join(g_threads[i], NULL);
|
|
}
|
|
int direct = 0, ncallback = 0;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
direct += atomic_load(&qtis[i].direct);
|
|
ncallback += atomic_load(&qtis[i].callback);
|
|
}
|
|
/* Total quota gained must be 10 threads * 100 tries */
|
|
assert_int_equal(direct + ncallback, 10 * 100);
|
|
/*
|
|
* At least 100 must be direct, the rest is virtually random:
|
|
* - in a regular run I'm constantly getting 100:900 ratio
|
|
* - under rr - usually around ~120:880
|
|
* - under rr -h - 1000:0
|
|
*/
|
|
assert_true(direct >= 100);
|
|
|
|
isc_quota_destroy("a);
|
|
}
|
|
|
|
ISC_TEST_LIST_START
|
|
|
|
ISC_TEST_ENTRY(isc_quota_get_set)
|
|
ISC_TEST_ENTRY(isc_quota_hard)
|
|
ISC_TEST_ENTRY(isc_quota_soft)
|
|
ISC_TEST_ENTRY(isc_quota_callback)
|
|
ISC_TEST_ENTRY(isc_quota_callback_mt)
|
|
|
|
ISC_TEST_LIST_END
|
|
|
|
ISC_TEST_MAIN
|