2
0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 05:28:00 +00:00
bind/lib/dns/rdata/generic/null_10.c
Evan Hunt bbaade23eb mem_maybedup() can no longer fail
mem_maybedup() calls isc_mem_allocate() if an mctx is supplied,
but that can no longer fail, so now the only way mem_maybedup()
could return NULL is if it was given a NULL source address by the
caller. this commit adds a REQUIRE to prevent that scenario, and
cleans up all the calling code that previously checked for NULL
return values.

this function is mostly used in rdata tostruct() implementations, so
the documentation for dns_rdata_tostruct() has been updated to
remove 'ISC_R_NOMEMORY' as a possible return value.
2022-02-25 20:57:08 -08:00

184 lines
3.7 KiB
C

/*
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
*
* SPDX-License-Identifier: MPL-2.0
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
*
* See the COPYRIGHT file distributed with this work for additional
* information regarding copyright ownership.
*/
#ifndef RDATA_GENERIC_NULL_10_C
#define RDATA_GENERIC_NULL_10_C
#define RRTYPE_NULL_ATTRIBUTES (0)
static inline isc_result_t
fromtext_null(ARGS_FROMTEXT) {
REQUIRE(type == dns_rdatatype_null);
UNUSED(rdclass);
UNUSED(type);
UNUSED(lexer);
UNUSED(origin);
UNUSED(options);
UNUSED(target);
UNUSED(callbacks);
return (DNS_R_SYNTAX);
}
static inline isc_result_t
totext_null(ARGS_TOTEXT) {
REQUIRE(rdata->type == dns_rdatatype_null);
return (unknown_totext(rdata, tctx, target));
}
static inline isc_result_t
fromwire_null(ARGS_FROMWIRE) {
isc_region_t sr;
REQUIRE(type == dns_rdatatype_null);
UNUSED(type);
UNUSED(rdclass);
UNUSED(dctx);
UNUSED(options);
isc_buffer_activeregion(source, &sr);
isc_buffer_forward(source, sr.length);
return (mem_tobuffer(target, sr.base, sr.length));
}
static inline isc_result_t
towire_null(ARGS_TOWIRE) {
REQUIRE(rdata->type == dns_rdatatype_null);
UNUSED(cctx);
return (mem_tobuffer(target, rdata->data, rdata->length));
}
static inline int
compare_null(ARGS_COMPARE) {
isc_region_t r1;
isc_region_t r2;
REQUIRE(rdata1->type == rdata2->type);
REQUIRE(rdata1->rdclass == rdata2->rdclass);
REQUIRE(rdata1->type == dns_rdatatype_null);
dns_rdata_toregion(rdata1, &r1);
dns_rdata_toregion(rdata2, &r2);
return (isc_region_compare(&r1, &r2));
}
static inline isc_result_t
fromstruct_null(ARGS_FROMSTRUCT) {
dns_rdata_null_t *null = source;
REQUIRE(type == dns_rdatatype_null);
REQUIRE(null != NULL);
REQUIRE(null->common.rdtype == type);
REQUIRE(null->common.rdclass == rdclass);
REQUIRE(null->data != NULL || null->length == 0);
UNUSED(type);
UNUSED(rdclass);
return (mem_tobuffer(target, null->data, null->length));
}
static inline isc_result_t
tostruct_null(ARGS_TOSTRUCT) {
dns_rdata_null_t *null = target;
isc_region_t r;
REQUIRE(rdata->type == dns_rdatatype_null);
REQUIRE(null != NULL);
null->common.rdclass = rdata->rdclass;
null->common.rdtype = rdata->type;
ISC_LINK_INIT(&null->common, link);
dns_rdata_toregion(rdata, &r);
null->length = r.length;
null->data = mem_maybedup(mctx, r.base, r.length);
null->mctx = mctx;
return (ISC_R_SUCCESS);
}
static inline void
freestruct_null(ARGS_FREESTRUCT) {
dns_rdata_null_t *null = source;
REQUIRE(null != NULL);
REQUIRE(null->common.rdtype == dns_rdatatype_null);
if (null->mctx == NULL) {
return;
}
if (null->data != NULL) {
isc_mem_free(null->mctx, null->data);
}
null->mctx = NULL;
}
static inline isc_result_t
additionaldata_null(ARGS_ADDLDATA) {
REQUIRE(rdata->type == dns_rdatatype_null);
UNUSED(rdata);
UNUSED(owner);
UNUSED(add);
UNUSED(arg);
return (ISC_R_SUCCESS);
}
static inline isc_result_t
digest_null(ARGS_DIGEST) {
isc_region_t r;
REQUIRE(rdata->type == dns_rdatatype_null);
dns_rdata_toregion(rdata, &r);
return ((digest)(arg, &r));
}
static inline bool
checkowner_null(ARGS_CHECKOWNER) {
REQUIRE(type == dns_rdatatype_null);
UNUSED(name);
UNUSED(type);
UNUSED(rdclass);
UNUSED(wildcard);
return (true);
}
static inline bool
checknames_null(ARGS_CHECKNAMES) {
REQUIRE(rdata->type == dns_rdatatype_null);
UNUSED(rdata);
UNUSED(owner);
UNUSED(bad);
return (true);
}
static inline int
casecompare_null(ARGS_COMPARE) {
return (compare_null(rdata1, rdata2));
}
#endif /* RDATA_GENERIC_NULL_10_C */