mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-28 21:17:54 +00:00
The current isc_hp API uses internal tid_v variable that gets incremented for each new thread using hazard pointers. This tid_v variable is then used as a index to global shared table with hazard pointers state. Since the tid_v is only incremented and never decremented the table could overflow very quickly if we create set of threads for short period of time, they finish the work and cease to exist. Then we create identical set of threads and so on and so on. This is not a problem for a normal `named` operation as the set of threads is stable, but the problematic place are the unit tests where we test network manager or other APIs (task, timer) that create threads. This commits adds a thin wrapper around any function called from isc_thread_create() that adds unique-but-reusable small digit thread id that can be used as index to f.e. hazard pointer tables. The trampoline wrapper ensures that the thread ids will be reused, so the highest thread_id number doesn't grow indefinitely when threads are created and destroyed and then created again. This fixes the hazard pointer table overflow on machines with many cores. [GL #2396]
190 lines
5.1 KiB
C
190 lines
5.1 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
/*! \file */
|
|
|
|
#include <inttypes.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <isc/mem.h>
|
|
#include <isc/mutex.h>
|
|
#include <isc/once.h>
|
|
#include <isc/thread.h>
|
|
#include <isc/util.h>
|
|
|
|
#include "trampoline_p.h"
|
|
|
|
#define ISC__TRAMPOLINE_UNUSED 0
|
|
|
|
struct isc__trampoline {
|
|
int tid; /* const */
|
|
isc_thread_t self;
|
|
isc_threadfunc_t start;
|
|
isc_threadarg_t arg;
|
|
};
|
|
|
|
static isc_once_t isc__trampoline_initialize_once = ISC_ONCE_INIT;
|
|
static isc_once_t isc__trampoline_shutdown_once = ISC_ONCE_INIT;
|
|
static isc_mutex_t isc__trampoline_lock;
|
|
static isc__trampoline_t **trampolines;
|
|
thread_local size_t isc_tid_v = SIZE_MAX;
|
|
static size_t isc__trampoline_min = 1;
|
|
static size_t isc__trampoline_max = 65;
|
|
|
|
/*
|
|
* We can't use isc_mem API here, because it's called too
|
|
* early and when the isc_mem_debugging flags are changed
|
|
* later and ISC_MEM_DEBUGSIZE or ISC_MEM_DEBUGCTX flags are
|
|
* added, neither isc_mem_put() nor isc_mem_free() can be used
|
|
* to free up the memory allocated here because the flags were
|
|
* not set when calling isc_mem_get() or isc_mem_allocate()
|
|
* here.
|
|
*
|
|
* Actually, since this is a single allocation at library load
|
|
* and deallocation at library unload, using the standard
|
|
* allocator without the tracking is fine for this purpose.
|
|
*/
|
|
static isc__trampoline_t *
|
|
isc__trampoline_new(int tid, isc_threadfunc_t start, isc_threadarg_t arg) {
|
|
isc__trampoline_t *trampoline = calloc(1, sizeof(*trampoline));
|
|
RUNTIME_CHECK(trampoline != NULL);
|
|
|
|
*trampoline = (isc__trampoline_t){
|
|
.tid = tid,
|
|
.start = start,
|
|
.arg = arg,
|
|
.self = ISC__TRAMPOLINE_UNUSED,
|
|
};
|
|
|
|
return (trampoline);
|
|
}
|
|
|
|
static void
|
|
trampoline_initialize(void) {
|
|
isc_mutex_init(&isc__trampoline_lock);
|
|
|
|
trampolines = calloc(isc__trampoline_max, sizeof(trampolines[0]));
|
|
RUNTIME_CHECK(trampolines != NULL);
|
|
|
|
/* Get the trampoline slot 0 for the main thread */
|
|
trampolines[0] = isc__trampoline_new(0, NULL, NULL);
|
|
trampolines[0]->self = isc_thread_self();
|
|
isc_tid_v = trampolines[0]->tid;
|
|
|
|
/* Initialize the other trampolines */
|
|
for (size_t i = 1; i < isc__trampoline_max; i++) {
|
|
trampolines[i] = NULL;
|
|
}
|
|
isc__trampoline_min = 1;
|
|
}
|
|
|
|
void
|
|
isc__trampoline_initialize(void) {
|
|
isc_result_t result = isc_once_do(&isc__trampoline_initialize_once,
|
|
trampoline_initialize);
|
|
RUNTIME_CHECK(result == ISC_R_SUCCESS);
|
|
}
|
|
|
|
static void
|
|
trampoline_shutdown(void) {
|
|
/*
|
|
* When the program using the library exits abruptly and the library
|
|
* gets unloaded, there might be some existing trampolines from unjoined
|
|
* threads. We intentionally ignore those and don't check whether all
|
|
* trampolines have been cleared before exiting.
|
|
*/
|
|
free(trampolines[0]);
|
|
free(trampolines);
|
|
trampolines = NULL;
|
|
isc_mutex_destroy(&isc__trampoline_lock);
|
|
}
|
|
|
|
void
|
|
isc__trampoline_shutdown(void) {
|
|
isc_result_t result = isc_once_do(&isc__trampoline_shutdown_once,
|
|
trampoline_shutdown);
|
|
RUNTIME_CHECK(result == ISC_R_SUCCESS);
|
|
}
|
|
|
|
isc__trampoline_t *
|
|
isc__trampoline_get(isc_threadfunc_t start, isc_threadarg_t arg) {
|
|
isc__trampoline_t **tmp = NULL;
|
|
isc__trampoline_t *trampoline = NULL;
|
|
LOCK(&isc__trampoline_lock);
|
|
again:
|
|
for (size_t i = isc__trampoline_min; i < isc__trampoline_max; i++) {
|
|
if (trampolines[i] == NULL) {
|
|
trampoline = isc__trampoline_new(i, start, arg);
|
|
trampolines[i] = trampoline;
|
|
isc__trampoline_min = i + 1;
|
|
goto done;
|
|
}
|
|
}
|
|
tmp = calloc(2 * isc__trampoline_max, sizeof(trampolines[0]));
|
|
RUNTIME_CHECK(tmp != NULL);
|
|
for (size_t i = 0; i < isc__trampoline_max; i++) {
|
|
tmp[i] = trampolines[i];
|
|
}
|
|
for (size_t i = isc__trampoline_max; i < 2 * isc__trampoline_max; i++) {
|
|
tmp[i] = NULL;
|
|
}
|
|
free(trampolines);
|
|
trampolines = tmp;
|
|
isc__trampoline_max = isc__trampoline_max * 2;
|
|
goto again;
|
|
done:
|
|
INSIST(trampoline != NULL);
|
|
UNLOCK(&isc__trampoline_lock);
|
|
|
|
return (trampoline);
|
|
}
|
|
|
|
static void
|
|
trampoline_put(isc__trampoline_t *trampoline) {
|
|
LOCK(&isc__trampoline_lock);
|
|
REQUIRE(trampoline->tid > 0 &&
|
|
(size_t)trampoline->tid < isc__trampoline_max);
|
|
REQUIRE(trampoline->self == isc_thread_self());
|
|
REQUIRE(trampolines[trampoline->tid] == trampoline);
|
|
|
|
trampolines[trampoline->tid] = NULL;
|
|
|
|
if (isc__trampoline_min > (size_t)trampoline->tid) {
|
|
isc__trampoline_min = trampoline->tid;
|
|
}
|
|
|
|
free(trampoline);
|
|
|
|
UNLOCK(&isc__trampoline_lock);
|
|
return;
|
|
}
|
|
|
|
isc_threadresult_t
|
|
isc__trampoline_run(isc_threadarg_t arg) {
|
|
isc__trampoline_t *trampoline = (isc__trampoline_t *)arg;
|
|
isc_threadresult_t result;
|
|
|
|
REQUIRE(trampoline->tid > 0 &&
|
|
(size_t)trampoline->tid < isc__trampoline_max);
|
|
REQUIRE(trampoline->self == ISC__TRAMPOLINE_UNUSED);
|
|
|
|
/* Initialize the trampoline */
|
|
isc_tid_v = trampoline->tid;
|
|
trampoline->self = isc_thread_self();
|
|
|
|
/* Run the main function */
|
|
result = (trampoline->start)(trampoline->arg);
|
|
|
|
trampoline_put(trampoline);
|
|
|
|
return (result);
|
|
}
|