From 095b3e84b7cd6eee677586ae772471dfce17d0f7 Mon Sep 17 00:00:00 2001 From: Radostin Stoyanov Date: Wed, 23 Nov 2022 14:59:08 +0000 Subject: [PATCH] ci/lint: install ShellCheck with dnf The way ShellCheck is installed was changed in commit c056f99 (ci/gha/lint: install a recent shellcheck) to use the latest version v0.8.0 and remove some of the "shellcheck disable=..." annotations. Since then, Fedora 37 has been released and the ShellCheck package has been updated to v0.8.0. Signed-off-by: Radostin Stoyanov --- .github/workflows/lint.yml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3d42f3dcf..4c05285e6 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,18 +9,7 @@ jobs: image: registry.fedoraproject.org/fedora:latest steps: - name: Install tools - run: sudo dnf -y install git make python3-flake8 xz clang-tools-extra which codespell git-clang-format - - # TODO: remove this and use ShellCheck from repo once F37 with ShellCheck 0.8.0 is out. - - name: install shellcheck - env: - VERSION: v0.8.0 - BASEURL: https://github.com/koalaman/shellcheck/releases/download - SHA256: f4bce23c11c3919c1b20bcb0f206f6b44c44e26f2bc95f8aa708716095fa0651 - run: | - curl -sSfL --retry 5 $BASEURL/$VERSION/shellcheck-$VERSION.linux.x86_64.tar.xz | - tar xfJ - -C /usr/local/bin --strip 1 shellcheck-$VERSION/shellcheck - sha256sum --strict --check - <<<"$SHA256 /usr/local/bin/shellcheck" + run: sudo dnf -y install git make python3-flake8 xz clang-tools-extra which codespell git-clang-format ShellCheck - uses: actions/checkout@v2