mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-08-30 13:58:34 +00:00
Code Issues Releases Wiki Activity

zdtm/cgroup_ifpriomap: Fix Coverity warning

Browse Source 
*** CID 185302:  Null pointer dereferences  (NULL_RETURNS)
/test/zdtm/static/cgroup_ifpriomap.c: 107 in read_one_priomap()
>>>     Dereferencing a pointer that might be null "out->ifname" when calling "strncpy".

There is also a warning about using rand(), but..
Not sure that we need to entangle everything just for pleasing Coverity:
>>>     CID 185301:  Security best practices violations  (DC.WEAK_CRYPTO)
>>>     "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
Leaving that as-is and marking in Coverity as WONTFIX.

Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
This commit is contained in:
Dmitry Safonov 2018-02-11 14:00:52 +00:00 committed by Andrei Vagin
parent 1406eb92a1
commit 3a35c7fd86
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/zdtm/static/cgroup_ifpriomap.c
View File

@ -104,6 +104,11 @@ static int read_one_priomap(char *prop_line, struct ifpriomap_t *out)
len = space - prop_line;
out->ifname = malloc(len + 1);
if (!out->ifname) {
pr_perror("malloc() failed\n");
return -1;
}
strncpy(out->ifname, prop_line, len);
out->ifname[len] = '\0'; /* poor man's strlcpy() */
out->prio = (uint32_t)strtol(space + 1, NULL, 10);