From 485a83c110bef1b2700acec0bd63bad4518aa62f Mon Sep 17 00:00:00 2001 From: "fu.lin" Date: Fri, 17 Sep 2021 17:16:48 +0800 Subject: [PATCH] tty: fix the null pointer of get_tty_driver v2: split error checking from index variable initialization v3: use PRIx64 for printing dev_t Signed-off-by: fu.lin Signed-off-by: Pavel Tikhomirov --- criu/tty.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/criu/tty.c b/criu/tty.c index 1598ad956..1462193c5 100644 --- a/criu/tty.c +++ b/criu/tty.c @@ -1977,6 +1977,12 @@ static int dump_one_tty(int lfd, u32 id, const struct fd_parms *p) pr_info("Dumping tty %d with id %#x\n", lfd, id); driver = get_tty_driver(p->stat.st_rdev, p->stat.st_dev); + if (driver == NULL) { + pr_err("Unable to find a tty driver (rdev %#" PRIx64 " dev %#" PRIx64 ")\n", p->stat.st_rdev, + p->stat.st_dev); + return -1; + } + if (driver->fd_get_index) index = driver->fd_get_index(lfd, p); else