mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-09-01 14:55:39 +00:00
Code Issues Releases Wiki Activity

page-pipe: Resize up to PIPE_MAX_SIZE

Browse Source 
When performing pre-dump we continuously increase the page-pipe size to
fit the max amount memory pages in the pipe's buffer. However, we never
actually set the pipe's buffer size to max. By doing so, we can reduce
the number of pipe-s necessary for pre-dump and improve the performance
as shown in the example below.

For example, let's consider the following process:

	#include <stdio.h>
	#include <stdlib.h>
	#include <unistd.h>

	void main(void)
	{
		int i = 0;
		void *cache = calloc(1, 1024 * 1024 * 1024);
		while(1) {
			printf("%d\n", i++);
			sleep(1);
		}
	}

stats-dump before this change:

	frozen_time: 123538
	memdump_time: 95344
	memwrite_time: 11980078
	pages_scanned: 262721
	pages_written: 262169
	page_pipes: 513
	page_pipe_bufs: 519

stats-dump after this change:

	frozen_time: 83287
	memdump_time: 54587
	memwrite_time: 12547466
	pages_scanned: 262721
	pages_written: 262169
	page_pipes: 257
	page_pipe_bufs: 263

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
This commit is contained in:
Radostin Stoyanov
2019-09-28 06:59:45 +01:00
committed by Andrei Vagin
parent 71c2a9dc73
commit 5a92f100b8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
criu/page-pipe.c
View File

@@ -54,8 +54,12 @@ static inline int ppb_resize_pipe(struct page_pipe_buf *ppb)
if (ppb->pages_in + ppb->pipe_off < ppb->pipe_size) if (ppb->pages_in + ppb->pipe_off < ppb->pipe_size)
return 0; return 0;
if (new_size > PIPE_MAX_SIZE) if (new_size > PIPE_MAX_SIZE) {
return 1; if (ppb->pipe_size < PIPE_MAX_SIZE)
ppb->pipe_size = PIPE_MAX_SIZE;
else
return 1;
}
ret = __ppb_resize_pipe(ppb, new_size); ret = __ppb_resize_pipe(ppb, new_size);
if (ret < 0) if (ret < 0)