From ad6db8332b1ee9c6077db703c5572f96dbdd0ad4 Mon Sep 17 00:00:00 2001 From: Libo Chen Date: Thu, 16 May 2013 21:00:43 +0800 Subject: [PATCH] mountns: potential fd leak when readlinkat call when mntns_collect_root->readlinkat call faild, we should close pdf Signed-off-by: Libo Chen Signed-off-by: Pavel Emelyanov --- mount.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mount.c b/mount.c index d30bbfae1..66e263c1f 100644 --- a/mount.c +++ b/mount.c @@ -787,8 +787,10 @@ int mntns_collect_root(pid_t pid) pfd = open_pid_proc(pid); ret = readlinkat(pfd, "root", path, sizeof(path) - 1); - if (ret < 0) + if (ret < 0){ + close_pid_proc(); return ret; + } path[ret] = '\0';