mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-08-30 13:58:34 +00:00
Code Issues Releases Wiki Activity

ptrace: Be more verbose on seize failure

Browse Source 
The ptrace seize may fail for various reasons. E.g. -- no enough perms
to get the ptrace access to the tasks, or various selinux restrictions.

Print what exactly has happened when ptrace failed.

Reported-by: Kevin Wilson <wkevils@gmail.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Pavel Emelyanov
2013-03-26 22:03:15 +04:00
parent 7571ff69e1
commit b6fa2b31a7
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ptrace.c
View File

@@ -48,10 +48,11 @@ int seize_task(pid_t pid, pid_t ppid, pid_t *pgid, pid_t *sid)
{ {
siginfo_t si; siginfo_t si;
int status; int status;
int ret, ret2; int ret, ret2, ptrace_errno;
struct proc_pid_stat_small ps; struct proc_pid_stat_small ps;
ret = ptrace(PTRACE_SEIZE, pid, NULL, 0); ret = ptrace(PTRACE_SEIZE, pid, NULL, 0);
ptrace_errno = errno;
/* /*
* It's ugly, but the ptrace API doesn't allow to distinguish * It's ugly, but the ptrace API doesn't allow to distinguish
@@ -71,8 +72,8 @@ int seize_task(pid_t pid, pid_t ppid, pid_t *pgid, pid_t *sid)
if (ret < 0) { if (ret < 0) {
if (ps.state != 'Z') { if (ps.state != 'Z') {
pr_err("Unseizeable non-zombie %d found, state %c\n", pr_err("Unseizeable non-zombie %d found, state %c, err %d/%d\n",
pid, ps.state); pid, ps.state, ret, ptrace_errno);
return -1; return -1;
} }