mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-08-30 05:48:05 +00:00
Code Issues Releases Wiki Activity

zdtm/cwd01: don't forget to set '\0' after readlink()

Browse Source 
Reported-by: Konstantin Neumoin <kneumoin@parallels.com>
Cc: Konstantin Neumoin <kneumoin@parallels.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This commit is contained in:
Andrey Vagin 2014-09-22 19:48:00 +04:00 committed by Pavel Emelyanov
parent 8ac80915e0
commit c7390d2d3f
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/zdtm/live/static/cwd01.c
View File

@ -4,6 +4,7 @@
#include <sys/stat.h>
#include <string.h>
#include <sys/wait.h>
#include <linux/limits.h>
#include "zdtmtst.h"
@ -15,8 +16,8 @@ TEST_OPTION(dirname, string, "directory name", 1);
int main(int argc, char **argv)
{
char cwd0[256], cwd1[256], cwd2[256];
int pid, p[2], aux;
char cwd0[PATH_MAX], cwd1[PATH_MAX], cwd2[PATH_MAX];
int pid, p[2], aux, aux2;
test_init(argc, argv);
@ -57,16 +58,27 @@ int main(int argc, char **argv)
err("can't get cwd: %m\n");
goto cleanup;
}
if (aux == sizeof(cwd1)) {
err("A buffer is too small");
goto cleanup;
}
cwd1[aux] = '\0';
test_daemon();
test_waitsig();
if (readlink("/proc/self/cwd", cwd2, sizeof(cwd2)) < 0) {
aux2 = readlink("/proc/self/cwd", cwd2, sizeof(cwd2));
if (aux2 < 0) {
fail("can't get cwd: %m\n");
goto cleanup;
}
if (aux2 == sizeof(cwd2)) {
err("A buffer is too small");
goto cleanup;
}
cwd2[aux2] = '\0';
/* FIXME -- criu adds a suffix to removed cwd */
if (strncmp(cwd1, cwd2, aux))