mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-08-22 01:51:51 +00:00
Code Issues Releases Wiki Activity

lib: do not set protobuf has_* field too early

Browse Source 
For two cases libcriu was setting the RPC protobuf field `has_*` before
checking if the given parameter is valid. This can lead to situations,
if the caller doesn't check the return value, that we pass as RPC struct
to CRIU which has the `has_*` protobuf field set to true, but does not
have a verified value (or non at all) set for the actual RPC entry.

Signed-off-by: Adrian Reber <areber@redhat.com>
This commit is contained in:
Adrian Reber 2024-12-19 10:33:54 +00:00 committed by Andrei Vagin
parent 82b03429b7
commit e2dffcbc8e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/c/criu.c
View File

@ -352,8 +352,8 @@ int criu_set_parent_images(const char *path)
int criu_local_set_pre_dump_mode(criu_opts *opts, enum criu_pre_dump_mode mode)
{
opts->rpc->has_pre_dump_mode = true;
if (mode == CRIU_PRE_DUMP_SPLICE || mode == CRIU_PRE_DUMP_READ) {
opts->rpc->has_pre_dump_mode = true;
opts->rpc->pre_dump_mode = (CriuPreDumpMode)mode;
return 0;
}
@ -1867,8 +1867,8 @@ void criu_set_pidfd_store_sk(int sk)
int criu_local_set_network_lock(criu_opts *opts, enum criu_network_lock_method method)
{
opts->rpc->has_network_lock = true;
if (method == CRIU_NETWORK_LOCK_IPTABLES || method == CRIU_NETWORK_LOCK_NFTABLES || method == CRIU_NETWORK_LOCK_SKIP) {
opts->rpc->has_network_lock = true;
opts->rpc->network_lock = (CriuNetworkLockMethod)method;
return 0;
}