mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-09-01 14:55:39 +00:00
Code Issues Releases Wiki Activity

inotify_system tests: fix for clang

Browse Source 
When compiling with clang, it complains like this:

> clang -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0  -iquote ../lib/arch/x86/include -I../lib   inotify_system.c ../lib/libzdtmtst.a ../lib/libzdtmtst.a -o inotify_system
> inotify_system.c:323:50: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
>         if ((common_desc.inot < 0) || (common_desc.file < 0) || \
>                                        ~~~~~~~~~~~~~~~~ ^ ~
> inotify_system.c:324:21: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
>                         (common_desc.dir < 0) || (common_desc.link < 0)) {
>                          ~~~~~~~~~~~~~~~ ^ ~
> inotify_system.c:324:47: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
>                         (common_desc.dir < 0) || (common_desc.link < 0)) {
>                                                   ~~~~~~~~~~~~~~~~ ^ ~
> 3 errors generated.

Indeed these fields are uint32_t. As they are used to store the results of
inotify_init() and inotify_add_watch() function calls, the type should be int.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
This commit is contained in:
Kir Kolyshkin
2016-10-11 18:46:47 -07:00
committed by Pavel Emelyanov
parent 8f9c6ff529
commit fe21d145de
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/zdtm/static/inotify_system.c
View File

@@ -63,9 +63,9 @@ const char *inot_dir = "./inotify.nodel";
typedef struct { typedef struct {
int inot; int inot;
uint32_t file; int file;
uint32_t link; int link;
uint32_t dir; int dir;
} desc; } desc;
void do_wait() { void do_wait() {

6
test/zdtm/static/inotify_system_nodel.c
View File

@@ -63,9 +63,9 @@ const char *inot_dir = "./inotify.nodel";
typedef struct { typedef struct {
int inot; int inot;
uint32_t file; int file;
uint32_t link; int link;
uint32_t dir; int dir;
} desc; } desc;
void do_wait() { void do_wait() {