mir/isc-dhcp
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-08-22 18:07:25 +00:00
Code Issues Releases Wiki Activity

Allow zero-length client ids when hashing. Ticket 21253

Browse Source
This commit is contained in:
Shawn Routhier 2010-05-14 23:46:59 +00:00
parent 7437807984
commit 1943bbf803
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
RELNOTES
View File

@ -44,6 +44,10 @@ work on other platforms. Please report any problems and suggested fixes to
- Prohibit including lease time information in a response to a DHCP INFORM - Prohibit including lease time information in a response to a DHCP INFORM
Bug ticket 21092. Bug ticket 21092.
! Accept a client id of length 0 while hashing. Previously the server would
exit if it attempted to hash a zero length client id, providing attackers
with a simple denial of service attack. Bug ticket 21253.
Changes since 4.2.0a2 Changes since 4.2.0a2
- Update the fsync code to work with the changes to the DDNS code. It now - Update the fsync code to work with the changes to the DDNS code. It now

12
omapip/hash.c
View File

@ -3,7 +3,8 @@
Routines for manipulating hash tables... */ Routines for manipulating hash tables... */
/* /*
* Copyright (c) 2004-2007,2009 by Internet Systems Consortium, Inc. ("ISC") * Copyright (c) 2009-2010 by Internet Systems Consortium, Inc. ("ISC")
* Copyright (c) 2004-2007 by Internet Systems Consortium, Inc. ("ISC")
* Copyright (c) 1995-2003 by Internet Software Consortium * Copyright (c) 1995-2003 by Internet Software Consortium
* *
* Permission to use, copy, modify, and distribute this software for any * Permission to use, copy, modify, and distribute this software for any
@ -49,8 +50,13 @@ find_length(const void *key,
if (do_hash == do_ip4_hash) if (do_hash == do_ip4_hash)
return 4; return 4;
log_fatal("Impossible condition at %s:%d.", MDL); log_debug("Unexpected hash function at %s:%d.", MDL);
return 0; /* Silence compiler warnings. */ /*
* If we get a hash function we don't specifically expect
* return a length of 0, this covers the case where a client
* id has a length of 0.
*/
return 0;
} }
int new_hash_table (tp, count, file, line) int new_hash_table (tp, count, file, line)