mir/isc-dhcp
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-09-01 06:45:27 +00:00
Code Issues Releases Wiki Activity

add a null check to avoid primary crash on contact with secondary [rt19705]

Browse Source
This commit is contained in:
Paul Selkirk
2009-07-16 19:48:45 +00:00
parent 1b12d9993b
commit d453265fd2
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
RELNOTES
View File

@@ -164,6 +164,10 @@ work on other platforms. Please report any problems and suggested fixes to
supported. Note that, similarly to 3.0.x, for by-code lookups only the supported. Note that, similarly to 3.0.x, for by-code lookups only the
last option definition is used. last option definition is used.
- Fixed a bug where a time difference of greater than 60 seconds between a
failover pair could cause the primary to crash on contact with the
secondary. Thanks to a patch from Steinar Haug.
Changes since 4.1.0b1 Changes since 4.1.0b1
- A missing "else" in dhcrelay.c could have caused an interface not to - A missing "else" in dhcrelay.c could have caused an interface not to

3
server/failover.c
View File

@@ -597,7 +597,8 @@ isc_result_t dhcp_failover_link_signal (omapi_object_t *h,
omapi_signal ((omapi_object_t *)link -> state_object, omapi_signal ((omapi_object_t *)link -> state_object,
"message", link); "message", link);
link -> state = dhcp_flink_message_length_wait; link -> state = dhcp_flink_message_length_wait;
failover_message_dereference (&link -> imsg, MDL); if (link -> imsg)
failover_message_dereference (&link -> imsg, MDL);
/* XXX This is dangerous because we could get into a tight /* XXX This is dangerous because we could get into a tight
XXX loop reading input without servicing any other stuff. XXX loop reading input without servicing any other stuff.
XXX There needs to be a way to relinquish control but XXX There needs to be a way to relinquish control but