mir/isc-dhcp
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-09-04 00:05:30 +00:00
Code Issues Releases Wiki Activity

When attempting to convert a DUID from a client id option

Browse Source 
into a hardware address handle unexpected client ids properly.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29852]
CVE: CVE-2012-3570
This commit is contained in:
Shawn Routhier
2012-06-27 21:33:25 +00:00
parent de87ffe336
commit e563ec2e58
3 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
RELNOTES
View File

@@ -90,6 +90,13 @@ work on other platforms. Please report any problems and suggested fixes to
[ISC-Bugs #29851] [ISC-Bugs #29851]
CVE: CVE-2012-3571 CVE: CVE-2012-3571
! When attempting to convert a DUID from a client id option
into a hardware address handle unexpected client ids properly.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29852]
CVE: CVE-2012-3570
Changes since 4.2.3 Changes since 4.2.3
! Add a check for a null pointer before calling the regexec function. ! Add a check for a null pointer before calling the regexec function.

10
includes/dhcpd.h
View File

@@ -432,11 +432,17 @@ struct packet {
isc_boolean_t unicast; isc_boolean_t unicast;
}; };
/* A network interface's MAC address. */ /*
* A network interface's MAC address.
* 20 bytes for the hardware address
* and 1 byte for the type tag
*/
#define HARDWARE_ADDR_LEN 20
struct hardware { struct hardware {
u_int8_t hlen; u_int8_t hlen;
u_int8_t hbuf[21]; u_int8_t hbuf[HARDWARE_ADDR_LEN + 1];
}; };
#if defined(LDAP_CONFIGURATION) #if defined(LDAP_CONFIGURATION)

2
server/dhcpv6.c
View File

@@ -6037,7 +6037,7 @@ find_hosts_by_duid_chaddr(struct host_decl **host,
break; break;
} }
if (hlen == 0) if ((hlen == 0) || (hlen > HARDWARE_ADDR_LEN))
return 0; return 0;
/* /*