2
0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-08-22 09:57:20 +00:00

175 Commits

Author SHA1 Message Date
Thomas Markwalder
9e138021c8 [#254] Fixed memory leak in FQDN unpacking
RELNOTES
    Added a release note

common/options.c
    fqdn_universe_decode() - replace returns with
    gotos to ensure memory is freed on label length
    errors
2022-11-01 15:42:56 +00:00
Thomas Markwalder
97074fadd1 [#253] Fix reference count leak in add_option
RELNOTES
    Added release note

common/options.c
    add_option() - always dereference the looked up option

common/tests/option_unittest.c
    Added new unit test: ATF_TC_BODY(add_option_ref_cnt, tc)
2022-11-01 15:42:56 +00:00
Wlodek Wencel
49a7fb582d copy rights update 2022-01-25 16:24:16 +01:00
Tomek Mrugalski
f6b8f48d16 [#189] Whitespace fixes in opened files 2022-01-20 12:04:28 +01:00
Tomek Mrugalski
429a56d73c [#189] ISC address updated 2022-01-20 12:04:28 +01:00
Thomas Markwalder
9a2f9db55f [master] Implement and use new option format type 'k'
Merges in #68.
2019-12-17 13:59:24 -05:00
Thomas Markwalder
82e0ea5760 [master] Pre-release tag prep for 4.4.2b1: version #, copyright etc...
Changes to be committed:
	modified:   LICENSE
	modified:   README
	modified:   RELNOTES
	modified:   client/dhclient.8
	modified:   common/options.c
	modified:   configure
	modified:   configure.ac
	modified:   configure.ac+lt
	modified:   configure.ac-base
	modified:   configure.ac-lt
	modified:   keama/confparse.c
	modified:   keama/keama.8
	modified:   keama/keama.c
	modified:   keama/keama.h
	modified:   keama/options.c
	modified:   keama/parse.c
	modified:   server/dhcpd.c
	modified:   util/bind.sh
2019-12-11 12:24:01 -05:00
Thomas Markwalder
0cd94b5ef4 [#64,!35] Restored work
Restored cummulative work.
2019-11-22 13:39:45 -05:00
Thomas Markwalder
c5931725b4 [master] Correct buffer overrun in pretty_print_option
Merges in rt47139.
2018-02-10 12:15:27 -05:00
Thomas Markwalder
197b26f253 [master] Corrected refcnt loss in option parsing
Merges in 47140.
2018-02-09 14:46:08 -05:00
Thomas Markwalder
60882b8aa5 [master] Restores ability of server to return dhcp6.vendor-opts to client
Merges in rt46427.
2017-12-07 09:50:55 -05:00
Thomas Markwalder
2d542e1ecf [master] Ignore empty host name option when parsing v4 packets
Merges in rt43786
2017-11-27 13:50:02 -05:00
Thomas Markwalder
7512d88b9f [master] Replaced licensing text with MPL licensing text throughout 2017-07-12 09:23:23 -04:00
Thomas Markwalder
30afd7dbfa [master] Removed obsolete source directory minires.
Merges in rt45471.
2017-06-29 08:50:56 -04:00
tmarkwalder
2f5fefd3a8 [master] v6 FQDN option unpacking now handles values with spaces and non-printables
Merged in rt43592.
2017-05-03 08:42:22 -04:00
Shawn Routhier
0ee00c5b48 [master] Include the raw data from a fully encapsualted option in the cache 2016-08-10 20:28:28 -07:00
Shawn Routhier
e105afa15e [master] Add support for sending encapsulated v6 options from the server
Even if there was a definition for an ecncapsulated v6 option
and a set of values for it the v6 server wouldn't add it to
the outgoing packet.  This patch updates the server to do so.
2016-06-03 11:24:48 -07:00
Shawn Routhier
84ee63a06b [master] Add a call to dereference the packet structure if the deocding fails
Squashed commit of the following:

commit 7d61e40149676f989667cac90d9c3b6f5b63ac6b
Author: Shawn Routhier <sar@isc.org>
Date:   Tue Feb 23 11:31:27 2016 -0800

    [rt41774] Add a call to dereference the packet structure if the deocding fails
2016-02-23 12:16:19 -08:00
Francis Dupont
785c1a519e Merged rt35711c (DHCPv4-over-DHCPv6 support) 2016-02-23 10:40:10 +01:00
Thomas Markwalder
45086eef45 [master] Fixed several minor Coverity issues
Merges in rt35144.
2016-02-18 11:21:42 -05:00
Shawn Routhier
45c332f037 [master] Add code to parse a vendor option as directed by the user.
Add code to parse a vendor option.  It is structured as an action
in the config language.  When the statement is executed it attempts
to find a vendor option in the packet and a vendor option space
specified by the admin for use with that packet.  It then calls
the proper parse routine to do the parsing.
2015-07-13 12:06:50 -07:00
Thomas Markwalder
2731a82c83 [master] Updated build to accomodate new unit tests in common
Merges in rt20558_b.
2014-12-05 15:47:38 -05:00
Thomas Markwalder
04daf4fe4b [master] Fixed concatenation of "Dc" formatted options such as domain-search
Merges in rt20558.
2014-11-25 15:22:52 -05:00
Thomas Markwalder
0a7e1a8ab0 [master] Add use-host-decl-names support to BOOTP
Merges in rt36233.
2014-10-27 14:51:20 -04:00
Thomas Markwalder
e046c82621 [master] Added echo-client-id server parameter
Merges in rt35958 which includes fix for rt32545
    Also updated dhcp/.gitignore
2014-10-17 07:56:01 -04:00
Thomas Markwalder
a07d99bbef [master] Corrects medium impact issues reported by Coverity.
Merges in rt36933
2014-08-28 08:12:30 -04:00
Shawn Routhier
250f7134bb [master] Add support for pool thresholds
Add support to set high and low thresholds for pools for
v4 and v6.  A message will be emitted when the usage of
the pool first exceeds the high threshold.  More messages
will be skipped until the usage has gone below the low
threshold and then back above the high threshold.
2014-06-05 14:55:01 -07:00
Shawn Routhier
1be2ba154d [master] Correct ordering for subnet mask and router and overload vs relay option
Conflicts:
	RELNOTES
2014-04-28 16:15:36 -07:00
Shawn Routhier
edad9be5cd [master] Remove vix.com and nominum.com
Remove old information from copyrights and
    man pages.
2014-01-26 10:52:15 -08:00
Shawn Routhier
0f750c4fb1 [master]
[rt23833]
Clean up a number of items identified by the Coverity
static analysis tool.  Runs courtesy of Red Hat.
2012-10-16 15:05:24 -07:00
Shawn Routhier
67b2cb451b [master]
Update the memory leakage debug code to work with v6.
2012-09-19 14:27:44 -07:00
Shawn Routhier
3bedb11744 [rt30024] This is a commit message
Fix a pair of memory leaks.
2012-07-11 14:50:35 -07:00
Shawn Routhier
de87ffe336 Previously the server code was relaxed to allow packets with zero
length client ids to be processed.  Under some situations use of
zero length client ids can cause the server to go into an infinite
loop.  As such ids are not valid according to RFC 2132 section 9.14
the server no longer accepts them.  Client ids with a length of 1
are also invalid but the server still accepts them in order to
minimize disruption.  The restriction will likely be tightened in
the future to disallow ids with a length of 1.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29851]
CVE: CVE-2012-3571
2012-06-27 21:20:19 +00:00
Shawn Routhier
35de6c8c24 Fix some issues in the code for parsing and printing options.
[ISC-Bugs #22625] - properly print options that have several fields
followed by an array of something for example "fIa"
[ISC-Bugs #27289] - properly parse options in declarations that have
several fields followed by an array of something for example "fIa"
[ISC-Bugs #27296] - properly determine if we parsed a 16 or 32 bit
value in evaluate_numeric_expression (extract-int).
[ISC-Bugs #27314] - properly parse a zero length option from
a lease file.  Thanks to Marius Tomaschewski from SUSE for the report
and prototype patch for this ticket as well as ticket 27289.
2012-06-06 22:50:31 +00:00
Shawn Routhier
b342f2e77c Use offsetof() instead of sizeof() to get the sizes for dhcpv6_relay_packet
and dhcpv6_packet in several more places.  Thanks to a report from
Bruno Verstuyft and Vincent Demaertelaere of Excentis.
[ISC-Bugs #27941]
2012-03-20 00:31:34 +00:00
Tomek Mrugalski
dd9237c309 Fixed many compilation problems ("set, but not used" warnings) for
gcc 4.6 that may affect Ubuntu 11.10 users. [ISC-Bugs #27588]
2012-03-09 11:18:14 +00:00
Shawn Routhier
8bd96ccb21 Two packets were found that cause a server to halt. The code
has been updated to properly process or reject the packets as
appropriate.  Thanks to David Zych at University of Illinois
for reporting this issue.  [ISC-Bugs #24960]
One CVE number for each class of packet.
CVE-2011-2748
CVE-2011-2749
2011-07-19 22:13:26 +00:00
Shawn Routhier
c850c0eec5 Restore common/discover.c, common/options.c and server/dhcp.c
as I mistakenly committed them to head instead of the ticket
branch.
2011-07-02 00:05:35 +00:00
Shawn Routhier
640101e3d3 Correct an unsigned math operation when calculating the options
buffer space for bootp and use a better constant - DHCP packet
size instead of DHCP packet size + udp and iP headers.
Check that we have a packet->options structure before using it.
Only process packets that are longer than a bootp fixed packet
including server and file names.  Previously we allowed for
shorter packets but that wasn't working and nobody noticed.
2011-07-01 23:11:53 +00:00
Shawn Routhier
bea1769742 In dhclient check the data for some string options for
reasonableness before passing it along to the script that
interfaces with the OS. [ISC-Bugs #23722]
2011-03-24 21:11:01 +00:00
Shawn Routhier
1e05d095c2 Don't include lease time information in the response to a DHCPINFORM
request.  We do this by removing any time information from the option
cache before building the reponse packet.  Bug ticket 21092.
2010-04-20 23:20:20 +00:00
Shawn Routhier
a35285748d Clean up some compiler warnings 2010-02-02 00:44:06 +00:00
Shawn Routhier
a47d63362f Update copyright years 2009-11-24 02:06:57 +00:00
David Hankins
5a671e8715 *** empty log message *** 2009-09-11 18:13:12 +00:00
Shawn Routhier
2c85ac9b24 Switch isc urls from http to https and correct sw to services or software
for new web site as appropirate.
2009-07-23 18:52:21 +00:00
David Hankins
f4534b17fa - Fixed a cosmetic bug where pretty-printing valid domain-search options would
result in an erroneous error log message ('garbage in format string').
  [ISC-Bugs #19327]
2009-03-10 20:54:02 +00:00
David Hankins
47e6eb82cb - The notorious 'option <unknown> ... larger than buffer' log line,
which is seen in some malformed DHCP client packets, was modified.
  It now logs the universe name, and does not log the length values
  (which are bogus corruption read from the packet anyway).  It also
  carries a hopefully more useful explanation. [ISC-Bugs #18241]
2009-01-07 19:54:06 +00:00
Evan Hunt
535485df4e The server wasn't always sending the FQDN option when it should. [rt18237] 2008-07-19 03:57:23 +00:00
Evan Hunt
20210a7bfc Clients that sent a parameter request list containing the routers option
before the subnet mask option were receiving only the latter. [rt18133]
2008-07-19 01:11:40 +00:00
Evan Hunt
7de20a9518 - Merge dhcrelay6 into dhcrelay
- Prep for 4.1.0a2 release
2008-06-13 00:55:53 +00:00