2
0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-08-28 21:07:43 +00:00

604 Commits

Author SHA1 Message Date
Mark Andrews
a24b9f23d0 - Use newer auto* tool packages and turn on RFC_3542 support on Mac OS.
[ISC-Bugs #26303]
2013-03-28 17:11:06 +11:00
Shawn Routhier
c5bc8b1a37 [master]
When checking to see if atf is available also check the
lib64 directory.
[rt32206]
2013-01-16 12:31:13 -08:00
Shawn Routhier
56c0e68182 [master]
Add ticket number to comment
2012-12-13 11:38:06 -08:00
Shawn Routhier
b89b8e1628 -n [master]
Clean up ATF issues:
describe patch to ATF code for solaris 11
remove unneeded options for use on solaris 11
comment out unused hash test
[rt32089]
2012-12-13 11:29:35 -08:00
Shawn Routhier
d5d868e726 [master]
Update per comments from sanity check
2012-12-12 16:41:04 -08:00
Shawn Routhier
8acc987b9e [master]
Remove unused variable.
[ISC-Bugs #31983]
2012-11-28 12:55:32 -08:00
Shawn Routhier
1e2a127bfe [master]
[rt31231]
Check the status when trying to read from a connection
and don't ask for more if we seem to have a closed
connection.
[ISC-Bugs #31231]
2012-11-26 12:14:27 -08:00
Shawn Routhier
9ff4e0a221 [master]
Move the dhclient.conf and dhcpd.conf files to *.example
to avoid overwriting them during installation.
2012-11-19 11:42:38 -08:00
Shawn Routhier
0d93c339de [master]
Tidy up some compiler issues in the debug code
[ISC-Bugs #26460]
2012-11-16 17:02:03 -08:00
Shawn Routhier
f8380d3ff2 [master]
+- Add support for a simple check that the server id in a request message
+  to a failover peer matches the server id of the server.  This support
+  is enabled by editing the file includes/site.h and uncommenting the
+  definition for SERVER_ID_CHECK.  The option has several restrictions
+  and issues - please read the comment in the site.h file before
+  enabling it.
+  [ISC-Bugs #31463]
2012-11-16 15:02:13 -08:00
Shawn Routhier
3aa562f8ad [master]
Add rt number to comment
2012-11-13 12:58:32 -08:00
Shawn Routhier
10613724a9 [master]
The client now passes information about the options it requested
from the server to the script code via environment variables.
These variables are of the form requested_<option_name>=1 with
the option name being the same as used in the new_* and old_*
variables. [ISC-Bugs #29068]
2012-11-13 12:56:02 -08:00
Shawn Routhier
d56788df77 [master]
Modify the nak_lease function to make some attempts to find a
server-identifier option to use for the NAK.
2012-11-02 16:37:03 -07:00
Shawn Routhier
962d5eab9b [master]
[ISC-Bugs #23048]
Parsing unquoted base64 strings improved. Parser now properly handles
strings that contain reserved names.
2012-10-23 12:08:30 -07:00
Shawn Routhier
0f750c4fb1 [master]
[rt23833]
Clean up a number of items identified by the Coverity
static analysis tool.  Runs courtesy of Red Hat.
2012-10-16 15:05:24 -07:00
Shawn Routhier
dbd6551769 [master]
[ISC-Bugs #26108]
Add a compile time option, enable-secs-byteorder, to deal with
clients that do the byte ordering on the secs field incorrectly.
This field should be in network byte order but some clients
get it wrong.  When this option is enabled the server will examine
the secs field and if it looks wrong (high byte non zero and low
byte zero) swap the bytes.  The default is disabled.  This option
is only useful when doing load balancing within failover.
2012-10-11 14:30:24 -07:00
Shawn Routhier
30e4232753 [master]
[rt30320]
When processing a failover request with an unexpected name
create an option block the relationship_name instead of using
the one from the incoming message.  This avoids problems when
the option is freed.

Also add code to free the relationship_name from the incoming
mesasage when we free the message.
2012-10-09 14:08:26 -07:00
Shawn Routhier
74977c9456 [master]
Relax the requirements for deleting an A or AAAA record.
Previously the DDNS removal code required both the A or AAAA
record and the TXT record to exist.  This requirement could
cause problems if something interrupted the removal leaving
the TXT record alone.  This relaxation was codified in RFC 4703.
[ISC-Bugs #30734]
2012-10-09 13:28:14 -07:00
Shawn Routhier
67b2cb451b [master]
Update the memory leakage debug code to work with v6.
2012-09-19 14:27:44 -07:00
Shawn Routhier
03b44855b1 -n [master]
Correct a typo
2012-08-17 14:12:18 -07:00
Shawn Routhier
0b2ec8c99c [rt30281]
Modify the renew_lease6() code to properly handle a lease time
that is reduced rather than extended.
Fix the ATF tests for mdb6 and add a new test to check the
above condition.
2012-08-17 12:05:49 -07:00
Tomek Mrugalski
18a28679ed [master] RELNOTES entry for ATF moved to the changes since 4.2.4 section. 2012-08-16 16:47:18 +02:00
Tomek Mrugalski
260a0332fd [master] RELNOTES updated after ATF merge (rt25901_atf branch) 2012-08-14 15:21:19 +02:00
Shawn Routhier
df2c355e24 [rt30024] This is a commit message
Add the CVE number
2012-07-11 18:43:27 -07:00
Shawn Routhier
3bedb11744 [rt30024] This is a commit message
Fix a pair of memory leaks.
2012-07-11 14:50:35 -07:00
Shawn Routhier
e563ec2e58 When attempting to convert a DUID from a client id option
into a hardware address handle unexpected client ids properly.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29852]
CVE: CVE-2012-3570
2012-06-27 21:33:25 +00:00
Shawn Routhier
de87ffe336 Previously the server code was relaxed to allow packets with zero
length client ids to be processed.  Under some situations use of
zero length client ids can cause the server to go into an infinite
loop.  As such ids are not valid according to RFC 2132 section 9.14
the server no longer accepts them.  Client ids with a length of 1
are also invalid but the server still accepts them in order to
minimize disruption.  The restriction will likely be tightened in
the future to disallow ids with a length of 1.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29851]
CVE: CVE-2012-3571
2012-06-27 21:20:19 +00:00
Shawn Routhier
32e651c418 A problem with missing get_hw_addr function when --enable-use-sockets
was used is now solved on GNU/Linux, BSD and GNU/Hurd systems. Note
that use-sockets feature was not tested on those systems. Client and
server code no longer use MAX_PATH constant that is not defined on
GNU/Hurd systems. [ISC-Bugs 25979]
2012-06-08 23:28:11 +00:00
Shawn Routhier
6980ae03c3 The 'no available billing' log line now also logs the name of the last
matching billing class tried before failing to provide a billing.
ISC-Bugs #21759]
2012-06-06 23:55:01 +00:00
Shawn Routhier
35de6c8c24 Fix some issues in the code for parsing and printing options.
[ISC-Bugs #22625] - properly print options that have several fields
followed by an array of something for example "fIa"
[ISC-Bugs #27289] - properly parse options in declarations that have
several fields followed by an array of something for example "fIa"
[ISC-Bugs #27296] - properly determine if we parsed a 16 or 32 bit
value in evaluate_numeric_expression (extract-int).
[ISC-Bugs #27314] - properly parse a zero length option from
a lease file.  Thanks to Marius Tomaschewski from SUSE for the report
and prototype patch for this ticket as well as ticket 27289.
2012-06-06 22:50:31 +00:00
Shawn Routhier
9f9265b63f Correct code to calculate timing values in client to compare
rebind value to infinity instead of renew value.
[ISC-Bugs #29062]
2012-06-06 00:23:44 +00:00
Shawn Routhier
cbbd2714d6 - Rotate the lease file when running in v6 mode.
[ISC-Bugs #24887]
2012-05-15 21:07:17 +00:00
Shawn Routhier
53394a8de8 Fix typos per sanity review for 4.2.4b1/4.1-ESV-R5b1 2012-04-12 17:49:47 +00:00
Shawn Routhier
cfc494630c Fix typos per sanity review for 4.2.4b1/4.1-ESV-R5b1 2012-04-12 17:43:01 +00:00
Shawn Routhier
bb9189c30a Fix up some issues found by static analysis
A potential memory leak and NULL dereference in omapi.
The use of a boolean test instead of a bitwise test in dst.
[ISC-Bugs #28941]
2012-04-11 15:43:34 +00:00
Shawn Routhier
d19fa5a1b5 Fix the NA and PD allocation code to handle the case where a client
provides a preference and the server doesn't have any addresses or
prefixes available.  Previoulsy the server ignored the request with
this patch it replies with a NoAddrsAvail or NoPrefixAvai respone.
By default the code performs according to the errata of August 2010
for RFC 3315 section 17.2.2, to enable the previous style see the
seciton on RFC3315_PRE_ERRATA_2010_08 in includes/site.h.  This option
may be removed in the future.
Thanks to Jiri Popelka at Red Hat for the patch.
[ISC-Bugs #22676]
2012-04-10 22:13:46 +00:00
Shawn Routhier
d289ee683e Remove unnecessary checks in the lease query code and clean up
several compiler issues (some dereferences of NULL and treating
an int as a boolean).
[ISC-Bugs #26203]
2012-04-10 21:26:44 +00:00
Shawn Routhier
bc7f8b8e39 Multiple items to clean up IPv6 address processing.
When processing an IA that we've seen check to see if the
addresses are usable (not in use by somebody else) before
handing it out.
When reading in leases from the file discard expired addresses.
When picking an address for a client include the IA ID in
addition to the client ID to generally pick different addresses
for different IAs.
[ISC-Bugs #23138] [ISC-Bugs #27945] [ISC-Bugs #25586]
[ISC-Bugs #27684]
2012-04-10 00:54:35 +00:00
Shawn Routhier
797aab6748 Add release note 2012-04-02 22:43:41 +00:00
Shawn Routhier
b342f2e77c Use offsetof() instead of sizeof() to get the sizes for dhcpv6_relay_packet
and dhcpv6_packet in several more places.  Thanks to a report from
Bruno Verstuyft and Vincent Demaertelaere of Excentis.
[ISC-Bugs #27941]
2012-03-20 00:31:34 +00:00
Shawn Routhier
d13db163c7 Modify the code that determines if an outstanding DDNS request
should be cancelled.  This patch results in cancelling the
outstanding request less often.  It fixes the problem caused
by a client doing a release where  the  txt and ptr records
weren't removed from the DNS.
[ISC-BUGS #27858]
2012-03-19 22:29:06 +00:00
Tomek Mrugalski
dd9237c309 Fixed many compilation problems ("set, but not used" warnings) for
gcc 4.6 that may affect Ubuntu 11.10 users. [ISC-Bugs #27588]
2012-03-09 11:18:14 +00:00
Shawn Routhier
e3c948003b Add a compile time check for the presence of the noreturn attribute
and use it for log_fatal if it's available.  This will help code
checking programs to eliminate false positives.
[ISC-Bugs 27539]
2012-02-16 22:07:04 +00:00
Shawn Routhier
b047bd385b Add support for Infiniband over sockets to the server and
relay code.  We've tested this on Solaris and hope to expand
support for Infiniband in the future.  This patch also corrects
some issues we found in the socket code.  [ISC-Bugs #24245]
2012-02-16 21:05:28 +00:00
Shawn Routhier
865afd5e44 Tidy up the receive calls and eliminate the need for found_pkt
[ISC-Bugs #25066]
2012-02-10 00:07:06 +00:00
Shawn Routhier
87132514a0 In the DDNS code handle error conditions more gracefully and add more
logging code.  The major change is to handle unexpected cancel events
from the DNS client code.
[ISC-Bugs 26287].
2012-02-03 22:47:43 +00:00
Shawn Routhier
51b8a8a0ac Move a note to get it to end up in the last 4.2.x update
moving to 4.3
2012-02-01 00:11:00 +00:00
Shawn Routhier
de6c9af6dd Fixed the code that checks if an address the server is planning
to hand out is in a reserved range.  This would appear as
the server being out of addresses in pools with particular ranges.
[ISC-Bugs #26498]
2012-01-05 00:03:18 +00:00
Shawn Routhier
dc6908b477 Remove extra "out" from note. 2012-01-04 19:53:49 +00:00
Shawn Routhier
0ef9a46e33 Modify the DDNS handling code. In a previous patch we added logging
code to the DDNS handling.  This code included a bug that caused it
to attempt to dereference a NULL pointer and eventually segfault.
While reviewing the code as we addressed this problem, we determined
that some of the updates to the lease structures would not work as
planned since the structures being updated were in the process of
being freed: these updates were removed.  In addition we removed an
incorrect call to the DDNS removal function that could cause a failure
during the removal of DDNS information from the DNS server.
Thanks to Jasper Jongmans for reporting this issue.
[ISC-Bugs #27078]
CVE: CVE-2011-4868
2011-12-30 23:08:41 +00:00