2
0
mirror of https://gitlab.isc.org/isc-projects/dhcp synced 2025-08-23 02:17:31 +00:00

153 Commits

Author SHA1 Message Date
Thomas Markwalder
04daf4fe4b [master] Fixed concatenation of "Dc" formatted options such as domain-search
Merges in rt20558.
2014-11-25 15:22:52 -05:00
Thomas Markwalder
0a7e1a8ab0 [master] Add use-host-decl-names support to BOOTP
Merges in rt36233.
2014-10-27 14:51:20 -04:00
Thomas Markwalder
e046c82621 [master] Added echo-client-id server parameter
Merges in rt35958 which includes fix for rt32545
    Also updated dhcp/.gitignore
2014-10-17 07:56:01 -04:00
Thomas Markwalder
a07d99bbef [master] Corrects medium impact issues reported by Coverity.
Merges in rt36933
2014-08-28 08:12:30 -04:00
Shawn Routhier
250f7134bb [master] Add support for pool thresholds
Add support to set high and low thresholds for pools for
v4 and v6.  A message will be emitted when the usage of
the pool first exceeds the high threshold.  More messages
will be skipped until the usage has gone below the low
threshold and then back above the high threshold.
2014-06-05 14:55:01 -07:00
Shawn Routhier
1be2ba154d [master] Correct ordering for subnet mask and router and overload vs relay option
Conflicts:
	RELNOTES
2014-04-28 16:15:36 -07:00
Shawn Routhier
edad9be5cd [master] Remove vix.com and nominum.com
Remove old information from copyrights and
    man pages.
2014-01-26 10:52:15 -08:00
Shawn Routhier
0f750c4fb1 [master]
[rt23833]
Clean up a number of items identified by the Coverity
static analysis tool.  Runs courtesy of Red Hat.
2012-10-16 15:05:24 -07:00
Shawn Routhier
67b2cb451b [master]
Update the memory leakage debug code to work with v6.
2012-09-19 14:27:44 -07:00
Shawn Routhier
3bedb11744 [rt30024] This is a commit message
Fix a pair of memory leaks.
2012-07-11 14:50:35 -07:00
Shawn Routhier
de87ffe336 Previously the server code was relaxed to allow packets with zero
length client ids to be processed.  Under some situations use of
zero length client ids can cause the server to go into an infinite
loop.  As such ids are not valid according to RFC 2132 section 9.14
the server no longer accepts them.  Client ids with a length of 1
are also invalid but the server still accepts them in order to
minimize disruption.  The restriction will likely be tightened in
the future to disallow ids with a length of 1.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29851]
CVE: CVE-2012-3571
2012-06-27 21:20:19 +00:00
Shawn Routhier
35de6c8c24 Fix some issues in the code for parsing and printing options.
[ISC-Bugs #22625] - properly print options that have several fields
followed by an array of something for example "fIa"
[ISC-Bugs #27289] - properly parse options in declarations that have
several fields followed by an array of something for example "fIa"
[ISC-Bugs #27296] - properly determine if we parsed a 16 or 32 bit
value in evaluate_numeric_expression (extract-int).
[ISC-Bugs #27314] - properly parse a zero length option from
a lease file.  Thanks to Marius Tomaschewski from SUSE for the report
and prototype patch for this ticket as well as ticket 27289.
2012-06-06 22:50:31 +00:00
Shawn Routhier
b342f2e77c Use offsetof() instead of sizeof() to get the sizes for dhcpv6_relay_packet
and dhcpv6_packet in several more places.  Thanks to a report from
Bruno Verstuyft and Vincent Demaertelaere of Excentis.
[ISC-Bugs #27941]
2012-03-20 00:31:34 +00:00
Tomek Mrugalski
dd9237c309 Fixed many compilation problems ("set, but not used" warnings) for
gcc 4.6 that may affect Ubuntu 11.10 users. [ISC-Bugs #27588]
2012-03-09 11:18:14 +00:00
Shawn Routhier
8bd96ccb21 Two packets were found that cause a server to halt. The code
has been updated to properly process or reject the packets as
appropriate.  Thanks to David Zych at University of Illinois
for reporting this issue.  [ISC-Bugs #24960]
One CVE number for each class of packet.
CVE-2011-2748
CVE-2011-2749
2011-07-19 22:13:26 +00:00
Shawn Routhier
c850c0eec5 Restore common/discover.c, common/options.c and server/dhcp.c
as I mistakenly committed them to head instead of the ticket
branch.
2011-07-02 00:05:35 +00:00
Shawn Routhier
640101e3d3 Correct an unsigned math operation when calculating the options
buffer space for bootp and use a better constant - DHCP packet
size instead of DHCP packet size + udp and iP headers.
Check that we have a packet->options structure before using it.
Only process packets that are longer than a bootp fixed packet
including server and file names.  Previously we allowed for
shorter packets but that wasn't working and nobody noticed.
2011-07-01 23:11:53 +00:00
Shawn Routhier
bea1769742 In dhclient check the data for some string options for
reasonableness before passing it along to the script that
interfaces with the OS. [ISC-Bugs #23722]
2011-03-24 21:11:01 +00:00
Shawn Routhier
1e05d095c2 Don't include lease time information in the response to a DHCPINFORM
request.  We do this by removing any time information from the option
cache before building the reponse packet.  Bug ticket 21092.
2010-04-20 23:20:20 +00:00
Shawn Routhier
a35285748d Clean up some compiler warnings 2010-02-02 00:44:06 +00:00
Shawn Routhier
a47d63362f Update copyright years 2009-11-24 02:06:57 +00:00
David Hankins
5a671e8715 *** empty log message *** 2009-09-11 18:13:12 +00:00
Shawn Routhier
2c85ac9b24 Switch isc urls from http to https and correct sw to services or software
for new web site as appropirate.
2009-07-23 18:52:21 +00:00
David Hankins
f4534b17fa - Fixed a cosmetic bug where pretty-printing valid domain-search options would
result in an erroneous error log message ('garbage in format string').
  [ISC-Bugs #19327]
2009-03-10 20:54:02 +00:00
David Hankins
47e6eb82cb - The notorious 'option <unknown> ... larger than buffer' log line,
which is seen in some malformed DHCP client packets, was modified.
  It now logs the universe name, and does not log the length values
  (which are bogus corruption read from the packet anyway).  It also
  carries a hopefully more useful explanation. [ISC-Bugs #18241]
2009-01-07 19:54:06 +00:00
Evan Hunt
535485df4e The server wasn't always sending the FQDN option when it should. [rt18237] 2008-07-19 03:57:23 +00:00
Evan Hunt
20210a7bfc Clients that sent a parameter request list containing the routers option
before the subnet mask option were receiving only the latter. [rt18133]
2008-07-19 01:11:40 +00:00
Evan Hunt
7de20a9518 - Merge dhcrelay6 into dhcrelay
- Prep for 4.1.0a2 release
2008-06-13 00:55:53 +00:00
Francis Dupont
8009776487 fix format code 'Z' 2008-06-12 13:27:55 +00:00
David Hankins
8269561daa - A bug was fixed where the length of a hostname was miscalculated, so that
hosts were given odd-looking domain names ("foo.bar.ba.example.com").
  [ISC-Bugs #17732]
2008-03-06 21:33:22 +00:00
Evan Hunt
dccb6edf66 Updated copyright strings for 4.1.0a1 release 2008-01-24 02:43:06 +00:00
Evan Hunt
4cafb81543 Added explicit parser support for zero-length DHCP options, such as
rapid-commit, via format code 'Z' [rt17355]
2008-01-23 19:19:22 +00:00
Francis Dupont
9d28ba1291 format_min_length() doesn't know IPv6 2007-12-20 15:33:15 +00:00
Francis Dupont
20ae1affb0 almost editorial stuff 2007-11-30 21:51:43 +00:00
David Hankins
bead14ea8b - The server will now include multiple IA_NA's and multiple IAADDRs within
them, if advertised by the client.  It still only seeks to allocate one
  new address. [ISC-Bugs #17254]
2007-11-14 23:44:46 +00:00
David Hankins
290b43b9cb Remove unreviewed sources from HEAD. 2007-11-06 18:31:36 +00:00
David Hankins
e4a6be15e8 Might even work. 2007-10-30 23:08:16 +00:00
Evan Hunt
e2624b82f1 - Reworked cons_options() and store_options() to fix a buffer
overflow that could result in a DoS (CVS 2007-0062).  Also general
  code tidying. [rt17090]
- Also fixed a spurious error message on the client. [rt17250]
2007-10-26 22:46:50 +00:00
Shane Kerr
3ad9d48f8c Bug in decoding certain options fixed.
See RT ticket #17188 for more.
2007-10-04 12:14:42 +00:00
David Hankins
e9c596456f - The subnet-mask option inclusion now conforms with RFC2132 section 3.3;
it will only appear prior to the routers option if it is present on the
  Parameter-Request-List.  The subnet-mask option will also only be
  included by default (if it is not on the PRL) in response to DISCOVER
  or REQUEST messages.
  [ISC-Bugs #17117]
- The FQDN option is only supplied if the client supplied an FQDN option or
  if the FQDN option was explicitly requested on the PRL.
  [ISC-Bugs #17117]
2007-10-01 16:24:44 +00:00
Shane Kerr
c6785bb5e1 Compile fix for Linux 64-bit. 2007-08-23 13:46:23 +00:00
Shane Kerr
06eb8bab55 Fix a number of warnings (and a few real bugs) found by enabling
gcc warnings.

See RT ticket #17013 for more.
2007-08-22 13:41:37 +00:00
Shane Kerr
28868515f6 Code cleanup to remove warnings from "gcc -Wall".
See RT ticket #16988 for more.
2007-07-13 06:43:43 +00:00
David Hankins
c9feb859e0 - Corrected a flaw that broke encapsulated spaces included due to presence
on the parameter request list. [ISC-Bugs #16625]
2007-05-23 19:25:40 +00:00
David Hankins
fe5b0fdd70 - Replaced ./configure shellscripting with GNU Autoconf. [ISC-Bugs #16405b]
- RELNOTES/README++
- s/wether/whether/ in dhcp-options.5 manpage edits.
2007-05-19 18:47:15 +00:00
David Hankins
3496f11e70 Update comment per rt16841. 2007-05-16 21:29:57 +00:00
David Hankins
a512d11b6d - Corrected some situations where variables might be used without being
initialized. [ISC-Bugs #16865]

- Silenced several other compiler warnings. [ISC-Bugs #16865]

- Include the more standard sys/uio.h rather than rely upon other header
  files to include it (fixes a BSDI compile failure). [ISC-Bugs #16865]
2007-05-11 15:50:18 +00:00
David Hankins
98bd7ca099 DHCPv6 branch merged to HEAD. 2007-05-08 23:05:22 +00:00
David Hankins
06211b4018 - A bug was repaired in subencapsulation support, where spaces separated
by empty spaces would not get included. [ISC-Bugs #16805]
2007-04-12 16:15:31 +00:00
David Hankins
ecde99a330 - A bug was fixed where the nwip virtual option space was referencing
the fqdn option's virtual option space's option cache. [ISC-Bugs #16801]
2007-04-11 02:04:39 +00:00