From 22e65626cc8a4d09a709cf79f704e12736547c04 Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Sun, 4 Mar 2018 13:18:15 +0100
Subject: [PATCH] Fix accessibility issues

Summary: Add some image contentDescriptions and one focusable property

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D11004
---
 res/layout-land/activity_mpris.xml       | 1 +
 res/layout/activity_mpris.xml            | 1 +
 res/layout/list_item_with_icon_entry.xml | 2 ++
 res/layout/preference_with_button.xml    | 1 +
 res/values/strings.xml                   | 3 +++
 5 files changed, 8 insertions(+)

diff --git a/res/layout-land/activity_mpris.xml b/res/layout-land/activity_mpris.xml
index ef4867ee..21fcabcc 100644
--- a/res/layout-land/activity_mpris.xml
+++ b/res/layout-land/activity_mpris.xml
@@ -14,6 +14,7 @@
         android:layout_height="match_parent"
         android:layout_marginRight="25dp"
         android:layout_weight="1"
+        android:contentDescription="@string/mpris_coverart_description"
         android:scaleType="fitCenter" />
 
     <include
diff --git a/res/layout/activity_mpris.xml b/res/layout/activity_mpris.xml
index 2798457e..e99a1ab6 100644
--- a/res/layout/activity_mpris.xml
+++ b/res/layout/activity_mpris.xml
@@ -14,6 +14,7 @@
         android:layout_height="0dp"
         android:layout_marginBottom="25dp"
         android:layout_weight="4"
+        android:contentDescription="@string/mpris_coverart_description"
         android:scaleType="fitCenter" />
 
     <include
diff --git a/res/layout/list_item_with_icon_entry.xml b/res/layout/list_item_with_icon_entry.xml
index c59ed5b4..a50cdf9c 100644
--- a/res/layout/list_item_with_icon_entry.xml
+++ b/res/layout/list_item_with_icon_entry.xml
@@ -5,6 +5,7 @@
     android:background="@drawable/abc_list_selector_holo_dark"
     android:baselineAligned="false"
     android:clickable="true"
+    android:focusable="true"
     android:gravity="center_vertical"
     android:minHeight="?android:attr/listPreferredItemHeight"
     android:orientation="horizontal"
@@ -18,6 +19,7 @@
         android:layout_width="wrap_content"
         android:layout_height="match_parent"
         android:layout_gravity="center_vertical"
+        android:contentDescription="@string/device_icon_description"
         android:src="@drawable/ic_device_laptop" />
 
     <LinearLayout
diff --git a/res/layout/preference_with_button.xml b/res/layout/preference_with_button.xml
index 163de184..2ad4afb3 100644
--- a/res/layout/preference_with_button.xml
+++ b/res/layout/preference_with_button.xml
@@ -73,6 +73,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:background="@drawable/abc_btn_borderless_material"
+        android:contentDescription="@string/settings_icon_description"
         android:padding="8dip"
         android:src="@drawable/ic_action_settings_inverted" />
 
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 2b10f911..26ea7693 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -223,5 +223,8 @@
     <string name="select_ringtone">Select a ringtone</string>
     <string name="telephony_pref_blocked_title">Blocked numbers</string>
     <string name="telephony_pref_blocked_dialog_desc">Don\'t show calls and SMS from these numbers. Please specify one number per line</string>
+    <string name="mpris_coverart_description">Cover art of current media</string>
+    <string name="device_icon_description">Device icon</string>
+    <string name="settings_icon_description">Settings icon</string>
 
 </resources>