mir/kdeconnect-android
2
0
Fork 0
mirror of https://github.com/KDE/kdeconnect-android synced 2025-09-02 15:15:09 +00:00
Code Issues Releases Wiki Activity

Do not send null NetworkPackets

Browse Source 
Summary: queuedSendUriList can return null and subsequently an attempt is make to actually send this null packet

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17384
This commit is contained in:
Erik Duisters
2018-12-06 16:55:58 +01:00
parent 514f2a2035
commit 27f8c57c50
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
View File

@@ -284,7 +284,11 @@ public class SharePlugin extends Plugin implements ReceiveFileRunnable.CallBack
//Read all the data early, as we only have permissions to do it while the activity is alive //Read all the data early, as we only have permissions to do it while the activity is alive
final ArrayList<NetworkPacket> toSend = new ArrayList<>(); final ArrayList<NetworkPacket> toSend = new ArrayList<>();
for (Uri uri : uriList) { for (Uri uri : uriList) {
toSend.add(uriToNetworkPacket(context, uri)); NetworkPacket np = uriToNetworkPacket(context, uri);
if (np != null) {
toSend.add(np);
}
} }
//Callback that shows a progress notification //Callback that shows a progress notification