From 8a7f7231b5de4992f9c97e02367a3890a55c2ffd Mon Sep 17 00:00:00 2001 From: Albert Vaca Date: Sun, 9 Jul 2017 18:30:20 +0200 Subject: [PATCH 1/2] Do not swallow the exception, wrap it and let it crash. Returning null did make it crash on NPE anyway, and we lost info. --- src/org/kde/kdeconnect/Plugins/PluginFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/kde/kdeconnect/Plugins/PluginFactory.java b/src/org/kde/kdeconnect/Plugins/PluginFactory.java index 826a5857..4a06a18d 100644 --- a/src/org/kde/kdeconnect/Plugins/PluginFactory.java +++ b/src/org/kde/kdeconnect/Plugins/PluginFactory.java @@ -147,7 +147,7 @@ public class PluginFactory { } catch(Exception e) { Log.e("PluginFactory","getPluginInfo exception"); e.printStackTrace(); - return null; + throw new RuntimeException(e); } } From 7ffd7c2682e0660497e8150f4f05adfe99c52700 Mon Sep 17 00:00:00 2001 From: Albert Vaca Date: Sun, 9 Jul 2017 18:42:34 +0200 Subject: [PATCH 2/2] Bumped minor version of Android tools --- build.gradle | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build.gradle b/build.gradle index d94cc94c..b7bf71ed 100644 --- a/build.gradle +++ b/build.gradle @@ -3,14 +3,14 @@ buildscript { jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:2.3.2' + classpath 'com.android.tools.build:gradle:2.3.3' } } apply plugin: 'com.android.application' android { - buildToolsVersion '25.0.2' + buildToolsVersion '25.0.3' compileSdkVersion 25 defaultConfig { minSdkVersion 9 @@ -71,9 +71,9 @@ dependencies { mavenCentral() } - compile 'com.android.support:support-v4:25.1.1' - compile 'com.android.support:appcompat-v7:25.1.1' - compile 'com.android.support:design:25.1.1' + compile 'com.android.support:support-v4:25.3.1' + compile 'com.android.support:appcompat-v7:25.3.1' + compile 'com.android.support:design:25.3.1' compile 'org.apache.sshd:sshd-core:0.8.0' //0.9 seems to fail on Android 6 and 1.+ requires java.nio.file, which doesn't exist in Android