mir/kdeconnect-android
2
0
Fork 0
mirror of https://github.com/KDE/kdeconnect-android synced 2025-09-03 07:35:08 +00:00
Code Issues Releases Wiki Activity

Fix catch not working because broadcastUdpPacket starts a thread

Browse Source 
We don't want to crash if we get onNetworkChange before tcpServer has been
initialized, however the way to do it was wrong because the exception was
being thrown from a new thread.
This commit is contained in:
Albert Vaca Cintora
2023-06-03 18:58:56 +02:00
parent b201dadf12
commit 8ba4b532d4
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java
View File

@@ -369,7 +369,8 @@ public class LanLinkProvider extends BaseLinkProvider implements LanLink.LinkDis
NetworkPacket identity = NetworkPacket.createIdentityPacket(context); NetworkPacket identity = NetworkPacket.createIdentityPacket(context);
if (tcpServer == null || !tcpServer.isBound()) { if (tcpServer == null || !tcpServer.isBound()) {
throw new IllegalStateException("Wont't broadcast UDP packet if TCP socket is not ready"); Log.i("LanLinkProvider", "Won't broadcast UDP packet if TCP socket is not ready yet");
return;
} }
int port = tcpServer.getLocalPort(); int port = tcpServer.getLocalPort();
identity.set("tcpPort", port); identity.set("tcpPort", port);
@@ -420,11 +421,7 @@ public class LanLinkProvider extends BaseLinkProvider implements LanLink.LinkDis
@Override @Override
public void onNetworkChange() { public void onNetworkChange() {
try { broadcastUdpPacket();
broadcastUdpPacket();
} catch (IllegalStateException e) {
e.printStackTrace();
}
} }
@Override @Override