From 96a1edfb764da78b026755da08a635a9610fe055 Mon Sep 17 00:00:00 2001
From: Erik Duisters <e.duisters1@gmail.com>
Date: Thu, 6 Dec 2018 19:09:47 +0100
Subject: [PATCH] Fix lint warning: Avoid non-default constructors in fragments

Summary: It is common practice to use a static newInstance to create new fragment instances instead of using non-default constructors

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17390
---
 src/org/kde/kdeconnect/UserInterface/DeviceFragment.java | 8 ++++++--
 src/org/kde/kdeconnect/UserInterface/MainActivity.java   | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/org/kde/kdeconnect/UserInterface/DeviceFragment.java b/src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
index 9ff67e98..6a9c7974 100644
--- a/src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
+++ b/src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
@@ -73,11 +73,15 @@ public class DeviceFragment extends Fragment {
     public DeviceFragment() {
     }
 
-    public DeviceFragment(String deviceId, boolean fromDeviceList) {
+    public static DeviceFragment newInstance(String deviceId, boolean fromDeviceList) {
+        DeviceFragment frag = new DeviceFragment();
+
         Bundle args = new Bundle();
         args.putString(ARG_DEVICE_ID, deviceId);
         args.putBoolean(ARG_FROM_DEVICE_LIST, fromDeviceList);
-        this.setArguments(args);
+        frag.setArguments(args);
+
+        return frag;
     }
 
     @Override
diff --git a/src/org/kde/kdeconnect/UserInterface/MainActivity.java b/src/org/kde/kdeconnect/UserInterface/MainActivity.java
index d0d9ecf9..d263728c 100644
--- a/src/org/kde/kdeconnect/UserInterface/MainActivity.java
+++ b/src/org/kde/kdeconnect/UserInterface/MainActivity.java
@@ -295,7 +295,7 @@ public class MainActivity extends AppCompatActivity {
             } else {
                 mNavigationView.setCheckedItem(mCurrentMenuEntry);
             }
-            setContentFragment(new DeviceFragment(deviceId, fromDeviceList));
+            setContentFragment(DeviceFragment.newInstance(deviceId, fromDeviceList));
         } else {
             mCurrentMenuEntry = MENU_ENTRY_ADD_DEVICE;
             mNavigationView.setCheckedItem(mCurrentMenuEntry);