mir/kdeconnect-android
2
0
Fork 0
mirror of https://github.com/KDE/kdeconnect-android synced 2025-08-28 20:57:42 +00:00
Code Issues Releases Wiki Activity

Reorder the Samsung special case to take effect before the case handling all other devices

Browse Source 
BUG: 401677
This commit is contained in:
Simon Redman 2019-07-09 09:20:17 +02:00
parent c4983ae0ef
commit ffbceb9b8e
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/org/kde/kdeconnect/Helpers/SMSHelper.java
View File

@ -104,15 +104,19 @@ public class SMSHelper {
* Get the base address for all message conversations * Get the base address for all message conversations
*/ */
private static Uri getConversationUri() { private static Uri getConversationUri() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
return Telephony.MmsSms.CONTENT_CONVERSATIONS_URI; // Special case for Samsung
} else if ("Samsung".equals(Build.MANUFACTURER)){ // For some reason, Samsung devices do not support the regular SmsMms column.
// For some presumably asinine reason, Samsung devices do not support the regular SmsMms column.
// However, according to https://stackoverflow.com/a/13640868/3723163, we can work around it this way. // However, according to https://stackoverflow.com/a/13640868/3723163, we can work around it this way.
// By my understanding, "simple=true" means we can't support multi-target messages. // By my understanding, "simple=true" means we can't support multi-target messages.
// Go complain to Samsung about their crappy OS changes! // Go complain to Samsung about their annoying OS changes!
if ("Samsung".equals(Build.MANUFACTURER)){
Log.i("SMSHelper", "Samsung compatibility mode enabled. This may cause some features to not work properly."); Log.i("SMSHelper", "Samsung compatibility mode enabled. This may cause some features to not work properly.");
return Uri.parse("content://mms-sms/conversations?simple=true"); return Uri.parse("content://mms-sms/conversations?simple=true");
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
return Telephony.MmsSms.CONTENT_CONVERSATIONS_URI;
} else { } else {
// As with getSMSUriBad, this is potentially unsafe depending on whether a specific // As with getSMSUriBad, this is potentially unsafe depending on whether a specific
// manufacturer decided to do their own thing // manufacturer decided to do their own thing