mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-01 06:25:34 +00:00
Code Issues Releases Wiki Activity

[1443] cleanup and docstring for new test

Browse Source
This commit is contained in:
Jelte Jansen
2012-03-26 12:03:58 +02:00
parent d98c6ee086
commit 0161c02ad4
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/lib/python/isc/config/tests/cfgmgr_test.py
View File

@@ -74,7 +74,14 @@ class TestConfigManagerData(unittest.TestCase):
self.assertEqual(self.config_manager_data, new_config) self.assertEqual(self.config_manager_data, new_config)
os.remove(output_file_name) os.remove(output_file_name)
def check_existance(self, files, should_exist=[], should_not_exist=[]): def check_existence(self, files, should_exist=[], should_not_exist=[]):
"""Helper function for test_rename_config_file.
Arguments:
files: array of file names to check.
should_exist: array of indices, the files in 'files' with these
indices should exist.
should_not_exist: array of indices, the files in 'files' with
these indices should not exist."""
for n in should_exist: for n in should_exist:
self.assertTrue(os.path.exists(files[n])) self.assertTrue(os.path.exists(files[n]))
for n in should_not_exist: for n in should_not_exist:
@@ -93,28 +100,28 @@ class TestConfigManagerData(unittest.TestCase):
# The original does not exist, so the new one should not be created # The original does not exist, so the new one should not be created
self.config_manager_data.rename_config_file(filenames[0]) self.config_manager_data.rename_config_file(filenames[0])
self.check_existance(filenames, [], [0, 1, 2, 3]) self.check_existence(filenames, [], [0, 1, 2, 3])
# now create a file to rename, and call rename again # now create a file to rename, and call rename again
self.config_manager_data.write_to_file(filenames[0]) self.config_manager_data.write_to_file(filenames[0])
self.config_manager_data.rename_config_file(filenames[0]) self.config_manager_data.rename_config_file(filenames[0])
self.check_existance(filenames, [1], [0, 2, 3]) self.check_existence(filenames, [1], [0, 2, 3])
# If backup already exists, give it a new name automatically # If backup already exists, give it a new name automatically
self.config_manager_data.write_to_file(filenames[0]) self.config_manager_data.write_to_file(filenames[0])
self.config_manager_data.rename_config_file(filenames[0]) self.config_manager_data.rename_config_file(filenames[0])
self.check_existance(filenames, [1, 2], [0, 3]) self.check_existence(filenames, [1, 2], [0, 3])
# If backup already exists, give it a new name automatically with # If backup already exists, give it a new name automatically with
# increasing postfix # increasing postfix
self.config_manager_data.write_to_file(filenames[0]) self.config_manager_data.write_to_file(filenames[0])
self.config_manager_data.rename_config_file(filenames[0]) self.config_manager_data.rename_config_file(filenames[0])
self.check_existance(filenames, [1, 2, 3], [0]) self.check_existence(filenames, [1, 2, 3], [0])
# Test with explicit renamed file argument # Test with explicit renamed file argument
self.config_manager_data.rename_config_file(filenames[1], self.config_manager_data.rename_config_file(filenames[1],
filenames[0]) filenames[0])
self.check_existance(filenames, [0, 2, 3], [1]) self.check_existence(filenames, [0, 2, 3], [1])
# clean up again to be nice # clean up again to be nice
for filename in filenames: for filename in filenames: