mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-22 01:49:48 +00:00
Code Issues Releases Wiki Activity

[#3811] Addressed review comments

Browse Source 
Changes to be committed:
	modified:   changelog_unreleased/3811-include-the-shared-network-name-in-the-subnetx-list-response
    modified:   src/hooks/dhcp/subnet_cmds/tests/subnet4_cmds_unittest.cc
    modified:   src/hooks/dhcp/subnet_cmds/tests/subnet6_cmds_unittest.cc
    modified:   src/hooks/dhcp/subnet_cmds/tests/subnet_cmds_unittest.h
This commit is contained in:
Thomas Markwalder 2025-04-02 15:27:40 -04:00
parent fc59433ae9
commit 0ade1dae0f
4 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hooks/dhcp/subnet_cmds/tests/subnet4_cmds_unittest.cc
View File

@ -1758,8 +1758,7 @@ TEST_F(Subnet4CmdsTest, subnet4List) {
CONTROL_RESULT_SUCCESS, CONTROL_RESULT_SUCCESS,
"3 IPv4 subnets found"); "3 IPv4 subnets found");
// Verify that the response has appropriate structure and returned // Verify that the returned response has the expected subnets.
// the expected arguments.
std::string exp_args=R"( std::string exp_args=R"(
{ {
"subnets": [ "subnets": [

4
src/hooks/dhcp/subnet_cmds/tests/subnet6_cmds_unittest.cc
View File

@ -2449,8 +2449,7 @@ TEST_F(Subnet6CmdsTest, subnet6List) {
CONTROL_RESULT_SUCCESS, CONTROL_RESULT_SUCCESS,
"3 IPv6 subnets found"); "3 IPv6 subnets found");
// Verify that the response has appropriate structure and returned // Verify that the returned response has the expected subnets.
// the expected arguments.
std::string exp_args=R"( std::string exp_args=R"(
{ {
"subnets": [ "subnets": [
@ -2483,6 +2482,7 @@ TEST_F(Subnet6CmdsTest, noSubnet6List) {
ConstElementPtr response = testCommand("{ \"command\": \"subnet6-list\" }", ConstElementPtr response = testCommand("{ \"command\": \"subnet6-list\" }",
CONTROL_RESULT_EMPTY, CONTROL_RESULT_EMPTY,
"0 IPv6 subnets found"); "0 IPv6 subnets found");
// Verify that the response has appropriate structure and no subnets // Verify that the response has appropriate structure and no subnets
// are included. // are included.
std::string exp_args=R"( std::string exp_args=R"(

2
src/hooks/dhcp/subnet_cmds/tests/subnet_cmds_unittest.h
View File

@ -491,7 +491,7 @@ public:
} }
} }
/// @brief Verifies that the content of the "args" element in the response. /// @brief Verifies the content of the "args" element in the response.
/// ///
/// @param answer Server's response to a command. /// @param answer Server's response to a command.
/// @param exp_args JSON map of the expected arguments contents. /// @param exp_args JSON map of the expected arguments contents.