From 1a7e1400159a1f3c0f073e13fecf2a91c2080cd8 Mon Sep 17 00:00:00 2001 From: Thomas Markwalder Date: Fri, 10 Nov 2023 13:35:29 -0500 Subject: [PATCH] [#3084] Clean up --- src/bin/dhcp4/dhcp4_srv.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc index f4bf21c1c0..b3aa78af3e 100644 --- a/src/bin/dhcp4/dhcp4_srv.cc +++ b/src/bin/dhcp4/dhcp4_srv.cc @@ -1518,7 +1518,6 @@ Dhcpv4Srv::processDhcp4Query(Pkt4Ptr& query, Pkt4Ptr& rsp, try { callout_handle->getArgument("offer-address-in-use", offer_address_in_use); } catch (const NoSuchArgument& ex) { - /// @todo consider logging this LOG_DEBUG(hooks_logger, DBG_DHCP4_HOOKS, DHCP4_HOOK_LEASE4_OFFER_ARGUMENT_MISSING) .arg(query->getLabel()); @@ -4015,14 +4014,14 @@ Dhcpv4Srv::serverDecline(hooks::CalloutHandlePtr& /* callout_handle */, Pkt4Ptr& StatsMgr::instance().addValue("assigned-addresses", static_cast(1)); } - /* (comment it out so picky tools don't flag this as dead code // /// @todo #3110, HA will implement a handler for this hook point to /// propagate an update of the lease to peers. // // Let's check if there are hooks installed for server decline hook point. - // If they are, let's pass the lease and client's packet. + // If they are, let's pass the lease and client's packet. Note this code + // has never been compiled, it is just an initial draft. if (HooksManager::calloutsPresent(Hooks.hook_index_lease4_server_decline)) { CalloutHandlePtr callout_handle = getCalloutHandle(decline);