mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 05:55:28 +00:00
Code Issues Releases Wiki Activity

[#1219] Addressed comments

Browse Source
This commit is contained in:
Francis Dupont
2020-05-15 18:43:38 +02:00
parent bee3e709b7
commit 2cababe790
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/hooks/dhcp/high_availability/ha_service.cc
View File

@@ -963,7 +963,6 @@ void
HAService::updatePendingRequestInternal(QueryPtrType& query) { HAService::updatePendingRequestInternal(QueryPtrType& query) {
if (pending_requests_.count(query) == 0) { if (pending_requests_.count(query) == 0) {
pending_requests_[query] = 1; pending_requests_[query] = 1;
} else { } else {
++pending_requests_[query]; ++pending_requests_[query];
} }

8
src/hooks/dhcp/high_availability/ha_service.h
View File

@@ -933,7 +933,7 @@ protected:
/// @param [out] parking_lot Parking lot where the query is parked. /// @param [out] parking_lot Parking lot where the query is parked.
/// This method uses this handle to unpark the packet when all asynchronous /// This method uses this handle to unpark the packet when all asynchronous
/// requests have been completed. /// requests have been completed.
/// @return True when all lease updates are complete, false otherwise. /// @return When all lease updates are complete returns true, false otherwise.
template<typename QueryPtrType> template<typename QueryPtrType>
bool leaseUpdateComplete(QueryPtrType& query, bool leaseUpdateComplete(QueryPtrType& query,
const hooks::ParkingLotHandlePtr& parking_lot); const hooks::ParkingLotHandlePtr& parking_lot);
@@ -962,19 +962,23 @@ private:
/// - if there was one remove the query from the map /// - if there was one remove the query from the map
/// - return true /// - return true
/// ///
/// Should be called in a thread safe context.
///
/// @tparam QueryPtrType Type of the pointer to the DHCP client's message, /// @tparam QueryPtrType Type of the pointer to the DHCP client's message,
/// i.e. Pkt4Ptr or Pkt6Ptr. /// i.e. Pkt4Ptr or Pkt6Ptr.
/// @param query Pointer to the DHCP client's query. /// @param query Pointer to the DHCP client's query.
/// @param [out] parking_lot Parking lot where the query is parked. /// @param [out] parking_lot Parking lot where the query is parked.
/// This method uses this handle to unpark the packet when all asynchronous /// This method uses this handle to unpark the packet when all asynchronous
/// requests have been completed. /// requests have been completed.
/// @return True when all lease updates are complete, false otherwise. /// @return When all lease updates are complete returns true, false otherwise.
template<typename QueryPtrType> template<typename QueryPtrType>
bool leaseUpdateCompleteInternal(QueryPtrType& query, bool leaseUpdateCompleteInternal(QueryPtrType& query,
const hooks::ParkingLotHandlePtr& parking_lot); const hooks::ParkingLotHandlePtr& parking_lot);
/// @brief Update pending request counter for this query. /// @brief Update pending request counter for this query.
/// ///
/// Should be called in a thread safe context.
///
/// @tparam QueryPtrType Type of the pointer to the DHCP client's message, /// @tparam QueryPtrType Type of the pointer to the DHCP client's message,
/// i.e. Pkt4Ptr or Pkt6Ptr. /// i.e. Pkt4Ptr or Pkt6Ptr.
/// @param query Pointer to the DHCP client's query. /// @param query Pointer to the DHCP client's query.