mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-01 14:35:29 +00:00
Code Issues Releases Wiki Activity

[#1040] handle update and delete

Browse Source
This commit is contained in:
Razvan Becheriu
2020-01-23 19:17:53 +02:00
parent 735fdcb6eb
commit 364bbbf3d4
7 changed files with 115 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/lib/dhcpsrv/mysql_lease_mgr.cc
View File

@@ -2836,7 +2836,9 @@ MySqlLeaseMgr::deleteLeaseCommon(StatementIndex stindex, MYSQL_BIND* bind) {
// See how many rows were affected. Note that the statement may delete
// multiple rows.
return (static_cast<uint64_t>(mysql_stmt_affected_rows(ctx->conn_.statements_[stindex])));
int affected_rows = mysql_stmt_affected_rows(ctx->conn_.statements_[stindex]);
return (static_cast<uint64_t>(affected_rows));
}
bool
@@ -2862,7 +2864,22 @@ MySqlLeaseMgr::deleteLease(const Lease4Ptr& lease) {
inbind[1].buffer = reinterpret_cast<char*>(&expire);
inbind[1].buffer_length = sizeof(expire);
return (deleteLeaseCommon(DELETE_LEASE4, inbind) > 0);
auto affected_rows = deleteLeaseCommon(DELETE_LEASE4, inbind);
// Check success case first as it is the most likely outcome.
if (affected_rows == 1) {
return (true);
}
// If no rows affected, lease doesn't exist.
if (affected_rows == 0) {
return (false);
}
// Should not happen - primary key constraint should only have selected
// one row.
isc_throw(DbOperationError, "apparently deleted more than one lease "
"that had the address " << lease->addr_.toText());
}
bool
@@ -2893,7 +2910,22 @@ MySqlLeaseMgr::deleteLease(const Lease6Ptr& lease) {
inbind[1].buffer = reinterpret_cast<char*>(&expire);
inbind[1].buffer_length = sizeof(expire);
return (deleteLeaseCommon(DELETE_LEASE6, inbind) > 0);
auto affected_rows = deleteLeaseCommon(DELETE_LEASE6, inbind);
// Check success case first as it is the most likely outcome.
if (affected_rows == 1) {
return (true);
}
// If no rows affected, lease doesn't exist.
if (affected_rows == 0) {
return (false);
}
// Should not happen - primary key constraint should only have selected
// one row.
isc_throw(DbOperationError, "apparently deleted more than one lease "
"that had the address " << lease->addr_.toText());
}
uint64_t