mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-01 06:25:34 +00:00
Code Issues Releases Wiki Activity

[#2604] Corrected compiler warnings

Browse Source 
src/lib/dhcpsrv/mysql_lease_mgr.cc
src/lib/dhcpsrv/pgsql_lease_mgr.cc
src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
    Commented out unused parameters

src/lib/dhcpsrv/mysql_lease_mgr.h
src/lib/dhcpsrv/pgsql_lease_mgr.h
    added missing setExtendedInfoTablesEnabled() variant
This commit is contained in:
Thomas Markwalder
2022-10-21 18:29:26 -04:00
parent 91e2aea4f1
commit 78865afc69
5 changed files with 32 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/dhcpsrv/mysql_lease_mgr.cc
View File

@@ -3373,14 +3373,14 @@ MySqlLeaseMgr::deleteExtendedInfo6(const IOAddress& /* addr */) {
void void
MySqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */, MySqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& relay_id) { const vector<uint8_t>& /* relay_id */) {
isc_throw(NotImplemented, "MySqlLeaseMgr::addRelayId6 not implemented"); isc_throw(NotImplemented, "MySqlLeaseMgr::addRelayId6 not implemented");
} }
void void
MySqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */, MySqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& remote_id) { const vector<uint8_t>& /* remote_id */) {
isc_throw(NotImplemented, "MySqlLeaseMgr::addRemoteId6 not implemented"); isc_throw(NotImplemented, "MySqlLeaseMgr::addRemoteId6 not implemented");
} }

11
src/lib/dhcpsrv/mysql_lease_mgr.h
View File

@@ -1145,6 +1145,17 @@ protected:
} }
} }
/// @brief Decode parameters to set whether the lease extended info tables
/// are enabled.
///
/// @note: common code in constructors.
///
/// @param parameters The parameter map.
virtual void setExtendedInfoTablesEnabled(const db::DatabaseConnection::ParameterMap& /* parameters */) override {
isc_throw(isc::NotImplemented,
"extended info tables are not yet supported by mysql");
}
/// @brief Delete lease6 extended info from tables. /// @brief Delete lease6 extended info from tables.
/// ///
/// @param addr The address of the lease. /// @param addr The address of the lease.

4
src/lib/dhcpsrv/pgsql_lease_mgr.cc
View File

@@ -2567,14 +2567,14 @@ PgSqlLeaseMgr::deleteExtendedInfo6(const IOAddress& /* addr */) {
void void
PgSqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */, PgSqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& relay_id) { const vector<uint8_t>& /* relay_id */) {
isc_throw(NotImplemented, "PgSqlLeaseMgr::addRelayId6 not implemented"); isc_throw(NotImplemented, "PgSqlLeaseMgr::addRelayId6 not implemented");
} }
void void
PgSqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */, PgSqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& remote_id) { const vector<uint8_t>& /* remote_id */) {
isc_throw(NotImplemented, "PgSqlLeaseMgr::addRemoteId6 not implemented"); isc_throw(NotImplemented, "PgSqlLeaseMgr::addRemoteId6 not implemented");
} }

15
src/lib/dhcpsrv/pgsql_lease_mgr.h
View File

@@ -1104,6 +1104,21 @@ protected:
} }
} }
/// @brief Decode parameters to set whether the lease extended info tables
/// are enabled.
///
/// @note: common code in constructors.
///
/// @param parameters The parameter map.
virtual void setExtendedInfoTablesEnabled(const db::DatabaseConnection::ParameterMap& /* parameters */) override {
isc_throw(isc::NotImplemented,
"extended info tables are not yet supported by mysql");
}
/// @brief Delete lease6 extended info from tables.
///
/// @param addr The address of the lease.
/// @brief Delete lease6 extended info from tables. /// @brief Delete lease6 extended info from tables.
/// ///
/// @param addr The address of the lease. /// @param addr The address of the lease.

4
src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
View File

@@ -407,7 +407,7 @@ public:
void void
addRelayId6(const IOAddress& /* lease_addr */, addRelayId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& relay_id) override { const vector<uint8_t>& /* relay_id */) override {
isc_throw(NotImplemented, "ConcreteLeaseMgr::addRelayId6 not implemented"); isc_throw(NotImplemented, "ConcreteLeaseMgr::addRelayId6 not implemented");
} }
@@ -415,7 +415,7 @@ public:
void void
addRemoteId6(const IOAddress& /* lease_addr */, addRemoteId6(const IOAddress& /* lease_addr */,
const IOAddress& /* link_addr */, const IOAddress& /* link_addr */,
const vector<uint8_t>& remote_id) override { const vector<uint8_t>& /* remote_id */) override {
isc_throw(NotImplemented, "ConcreteLeaseMgr::addRemoteId6 not implemented"); isc_throw(NotImplemented, "ConcreteLeaseMgr::addRemoteId6 not implemented");
} }