mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 05:55:28 +00:00
Code Issues Releases Wiki Activity

[3927] Addressed minor comments

Browse Source
This commit is contained in:
Francis Dupont
2015-11-04 03:24:03 +01:00
parent cedbc8083e
commit 812b9eb21b
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
View File

@@ -481,7 +481,7 @@ TEST_F(ParseConfigTest, basicOptionDefTest) {
// Verify that the configuration string parses. // Verify that the configuration string parses.
int rcode = parseConfiguration(config); int rcode = parseConfiguration(config);
ASSERT_TRUE(rcode == 0); ASSERT_EQ(0, rcode);
// Verify that the option definition can be retrieved. // Verify that the option definition can be retrieved.
@@ -514,7 +514,7 @@ TEST_F(ParseConfigTest, minimalOptionDefTest) {
// Verify that the configuration string parses. // Verify that the configuration string parses.
int rcode = parseConfiguration(config); int rcode = parseConfiguration(config);
ASSERT_TRUE(rcode == 0); ASSERT_EQ(0, rcode);
// Verify that the option definition can be retrieved. // Verify that the option definition can be retrieved.
@@ -547,7 +547,7 @@ TEST_F(ParseConfigTest, defaultSpaceOptionDefTest) {
// Verify that the configuration string parses. // Verify that the configuration string parses.
int rcode = parseConfiguration(config); int rcode = parseConfiguration(config);
ASSERT_TRUE(rcode == 0); ASSERT_TRUE(0, rcode);
// Verify that the option definition can be retrieved. // Verify that the option definition can be retrieved.
@@ -590,13 +590,13 @@ TEST_F(ParseConfigTest, basicOptionDataTest) {
// Verify that the configuration string parses. // Verify that the configuration string parses.
int rcode = parseConfiguration(config); int rcode = parseConfiguration(config);
ASSERT_TRUE(rcode == 0); ASSERT_TRUE(0, rcode);
// Verify that the option can be retrieved. // Verify that the option can be retrieved.
OptionPtr opt_ptr = getOptionPtr("isc", 100); OptionPtr opt_ptr = getOptionPtr("isc", 100);
ASSERT_TRUE(opt_ptr); ASSERT_TRUE(opt_ptr);
// Verify that the option definition is correct. // Verify that the option data is correct.
std::string val = "type=00100, len=00004: 192.0.2.0 (ipv4-address)"; std::string val = "type=00100, len=00004: 192.0.2.0 (ipv4-address)";
EXPECT_EQ(val, opt_ptr->toText()); EXPECT_EQ(val, opt_ptr->toText());
@@ -624,13 +624,13 @@ TEST_F(ParseConfigTest, minimalOptionDataTest) {
// Verify that the configuration string parses. // Verify that the configuration string parses.
int rcode = parseConfiguration(config); int rcode = parseConfiguration(config);
ASSERT_TRUE(rcode == 0); ASSERT_TRUE(0, rcode);
// Verify that the option can be retrieved. // Verify that the option can be retrieved.
OptionPtr opt_ptr = getOptionPtr("isc", 100); OptionPtr opt_ptr = getOptionPtr("isc", 100);
ASSERT_TRUE(opt_ptr); ASSERT_TRUE(opt_ptr);
// Verify that the option definition is correct. // Verify that the option data is correct.
std::string val = "type=00100, len=00004: 192.0.2.0 (ipv4-address)"; std::string val = "type=00100, len=00004: 192.0.2.0 (ipv4-address)";
EXPECT_EQ(val, opt_ptr->toText()); EXPECT_EQ(val, opt_ptr->toText());