mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-03 07:25:18 +00:00
Code Issues Releases Wiki Activity

[2369] Fix test, skipping backwards before doing newline check

Browse Source
This commit is contained in:
Mukund Sivaraman
2012-10-29 08:11:06 +05:30
parent 29ff6bebc9
commit 8aa5e22a0f
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/dns/inputsource.cc
View File

@@ -55,10 +55,10 @@ InputSource::ungetChar() {
} else if (buffer_pos_ == 0) { } else if (buffer_pos_ == 0) {
isc_throw(OutOfRange, "Cannot skip before the start of buffer"); isc_throw(OutOfRange, "Cannot skip before the start of buffer");
} else { } else {
buffer_pos_--;
if (buffer_[buffer_pos_] == '\n') { if (buffer_[buffer_pos_] == '\n') {
line_--; line_--;
} }
buffer_pos_--;
} }
} }

4
src/lib/dns/tests/inputsource_unittest.cc
View File

@@ -132,8 +132,10 @@ TEST_F(InputSourceTest, lines) {
EXPECT_TRUE(source_.atEOF()); EXPECT_TRUE(source_.atEOF());
EXPECT_EQ(4, source_.getCurrentLine()); EXPECT_EQ(4, source_.getCurrentLine());
// Go backwards 1 character, skipping the last '\n'. // Go backwards 2 characters, skipping the last EOF and '\n'.
source_.ungetChar(); source_.ungetChar();
source_.ungetChar();
EXPECT_FALSE(source_.atEOF()); EXPECT_FALSE(source_.atEOF());
EXPECT_EQ(3, source_.getCurrentLine()); EXPECT_EQ(3, source_.getCurrentLine());