mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-28 20:47:48 +00:00
Code Issues Releases Wiki Activity

[#544] Addressed review comments

Browse Source 
Minor clean ups.
This commit is contained in:
Thomas Markwalder 2020-07-21 08:47:08 -04:00
parent b585ea42d8
commit 95d10187cc
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/sphinx/arm/hooks-lease-cmds.rst
View File

@ -723,8 +723,8 @@ leases were found.
.. _command-lease6-get-by-hostname: .. _command-lease6-get-by-hostname:
The lease4-get-by-*, lease6-get-by-* Commands The lease4-get-by-\*, lease6-get-by-\* Commands
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
``leaseX-get-by-Y`` can be used to query the lease database and ``leaseX-get-by-Y`` can be used to query the lease database and
retrieve all existing leases with a specified hardware address (IPv4 retrieve all existing leases with a specified hardware address (IPv4
@ -802,7 +802,7 @@ An example IPv4 lease deletion by "hw-address" is:
} }
As of Kea 1.7.10, a new parameter, "update-ddns", is supported (IPv4 and IPv6). As of Kea 1.7.10, a new parameter, ``update-ddns``, is supported (IPv4 and IPv6).
When true it instructs the server to queue a request to kea-dhcp-ddns to When true it instructs the server to queue a request to kea-dhcp-ddns to
remove DNS entries after the lease is successfully deleted if: remove DNS entries after the lease is successfully deleted if:

3
src/hooks/dhcp/lease_cmds/lease_cmds.h
View File

@ -92,6 +92,9 @@ public:
/// where multiple IPv6 addresses and/or prefixes can be allocated for /// where multiple IPv6 addresses and/or prefixes can be allocated for
/// a single DHCPv6 packet. /// a single DHCPv6 packet.
/// ///
/// @note Unlike leaseX-del, this command does not support "update-ddns" and
/// this will not generate CHG_REMOVEs for deleted leases.
///
/// Example structure of the command: /// Example structure of the command:
/// ///
/// { /// {

2
src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc
View File

@ -5520,7 +5520,6 @@ TEST_F(LeaseCmdsTest, lease6DnsRemoveD2Enabled) {
"{" "{"
" \"command\": \"lease6-del\"," " \"command\": \"lease6-del\","
" \"arguments\": {" " \"arguments\": {"
" \"subnet-id\": 66,\n"
" \"ip-address\": \"2001:db8:1::8\"\n"; " \"ip-address\": \"2001:db8:1::8\"\n";
if (!scenario.update_ddns_.empty()) { if (!scenario.update_ddns_.empty()) {
@ -5561,7 +5560,6 @@ TEST_F(LeaseCmdsTest, lease6DnsRemoveD2Disabled) {
"{\n" "{\n"
" \"command\": \"lease6-del\",\n" " \"command\": \"lease6-del\",\n"
" \"arguments\": {\n" " \"arguments\": {\n"
" \"subnet-id\": 66,\n"
" \"ip-address\": \"2001:db8:1::8\",\n" " \"ip-address\": \"2001:db8:1::8\",\n"
" \"update-ddns\": true\n" " \"update-ddns\": true\n"
" }\n" " }\n"